Browse: instance classification number | Synchronize browse config with classification types changes

Description

Overview

Browse configuration could contain classification type IDs for filtering results for each browse option. In case classifiacation types was deleted from classification type settings then it should be synchronized with browse configuration.

Requirements

  1. On updating browse config validate that IDs are valid and exist in classifiacation types settings,

  2. When classifiacation type deleted from settings then it should be deleted from browse configuration

Approach

  1. On PUT request validate IDs

    1. Use HTTP request to check if this IDs exists in mod-inventory-storage

  2. Sync browse config with changes in mod-inventory-storage

    1. Consume events from inventory.classification-type topic with filtering by DELETE type

    2. Delete ID from browse config

Acceptance

  • implementation meets requirements

  • covered by unit tests

  • covered by intetgration tests

Environment

None

Potential Workaround

None

CSP Request Details

None

CSP Rejection Details

None

CSP Approved

None

Attachments

3

has to be done before

relates to

Checklist

hide

Activity

Show:

Valery_Pilko March 13, 2024 at 3:38 PM

Re-tested on Spitfire Rancher environment (due to build problem on Snapshot) - issue from previous comment (scenario 2) is fixed.
See attached screencast:

Valery_Pilko March 11, 2024 at 6:13 PM

Hi
Main scenario works as expected:
1) Create new “Classification identifier type” >> Update some browse config with typeId of created “Classification identifier type” >> Delete created “Classification identifier type” from UI.
Actual result: typeId of deleted “Classification identifier type” was deleted from browse config. - works as expected.
See attached screencast:

  1. Scenario 2 (Issue) - user can update "typeIds" with UUID of already deleted “Classification identifier type” if it was assigned to some browse config.
    Actual result: typeId of deleted “Classification identifier type” is added to browse config via PUT request.
    Expected result: Validation for non-existing classification type should occur.
    See attached screencast:

    Could you please review described issue in scenario 2?

Done

Details

Assignee

Reporter

Priority

Story Points

Sprint

Development Team

Spitfire

Fix versions

Release

Quesnelia (R1 2024)

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created February 27, 2024 at 8:16 AM
Updated March 25, 2024 at 4:24 PM
Resolved March 14, 2024 at 1:17 PM
TestRail: Cases
TestRail: Runs