Call number browse: preceding records still not being returned

Description

Purpose/Overview: In scope of it was discovered that none of the preceding results will be returned in case there are >=25 (minimum elasticsearch query limit for preceding records) succeeding result with the same first 10 symbols of shelving order. This is tied to the algorithm that is uses first 10 symbols of shelving order to create a long value for elasticsearch range query. We completed work in Orchid (MSEARCH-503)to make an additional query when preceding records are empty. However, this issue appears to still be occurring in the Five Colleges sandbox environment in Orchid. In one example, there are more then 60 call numbers with the same first 10 characters of the shelving order (E 3184 S75) and when browsing, the previous button is disabled.  

 

 

 

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Attachments

4

Checklist

hide

TestRail: Results

Activity

Show:

Artur Hovhannisyan1July 17, 2023 at 8:44 AM

Hey ,

The new issue appears while browsing by call number with the same first 11 symbols of the shelving order(tested with the same first 11 - 20 symbols of the shelving order behavior is the same). The issue's root cause is the Open Search response which returned succeding and preceding results in the wrong order. With this incorrect response, mod-search browsing default response processing creates incorrect results with part of the succeding results in the preceding part. Ex.
1.  Create 25 "Item" records

Y123456789_1
Y123456789_2

Y123456789_3

.....
Y123456789_34
Y123456789_35

2.  Search for the second call number value from step 1, ex.: "Y123456789_2".
Expected result: the preceding results are returned (from "Y123456789_1"). The succeeding result contains records (from "Y123456789_2" to "Y123456789_27").
Actual result: the preceding results are returned ( Y123456789_1 from "Y123456789_10" to "Y123456789_19"). The succeeding result missing records(from "Y123456789_10" to "Y123456789_19").

Christine Schultz-RichertJuly 14, 2023 at 2:08 PM

Hey - would you do me a favor and write a comment on what we think the root cause of the issue described?

Yauhen ViazauJuly 14, 2023 at 1:13 PM

As per discussion with PO and the team - issue described above is out of scope of this ticket. It might be addressed in a new story

Yauhen ViazauJuly 12, 2023 at 3:24 PM

Tested on Snapshot-2 - issue found

  • Works as expected when using call numbers "E 3184 S75 1230" - "E 3184 S75 1255", and adding all items to different instances:

    •  

  • When using call numbers "Y123456789_1" - "Y123456789_26", and adding all items to the same instance:

    • Works OK when searching first call number

    • Preceding call numbers from the same instance not shown when searching for any call number other than first

    • See screencast -

, - please review

Valery_PilkoJuly 5, 2023 at 4:32 PM

Hi  
I've tested the fix on Snapshot-2 environment - the issue still reproduces.
Steps:
1. Create 26 "Item" records in different "Holdings" of different "Instances" with following "call number" values:
from E 3184 S75 1230
to E 3184 S75 1255
2. Run browse according to following table:

Browse for following call number

Actual result

Works as expected?

E 3184 S75 1230

the preceding results are returned (which existed in the system before), ex.:
A 1958 A 8050
D15.H63 A3 2002
DE3

Yes

E 3184 S75 1231

Only created preceding result is returned: E 3184 S75 1230 
"Previous" pagination button is disabled

NO

E 3184 S75 1232

Only created preceding result are returned: E 3184 S75 1230, E 3184 S75 1231
"Previous" pagination button is disabled

NO

E 3184 S75 1233

Only created preceding result are returned: E 3184 S75 1230, E 3184 S75 1231, E 3184 S75 1232
"Previous" pagination button is disabled

NO

E 3184 S75 1234

Only created preceding result are returned: E 3184 S75 1230, E 3184 S75 1231, E 3184 S75 1232, E 3184 S75 1233 
"Previous" pagination button is disabled

NO

E 3184 S75 1235

Only created preceding result are returned: E 3184 S75 1230, E 3184 S75 1231, E 3184 S75 1232, E 3184 S75 1233,  E 3184 S75 1234
"Previous" pagination button is disabled

NO

E 3184 S75 1236

All preceding result are returned:
Current page: E 3184 S75 1230, E 3184 S75 1231, E 3184 S75 1232, E 3184 S75 1233, E 3184 S75 1234, E 3184 S75 1235
Previous page: A 1958 A 8050, D15.H63 A3 2002, DE3
"Previous" pagination button is active

Yes

See screencast for details:

 

Done

Details

Assignee

Reporter

Priority

Story Points

Sprint

Development Team

Spitfire

Fix versions

Release

Poppy (R2 2023)

RCA Group

Data related (ex. Can be detected with large dataset only)

Affected releases

Orchid (R1 2023)

Affected Institution

5 Colleges

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created June 9, 2023 at 3:06 PM
Updated May 21, 2024 at 8:25 PM
Resolved July 18, 2023 at 1:46 PM
TestRail: Cases
TestRail: Runs