Can't see more than 10 desks in Switch service desk modal

Description

When I am a user with more than 10 service desks assigned,
and I go to Switch service desk in my profile,
I expect to see all the Service desks at which I am assigned.

Actual behavior: only 10 service points show.

This is a low priority because very few users will have more than 10 service points in reality.

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Attachments

1

Checklist

hide

TestRail: Results

Activity

Show:

Cate Boerema August 18, 2020 at 9:32 AM

Tested in https://folio-snapshot-core.dev.folio.org/ and it works great. Thanks !

Kyle Felker June 2, 2020 at 6:32 PM
Edited

Okay, after looking at this with Michael and Zak, we've determined this isn't something that can be fixed on the front end. The modal won't show all the servicepoints because the back end module isn't returning details about all of them-only the first ten. I've excerpted an example of the response from mod-users-bl for a user with twelve service points assigned upon login. As you can see, while it returns all the ids for all the assigned service points in the servicePointsUser.servicePointsIds field, it's only returning the details for the first ten in servicePointsUser.servicePoints, and that's what ui-servicepoints is using to construct the modal. It doesn't look like the call to mod-users-bl supports a limit parameter we can use to ask for more servicepoints-at least, not according to the docs.

{{ "proxiesFor" : [ ],
"servicePointsUser" : {
"id" : "a79b242b-8f5a-4ffe-872b-46a494d57720",
"userId" : "3ee6a4fc-5f51-5bfa-acc3-582e0896cd1f",
"servicePointsIds" : [ "3a40852d-49fd-4df2-a1f9-6e2641a6e91f", "c4c90014-c8c9-4ade-8f24-b5e313319f4b", "13706155-6ddc-42cc-a6e1-2174fafa4a12", "ec3a2a4b-94dd-47f6-8885-88e2d7245aef", "c679158c-7c7b-4016-a601-fbd480536e50", "99110f09-4d3e-4af1-8568-d37666e21ce7", "b451485c-6c04-4ab9-94b1-1e6c0deb77c7", "7c5abc9f-f3d7-4856-b8d7-6712462ca007", "0352e817-f728-495d-8944-b94ffcf32ab0", "13dee256-c0a1-40c5-8139-b1e992883186", "f69d2835-f775-41f2-b568-e0e82f68ec84", "e346f0f0-7e24-48fd-9bde-d6ce3583ce39" ],
"servicePoints" : [ {
"id" : "7c5abc9f-f3d7-4856-b8d7-6712462ca007",
"name" : "Online",
"code" : "Online",
"discoveryDisplayName" : "Online",
"shelvingLagTime" : 0,
"pickupLocation" : false,
"staffSlips" : [ ],
"locationIds" : [ ],
"metadata" : {
"createdDate" : "2020-06-02T02:50:54.972+0000",
"updatedDate" : "2020-06-02T02:50:54.972+0000"
}
}, {
"id" : "c4c90014-c8c9-4ade-8f24-b5e313319f4b",
"name" : "Circ Desk 2",
"code" : "cd2",
"discoveryDisplayName" : "Circulation Desk – Back Entrance",
"pickupLocation" : true,
"staffSlips" : [ ],
"locationIds" : [ ],
"metadata" : {
"createdDate" : "2020-06-02T02:50:54.983+0000",
"updatedDate" : "2020-06-02T02:50:54.983+0000"
},
"holdShelfExpiryPeriod" : {
"duration" : 5,
"intervalId" : "Days"
}
}, {
"id" : "3a40852d-49fd-4df2-a1f9-6e2641a6e91f",
"name" : "Circ Desk 1",
"code" : "cd1",
"discoveryDisplayName" : "Circulation Desk – Hallway",
"pickupLocation" : true,
"staffSlips" : [ ],
"locationIds" : [ ],
"metadata" : {
"createdDate" : "2020-06-02T02:50:54.988+0000",
"updatedDate" : "2020-06-02T02:50:54.988+0000"
},
"holdShelfExpiryPeriod" : {
"duration" : 3,
"intervalId" : "Weeks"
}
}, {
"id" : "c679158c-7c7b-4016-a601-fbd480536e50",
"name" : "first floor",
"code" : "fl1",
"discoveryDisplayName" : "first floor",
"staffSlips" : [ {
"id" : "6a6e72f0-69da-4b4c-8254-7154679e9d88",
"printByDefault" : true
}, {
"id" : "8812bae1-2738-442c-bc20-fe4bb38a11f8",
"printByDefault" : true
}, {
"id" : "1ed55c5c-64d9-40eb-8b80-7438a262288b",
"printByDefault" : true
}, {
"id" : "f838cdaf-555a-473f-abf1-f35ef6ab8ae1",
"printByDefault" : true
} ],
"locationIds" : [ ],
"metadata" : {
"createdDate" : "2020-06-02T17:36:39.059+0000",
"createdByUserId" : "3ee6a4fc-5f51-5bfa-acc3-582e0896cd1f",
"updatedDate" : "2020-06-02T17:36:39.059+0000",
"updatedByUserId" : "3ee6a4fc-5f51-5bfa-acc3-582e0896cd1f"
}
}, {
"id" : "0352e817-f728-495d-8944-b94ffcf32ab0",
"name" : "second floor",
"code" : "fl2",
"discoveryDisplayName" : "second foor",
"staffSlips" : [ {
"id" : "6a6e72f0-69da-4b4c-8254-7154679e9d88",
"printByDefault" : true
}, {
"id" : "8812bae1-2738-442c-bc20-fe4bb38a11f8",
"printByDefault" : true
}, {
"id" : "1ed55c5c-64d9-40eb-8b80-7438a262288b",
"printByDefault" : true
}, {
"id" : "f838cdaf-555a-473f-abf1-f35ef6ab8ae1",
"printByDefault" : true
} ],
"locationIds" : [ ],
"metadata" : {
"createdDate" : "2020-06-02T17:36:57.833+0000",
"createdByUserId" : "3ee6a4fc-5f51-5bfa-acc3-582e0896cd1f",
"updatedDate" : "2020-06-02T17:36:57.833+0000",
"updatedByUserId" : "3ee6a4fc-5f51-5bfa-acc3-582e0896cd1f"
}
}, {
"id" : "e346f0f0-7e24-48fd-9bde-d6ce3583ce39",
"name" : "third floor",
"code" : "fl3",
"discoveryDisplayName" : "third floor",
"staffSlips" : [ {
"id" : "6a6e72f0-69da-4b4c-8254-7154679e9d88",
"printByDefault" : true
}, {
"id" : "8812bae1-2738-442c-bc20-fe4bb38a11f8",
"printByDefault" : true
}, {
"id" : "1ed55c5c-64d9-40eb-8b80-7438a262288b",
"printByDefault" : true
}, {
"id" : "f838cdaf-555a-473f-abf1-f35ef6ab8ae1",
"printByDefault" : true
} ],
"locationIds" : [ ],
"metadata" : {
"createdDate" : "2020-06-02T17:37:11.945+0000",
"createdByUserId" : "3ee6a4fc-5f51-5bfa-acc3-582e0896cd1f",
"updatedDate" : "2020-06-02T17:37:11.945+0000",
"updatedByUserId" : "3ee6a4fc-5f51-5bfa-acc3-582e0896cd1f"
}
}, {
"id" : "99110f09-4d3e-4af1-8568-d37666e21ce7",
"name" : "fourth floor",
"code" : "fl4",
"discoveryDisplayName" : "fourth floor",
"staffSlips" : [ {
"id" : "6a6e72f0-69da-4b4c-8254-7154679e9d88",
"printByDefault" : true
}, {
"id" : "8812bae1-2738-442c-bc20-fe4bb38a11f8",
"printByDefault" : true
}, {
"id" : "1ed55c5c-64d9-40eb-8b80-7438a262288b",
"printByDefault" : true
}, {
"id" : "f838cdaf-555a-473f-abf1-f35ef6ab8ae1",
"printByDefault" : true
} ],
"locationIds" : [ ],
"metadata" : {
"createdDate" : "2020-06-02T17:37:26.321+0000",
"createdByUserId" : "3ee6a4fc-5f51-5bfa-acc3-582e0896cd1f",
"updatedDate" : "2020-06-02T17:37:26.321+0000",
"updatedByUserId" : "3ee6a4fc-5f51-5bfa-acc3-582e0896cd1f"
}
}, {
"id" : "ec3a2a4b-94dd-47f6-8885-88e2d7245aef",
"name" : "fifth floor",
"code" : "fl5",
"discoveryDisplayName" : "fifth floor",
"staffSlips" : [ {
"id" : "6a6e72f0-69da-4b4c-8254-7154679e9d88",
"printByDefault" : true
}, {
"id" : "8812bae1-2738-442c-bc20-fe4bb38a11f8",
"printByDefault" : true
}, {
"id" : "1ed55c5c-64d9-40eb-8b80-7438a262288b",
"printByDefault" : true
}, {
"id" : "f838cdaf-555a-473f-abf1-f35ef6ab8ae1",
"printByDefault" : true
} ],
"locationIds" : [ ],
"metadata" : {
"createdDate" : "2020-06-02T17:37:43.139+0000",
"createdByUserId" : "3ee6a4fc-5f51-5bfa-acc3-582e0896cd1f",
"updatedDate" : "2020-06-02T17:37:43.139+0000",
"updatedByUserId" : "3ee6a4fc-5f51-5bfa-acc3-582e0896cd1f"
}
}, {
"id" : "f69d2835-f775-41f2-b568-e0e82f68ec84",
"name" : "sixth floor",
"code" : "fl6",
"discoveryDisplayName" : "sixth floor",
"staffSlips" : [ {
"id" : "6a6e72f0-69da-4b4c-8254-7154679e9d88",
"printByDefault" : true
}, {
"id" : "8812bae1-2738-442c-bc20-fe4bb38a11f8",
"printByDefault" : true
}, {
"id" : "1ed55c5c-64d9-40eb-8b80-7438a262288b",
"printByDefault" : true
}, {
"id" : "f838cdaf-555a-473f-abf1-f35ef6ab8ae1",
"printByDefault" : true
} ],
"locationIds" : [ ],
"metadata" : {
"createdDate" : "2020-06-02T17:37:59.312+0000",
"createdByUserId" : "3ee6a4fc-5f51-5bfa-acc3-582e0896cd1f",
"updatedDate" : "2020-06-02T17:37:59.312+0000",
"updatedByUserId" : "3ee6a4fc-5f51-5bfa-acc3-582e0896cd1f"
}
}, {
"id" : "13dee256-c0a1-40c5-8139-b1e992883186",
"name" : "seventh floor",
"code" : "fl7",
"discoveryDisplayName" : "seventh floor",
"staffSlips" : [ {
"id" : "6a6e72f0-69da-4b4c-8254-7154679e9d88",
"printByDefault" : true
}, {
"id" : "8812bae1-2738-442c-bc20-fe4bb38a11f8",
"printByDefault" : true
}, {
"id" : "1ed55c5c-64d9-40eb-8b80-7438a262288b",
"printByDefault" : true
}, {
"id" : "f838cdaf-555a-473f-abf1-f35ef6ab8ae1",
"printByDefault" : true
} ],
"locationIds" : [ ],
"metadata" : {
"createdDate" : "2020-06-02T17:38:19.517+0000",
"createdByUserId" : "3ee6a4fc-5f51-5bfa-acc3-582e0896cd1f",
"updatedDate" : "2020-06-02T17:38:19.517+0000",
"updatedByUserId" : "3ee6a4fc-5f51-5bfa-acc3-582e0896cd1f"
}
} ],
"defaultServicePointId" : "7c5abc9f-f3d7-4856-b8d7-6712462ca007",
"metadata" : {
"createdDate" : "2020-06-02T02:52:12.115+0000",
"updatedDate" : "2020-06-02T17:49:43.693+0000",
"updatedByUserId" : "3ee6a4fc-5f51-5bfa-acc3-582e0896cd1f"
}
}
}}}

Kyle Felker June 1, 2020 at 3:24 PM

Moved this issue-the code that generates this modal is in ui-servicepoints.

Cate Boerema May 29, 2020 at 3:56 PM

Decided to allow 1,000

Should create a test to check that you can view 11

Done

Details

Assignee

Reporter

Priority

Story Points

Sprint

Development Team

Prokopovych

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created September 26, 2019 at 10:17 PM
Updated October 7, 2020 at 9:46 AM
Resolved August 18, 2020 at 9:32 AM
TestRail: Cases
TestRail: Runs