Impossible to login as users created via APIs

Description

As discussed in UIU-321, it is presently not possible to log in as any user created via the standard user, credentials and permissions APIs. This includes both users created from within the FOLIO API, and all the pre-created users except diku_admin. (That one is a special case, a its password is bootstrapped directly into the database rather then being created though the APIs).

Here's what gets reported when trying to login as a valid non-diku_admin user:

(It's nice that the HTTP response body contains actual information!)

But here is an oddity: reports that he can log in as user "frida" with password "frida" on http://folio-testing-backend01.aws.indexdata.com/authn/login – so it seems the problem only occurs when using the higher-level login wrapper provided by users-bl.

So it's not clear whether the problem is in users-bl's login code, or in the APIs used to create the users. Either way, I figure will figure it out

I have P1'd this, because one of its consequences is that the integration tests always fail, and so we're learning to ignore integration-test failures – which is not good, as this problem may well be masking others by now!

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Mike TaylorNovember 24, 2017 at 5:29 PM

Thank you! Seeing this go through would make a monumentally stupid day feel not entirely wasted, somehow.

Kurt NordstromNovember 24, 2017 at 5:27 PM

I have pushed a pull request that should address this. Once the checks pass, I'll merge it into master.

Mike TaylorNovember 24, 2017 at 4:52 PM

This is worse that I realised. It now turns out that if you make any edit to a user record, it then becomes impossible to log in as them.

And because of recent changes that mean permission assignment is now done on the edit page instead of the view-user page, that means that it's impossible to add permissions to a user without destroying that user for practical purposes.

That means I can't add module.search.enabled to diku_admin, so I can't work on the new ui-search (Codex) module. So this bug is stuffing up absolutely everything. I wish there was a way to P0 it.

Cate BoeremaNovember 23, 2017 at 12:28 PM

Oh, I guess we didn't. Just checked folio-stable. Ignore me

Mike TaylorNovember 23, 2017 at 12:17 PM

How sure are you that we ever did?

Done

Details

Assignee

Reporter

Priority

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created November 21, 2017 at 3:25 PM
Updated June 12, 2020 at 3:41 PM
Resolved November 28, 2017 at 1:35 PM
TestRail: Cases
TestRail: Runs