Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Fix handling of liquibase fails

Description

In the class ModTenantAPI method "loadData" doesn't pay attention on error messages from liquibase (it gives back "successfully" in any case)

 

Steps to reproduce:

  1. rebuild SRS with folio-liquibase-util-1.5.0-SNAPSHOT

  2. vagrant up

  3. change the value in the "md5sum" field in the "diku_mod_source_record_storage.databasechangelog" table to any value

  4. run POST request to SRS:
    for example:

  1. check response

 

Expected result (see "error message"):

Additional info:
We can call the /_/tenant/$id API (again) with a wait parameter until "complete" is true, see description above.
Example: /_/tenant/458b6397-c4d2-46b2-a771-ace8a310bcea?wait=30000

 

A.I.: Added Wiki page to include in Release notes for module upgrades (not to miss the errors).
https://folio-org.atlassian.net/wiki/display/FOLIJET/Module+upgrade+via+Tenant+API 

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Kateryna SenchenkoApril 6, 2022 at 10:45 AM

Hi , yes, I think we can relink it to Lotus, no release required, and we should mention it in Lotus and MG release notes. Thank you!

Ann-Marie BreauxApril 6, 2022 at 9:45 AM

Hi Should this be in release notes for Lotus or Morning Glory (or both)? It's linked to a MG feature, but I'm not sure. If it also applies to Lotus, I can re-link to a Lotus feature, since it looks like there's no code that was merged, so nothing needs to be released, right?

Aivar IusupovApril 6, 2022 at 8:09 AM

Added Wiki page to include in Release notes for module upgrades (not to miss the errors).
https://folio-org.atlassian.net/wiki/display/FOLIJET/Module+upgrade+via+Tenant+API 

Kateryna SenchenkoMarch 25, 2022 at 1:14 PM

Hi , let's push this issue to MG, it is not critical, and we rather spend remaining time before Lotus final release on more pressing issues. Thank you

Ann-Marie BreauxMarch 1, 2022 at 4:13 PM

Thanks, I changed it to a bug. If we finish during the next couple sprints, great. If not, we'll push it out to MG

Done

Details

Assignee

Reporter

Labels

Priority

Story Points

Sprint

Development Team

Folijet

Parent

Release

Lotus R1 2022

RCA Group

Requirements change

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created February 23, 2022 at 3:07 PM
Updated April 4, 2023 at 8:26 PM
Resolved April 6, 2022 at 1:35 PM
TestRail: Cases
TestRail: Runs