Fix existing secure request workflow issues - Mediated requests related
Description
Module: mod-requests-mediated Action: confirm mediated request (shared instance). Issue: ECS request created with real delivery info initially, later mod-requests-mediated changes it to Interim SP in the Primary request. This triggers an event that updates Secondary request with Interim SP info as well. Solution: Create ECS request with Interim SP from the beginning, only update requester info later (this should already work). Applies to both shared instance and oLOAN collection local requests.
Module: mod-requests-mediated Action: "Confirm arrival" Issue: mod-request-mediated updates the Primary request with real delivery info which triggers the request update event. mod-request-mediated handles this event and changes mediated request status back to "Open - In transit for approval" (because primary request has status "Open - Not yet filled"). Solution: Only react to Primary request's status "Open - in transit" when 1) it has changed and 2) mediated re quest status is "Open - In transit for approval". Apply the same strict approach to other status changes.
oLOAN collection (local requests) - do not change delivery info to Interim SP.
All of these changes were implemented in scope of the spike .
In scope:
Using implementation from the branch ‘MODREQMED-83’, create a PR.
Module: mod-requests-mediated
Action: confirm mediated request (shared instance).
Issue: ECS request created with real delivery info initially, later mod-requests-mediated changes it to Interim SP in the Primary request. This triggers an event that updates Secondary request with Interim SP info as well.
Solution: Create ECS request with Interim SP from the beginning, only update requester info later (this should already work). Applies to both shared instance and oLOAN collection local requests.
Module: mod-requests-mediated
Action: "Confirm arrival"
Issue: mod-request-mediated updates the Primary request with real delivery info which triggers the request update event. mod-request-mediated handles this event and changes mediated request status back to "Open - In transit for approval" (because primary request has status "Open - Not yet filled").
Solution: Only react to Primary request's status "Open - in transit" when 1) it has changed and 2) mediated re quest status is "Open - In transit for approval". Apply the same strict approach to other status changes.
oLOAN collection (local requests) - do not change delivery info to Interim SP.
All of these changes were implemented in scope of the spike .
In scope:
Using implementation from the branch ‘MODREQMED-83’, create a PR.
Cover changes with tests.