Upgrading to Nolana to Orchid-GA fails when the upgrade from mod-data-import-converter-storage to mod-di-converter-storage (rename!) is executed before the upgrade from mod-permissions.

Reason: The module rename requires the Orchid version of mod-permissions.

Error:

Fix: Add a dependency to ModuleDescriptors to enforce the upgrade order:

• Bump mod-permissions' permissions interface from 5.5 to 5.6.

• Add a permissions 5.6 dependency to mod-di-converter-storage.

Describe issue impact on business

Upgrading from Nolana to Orchid-GA fails when the upgrade from mod-data-import-converter-storage to mod-di-converter-storage (rename!) is executed before the upgrade of mod-permissions. The mod-di-converter-storage rename contributes to this issue. Okapi determines the upgrade order based on the dependencies declared in module's ModuleDescriptor, however, we missed to add the dependency required for the rename.

What institutions are affected? (field “Effected Institutions” in Jira to be populated)

All institutions that change the module list provided on https://github.com/folio-org/platform-complete because they install more modules or less modules can be affected.

What is the workaround if exists?

No workaround, Okapi uses the same upgrade order (deterministic order) for a given module list so the upgrade will always fail (or will always succeed if the order is correct by chance).

What areas will be impacted by fix (i.e. what areas need to be retested)

Only Okapi's dependency resolution that runs during upgrade is affected because no code is changed. No need to test other areas.

Brief explanation of technical implementation and the level of effort (in workdays) and technical risk (low/medium/high)

Expand ModuleDescriptor, for details see above.

Effort: Less than 1 workday.

Brief explanation of testing required and level of effort (in workdays). Provide test plan agreed with by QA Manager and PO.

No testing needed because only the upgrade is affected.

What is the roll back plan in case the fix does not work?

Institution reinstalls the Nolana backup and doesn't migrate to Orchid.