Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

mod-notify is not passing the "X-Okapi-Request-Id" header to its API calls

Description

In order for Okapi to track API calls properly, the "X-Okapi-Request-Id" header should be passed along when the module makes its own API calls. Since this module is not using the RMB HTTP client, it needs to ensure that the header is passed to the vertx WebClient in "OkapiModulesClientImpl".

Without this header, the calls are disassociated with the initial call, like "check-out-by-barcode", making overall API performance analysis challenging.

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Yusuf Murodov March 11, 2022 at 2:20 PM

 Hi. This ticket will be closed if you have no any objections, I checked logs and it works.
Thanks 

Alexander Kurash December 8, 2021 at 2:46 PM

 You're marked as the assignee for this ticket, are you working on it? Or should we reassign it to someone from the Vega team?

julie.bickle December 1, 2021 at 4:45 PM

Brilliant, thank you Adam!

I am assigning this a P3 rather than a P4, because if this has the potential to contribute in any way to contributing to the performance discussions, then I believe it's worth it. 

Adam Dickmeiss December 1, 2021 at 3:08 PM

This is about mod-notify and the way it handles requests and calls other modules.. mod-notify should pass on X-Okapi-Request-Id when it calls another module. This will allow Okapi to log information about the sequence of events and , thus, improve diagnostics especially with respect to performance.

https://github.com/folio-org/okapi/blob/master/doc/guide.md#x-okapi-headers

It is a minor issue that has no effect on users or the UI.

julie.bickle December 1, 2021 at 3:00 PM

 I'm sorry to admit that I do not understand at all what this bug is about. 
--> Who could walk me through the context, what the expected behaviour should be and what purposes it serves, and what consenquences the current behaviour has?
N.B. I have no technical training but I can understand logic 

Done

Details

Assignee

Reporter

Priority

Story Points

Sprint

Development Team

Vega

Parent

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created September 24, 2019 at 1:55 PM
Updated June 27, 2022 at 7:55 AM
Resolved March 11, 2022 at 2:38 PM
TestRail: Cases
TestRail: Runs