Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Update vertx-pac4j to pac4j v5

Description

If no vertx-pac4j maintainer does this task a FOLIO core platform developer might take this over.

pac4j-5.0.0-RC2 ** has been released on 2021-03-02.

Upgrade https://github.com/pac4j/vertx-pac4j from pac4j-4.4.0 to pac4j-5.0.0-RC2.

Other pac4j libraries have long been upgraded to pac4j v5, for example https://github.com/pac4j/spring-security-pac4j/blob/spring-security-pac4j-6.0.0-RC2/pom.xml#L59

Environment

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Julian Ladisch November 8, 2021 at 11:57 AM

I've tested the pull request on https://folio-demo.gbv.de and it works.

Craig McNally November 4, 2021 at 3:08 PM

apologies on changing the status of this ticket - it was an accident.

Julian Ladisch November 2, 2021 at 4:20 PM

I prefer 2 because mod-login-saml is the only module that uses vertx-pac4j and we can easily switch from v6.0.0-FOLIO.x to the official v6.0.0.

Adam Dickmeiss November 2, 2021 at 3:51 PM
Edited

mod-login-saml PR https://github.com/folio-org/mod-login-saml/pull/86 .. We need to decide:

1. wait until vertx-pac4j 6.0.0 is official , that means not resolve this issue now (block it)

2. update FOLIO vertx-pac4j with upstream vertx-pac4j SNAPSHOT and call it something like 6.0.0-FOLIO.1 + release it.

Adam Dickmeiss October 7, 2021 at 8:26 AM
Edited

This PR https://github.com/pac4j/vertx-pac4j/pull/161 was merged Oct 7 2021 to master of https://github.com/pac4j/vertx-pac4j .

CAS in the cloud LELEU Jérôme
leleuj writes "The next version 6 of vertx-pac4j will be based on Vert.x v4 and pac4j v5, thus on JDK 11"

Done

Details

Assignee

Reporter

Labels

Priority

Story Points

Sprint

Development Team

Core: Platform

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created March 18, 2021 at 12:58 PM
Updated January 10, 2022 at 4:27 PM
Resolved November 8, 2021 at 12:53 PM
TestRail: Cases
TestRail: Runs