Right now, if there are any one of a number of issues with a list, it breaks list migration process and prevents the module from being upgraded. We should make this more resilient, so that when the process fails, it logs the reason but doesn’t kill the whole process.
CSP Request Details
None
CSP Rejection Details
None
Potential Workaround
None
Checklist
hide
Activity
Show:
JenkinsNotificationsDecember 13, 2024 at 2:16 AM
Deployed to the Ramsons bf env. Moved status to In bugfix review from status Awaiting deployment. Please proceed with the verification.
Noah OvercashDecember 11, 2024 at 9:05 PM
Tested this by deploying a failing mod-fqm-manager, all works as expected.
Matt WeaverDecember 5, 2024 at 5:03 PM
Edited
For testing: the changes here should only impact the tenant enable process (so deploys) and GET /lists. To really test this, we need to put some broken lists in the DB (like with invalid field names, etc) and try deploying. FSE already has (they found the issue initially in a test environment), so they can test easily by just deploying in that env. As a result, the important thing for Corsair QA is that everything still works Since GET /lists is used on the Lists app landing page, we can test it pretty easily by just making sure the Lists app still works; it’d completely break if something is wrong here The broken lists will still be broken, but it shouldn’t take down everything else.
Right now, if there are any one of a number of issues with a list, it breaks list migration process and prevents the module from being upgraded. We should make this more resilient, so that when the process fails, it logs the reason but doesn’t kill the whole process.