Handle repeating subfields $v, $w, $y, $z in MARC tags 600, 610, 650, 651, 655

Description

Note: This ticket was originally created as a a bug ticket. During 07/03’s daily, it has been decided to convert this to a story ticket.

Scope:

The subfields $v, $x, $y, and $z of MARC tags 600, 610, 650, 651, and 655 are repeatable. Currently, the mar4ld library only considers the first occurrence of these subfields when creating "subFocus" edges from the Concept resource, except for the four subfields listed below. The purpose of this ticket is to update the mar4ld library to account for repeating subfields when creating subFocus edges.

For each repeating $v, a subFocus edge should be created from Concept to a Form resource.

For each repeating $x, a subFocus edge should be created from Concept to a Topic resource.

For each repeating $y, a subFocus edge should be created from Concept to a Temporal resource.

For each repeating $z, a subFocus edge should be created from Concept to a Place resource.

Currently handled repeating subfields, as implemented in MODLD-287:

  • 650$v

  • 650$z

  • 655$z

Description of the original bug created by

Steps
1) Log in to Marc authority
Create a record with 010 and 100 fields
100 field should have duplicated fields (for example: $a 100a12 $b 100b $c 100c $c 100c2 $d 100d $j 100j $j 100j2 $q 100q $v 100v $v 100v2 $x 100x1 $x 100x2 $y 100y $y 100y2 $z 100z $z 100z2)
Copy ID of created recourse
Perform GET {{host}}/graph/resource/recourse_id
Check that http://bibfra.me/vocab/lite/subFocus has 1 ID for each $v, $x, $y, $z fields (including duplicates)
2) Log in to Inventory
Create new record using 245 and 600 line, 600 line should be absolutely the same as in 100 line from marc authority
Copy ID of created work
Perform GET {{host}}/graph/resource/Work_id
Check that ID of http://bibfra.me/vocab/lite/subjectin outgoingEdges = Recourse ID from p.1
Check http://bibfra.me/vocab/lite/subFocus

AR
Additional records are created for each $v, $x, $y, $z with duplicate values
If you perform GET {{host}}/graph/resource/additional_record
it will include both values, $x 100x1 and $x 100x2 for example
Check the creens

ER
No additional records/ids should be created
http://bibfra.me/vocab/lite/subFocus should consist only records that were created in Marc authority
Each record should consist only 1 value of $v, $x, $y, $z subfields or their duplicates



Environment

None

Potential Workaround

None

Attachments

5
  • 10 Jul 2024, 11:06 AM
  • 10 Jul 2024, 11:06 AM
  • 10 Jul 2024, 11:06 AM
  • 14 Jun 2024, 08:24 AM
  • 14 Jun 2024, 08:24 AM

Checklist

hide

Activity

Show:

Yury Barsukou July 10, 2024 at 11:05 AM
Edited

tested on 502 build, ok for, evidences added. No need in cases

Punnoose Kutty Jacob Pullolickal July 3, 2024 at 12:16 PM
Edited

In order to fix this bug, we need to add “multiply: true” configuration to all the subFocus edges of the Concept resources created out of MARC 600. See the image in https://folio-org.atlassian.net/browse/MODLD-209 to understand the graph structure.

Even though not mentioned in this ticket, the same issue exists for the subfocus edges created out of MARC tags 610, 651 and 655. I think it make sense to fix those aswell as part of this ticket.

Done

Details

Assignee

Reporter

Labels

Priority

Story Points

Sprint

Development Team

Citation

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created June 14, 2024 at 8:23 AM
Updated March 4, 2025 at 7:23 PM
Resolved July 22, 2024 at 2:00 PM
TestRail: Cases
TestRail: Runs

Flag notifications