Schema name should not be embedded in sql function body

Activity

Show:

Hongwei JiFebruary 22, 2024 at 11:25 PM

, I just checked the master branch of mod-inventory-storage and the code has not been fixed. You can compare it with the fixed code in mod-circulation-storage. See and https://github.com/folio-org/mod-circulation-storage/blob/master/src/main/resources/templates/db_scripts/createIsbnFunctions.sql

Pavlo SmahinFebruary 22, 2024 at 2:37 PM

, , there was no activity for some time. Is it still an issue that should be fixed in mod-inventory-storage?

Julian LadischNovember 18, 2022 at 11:19 AM

Please create a Jira issue in the FOLIO project that has a detailed description that explains the use cases for which the SQL change is needed. Please follow https://folio-org.atlassian.net/wiki/display/COMMUNITY/Standard+Bug+Write-Up+Format

In that FOLIO Jira link and .

The SQL change breaks unit tests therefore a verbose justification is needed.

Marc JohnsonNovember 17, 2022 at 8:37 PM

Yes, because the pull request posted above that has the requested SQL function change breaks two unit tests and therefore is a non-trivial change.

Ok, I think you asking for more justification to make this change because it is non-trivial. How wrong is that interpretation?

Given that you are asking it in the context of this work, I don't think there needs to be a separate issue raised. Why would we need multiple issues?

Julian LadischNovember 17, 2022 at 7:52 PM

Yes, because the pull request posted above that has the requested SQL function change breaks two unit tests and therefore is a non-trivial change.

Details

Assignee

Reporter

Priority

Development Team

Core: Platform

RCA Group

TBD

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created November 17, 2022 at 12:42 AM
Updated March 11, 2024 at 5:22 PM
TestRail: Cases
TestRail: Runs