Upgrading mod-inventory-storage to 19.3.0 results in error log output indicating update failed
Description
CSP Request Details
None
CSP Rejection Details
None
Potential Workaround
None
Attachments
1
- 29 Jul 2020, 06:58 PM
relates to
Checklist
hideTestRail: Results
Activity
Show:
Anastasiia Zakharova July 31, 2020 at 9:09 AM
The pull request successfully fixes the bug as per the comment here https://github.com/folio-org/mod-inventory-storage/pull/481#issuecomment-666313882
Sobha Duvvuri July 30, 2020 at 3:42 AMEdited
Here is another case where the upgrade successful message is highly misleading - tried upgrading from v19.1.2 - v19.2.4 and install endpoint returned successfully with the correct from and to versions. However, after building UI, we see several error messages. Then digging into logs, we actually see that the upgrade failed due to an error and that it was rolledback. Not providing complete logs here since the error is due to bad data -
For Example:
2020-07-29T23:43:24.556Z PL/pgSQL function inline_code_block line 4 at SQL statement
2020-07-29T23:43:24.556Z at org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2310) ~[ms.jar:?]
2020-07-29T23:43:24.556Z at org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:2023) ~[ms.jar:?]
2020-07-29T23:43:24.556Z at org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:217) ~[ms.jar:?]
2020-07-29T23:43:24.556Z at org.postgresql.jdbc.PgStatement.execute(PgStatement.java:421) ~[ms.jar:?]
2020-07-29T23:43:24.556Z at org.postgresql.jdbc.PgStatement.executeWithFlags(PgStatement.java:318) ~[ms.jar:?]
2020-07-29T23:43:24.556Z at org.postgresql.jdbc.PgStatement.executeUpdate(PgStatement.java:294) ~[ms.jar:?]
2020-07-29T23:43:24.556Z at org.folio.rest.persist.PostgresClient.lambda$84(PostgresClient.java:3585) ~[ms.jar:?]
2020-07-29T23:43:24.556Z at io.vertx.core.impl.ContextImpl.lambda$executeBlocking$2(ContextImpl.java:313) ~[ms.jar:?]
2020-07-29T23:43:24.556Z at io.vertx.core.impl.TaskQueue.run(TaskQueue.java:76) ~[ms.jar:?]
2020-07-29T23:43:24.556Z at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:1.8.0_242]
2020-07-29T23:43:24.556Z at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:1.8.0_242]
2020-07-29T23:43:24.556Z at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) [ms.jar:?]
2020-07-29T23:43:24.556Z at java.lang.Thread.run(Thread.java:748) [?:1.8.0_242]
2020-07-29T23:43:24.562Z 29 Jul 2020 23:43:24:557 ERROR PostgresClient [5230754eqId] Rollback for: -1463483318
2020-07-29T23:43:24.594Z 29 Jul 2020 23:43:24:594 INFO LogUtil [5230791eqId] org.folio.rest.RestVerticle start invoking postTenant
2020-07-29T23:43:24.595Z 29 Jul 2020 23:43:24:595 INFO LogUtil [5230792eqId] 127.0.0.1:55626 POST /_/tenant null HTTP_1_1 {color:red}201{color} 0 67019 tid=fs00000002 CreatedDone
Created July 29, 2020 at 6:50 PM
Updated August 6, 2020 at 12:57 PM
Resolved July 31, 2020 at 9:09 AM
TestRail: Cases
TestRail: Runs
upgrading from 19.2.4 to 19.3.0 causes the attached error in logs. Note that this install call succeeds when I think it should not. This may be a second issue:
2020-07-29 15:59:17.765,gmsd/mod-inventory-storage/dd083017-a44a-4acc-8b35-8311e09f79a0,29 Jul 2020 15:59:17:762 ERROR PostgresClient [] ERROR: cannot change return type of existing function 2020-07-29 15:59:17.766,gmsd/mod-inventory-storage/dd083017-a44a-4acc-8b35-8311e09f79a0,29 Jul 2020 15:59:17:766 ERROR PostgresClient [] Rollback for: -2055069992 2020-07-29 15:59:17.800,gmsd/mod-inventory-storage/dd083017-a44a-4acc-8b35-8311e09f79a0,29 Jul 2020 15:59:17:800 INFO LogUtil [reqId=492416/proxy 060809/tenant] org.folio.rest.RestVerticle start invoking postTenant 2020-07-29 15:59:17.802,gmsd/mod-inventory-storage/dd083017-a44a-4acc-8b35-8311e09f79a0,29 Jul 2020 15:59:17:801 INFO LogUtil [reqId=492416/proxy 060809/tenant] 127.0.0.1:33730 POST /_/tenant null HTTP_1_1 201 0 60126 tid=fs00001019 CreatedThis error has been observed on Bugfest as well as on a pre release version of MSU.