SourceId is allowed to be deleted for Holdings record

Description

Overview: Not all Holdings in the holdings_record table of Inventory have SourceId value, and in this case it is impossible to determine source of Holdings records to fetch them properly for data export purposes

Steps to reproduce:

  1. Go to “Inventory“ app

  2. Find any Holdings and copy its UUID

  3. Send GET {{url}}/holdings-storage/holdings/UUID request to get Holdings record

  4. Send PUT {{url}}/holdings-storage/holdings/UUID request with the body including Holdings record from Step 3 without SourceId (remove it)

  5. Check the response

Expected result: 422 Unprocessable Entity response is obtained. SorceId is not allowed to be deleted

Actual result: 204 No content response is obtained. SorceId is allowed to be deleted

Release notes will be updated in scope of this story.

Environment

Potential Workaround

None

Attachments

7

Checklist

hide

Activity

Show:

Ashkhen Gevorgyan June 24, 2024 at 3:06 PM

Hi
The bug was retested on the snapshot and works as expected:

Khalilah Gambrell June 24, 2024 at 11:56 AM

Closing as Done. - can you confirm that this issue has been resolved?

Valery_Pilko June 20, 2024 at 6:48 AM

Verified on Snapshot environment for Holdings with source FOLIO and MARC - “sourceId” cannot be deleted via PUT request.
See attached screenshots:

Hi . - please review the fix

Natalia Zaitseva May 24, 2024 at 11:35 AM

tickets created and a notification posted in #development Slack channel.

please note how the announcement was done

Pavlo Smahin May 23, 2024 at 5:44 PM

, please create tickets for dependent modules:

The responsible teams should update interface versions based on your change.

Done

Details

Assignee

Reporter

Priority

Story Points

Sprint

Development Team

Spitfire

Fix versions

Release

Ramsons (R2 2024)

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created February 13, 2024 at 11:39 AM
Updated October 29, 2024 at 11:51 AM
Resolved June 24, 2024 at 11:56 AM
TestRail: Cases
TestRail: Runs