Update Voucher and voucherLInes when exchange rate is edited

Description

Overview:

Balancing payment and credit amounts with real world transactions is virtually impossible when exchange rates are involved as the rate is constantly changing. As a result often the rate is not set in stone until the transaction is made by the accounting system.This means the exchange rate could be edited in the invoice until the invoice/voucher is marked as "Paid". The rate will need to be updated by a user or possibly an external system when awaiting payment, as part of paying the voucher/invoice.

API for getting ROE(Rate of exchange) is added in scope of MODFIN-111 - Exchange rate API(Closed)

Scope

If exchange rate is edited after invoice approval and there is enough money in fund than voucher and voucher lines totals need to be recalculated and updated.

Acceptance criteria:

  • logic updated

  • API test updated

  • Unit test updated

Environment

None

Potential Workaround

None

Attachments

3

Checklist

hide

TestRail: Results

Activity

Show:

Siarhei Hrabko September 7, 2020 at 3:24 PM


Verified on folio testing via API tests

Andrei Makaranka September 7, 2020 at 7:41 AM

Verified on folio-snapshot by running

Dennis Bridges August 17, 2020 at 4:22 PM

Thanks
— 1. Should we store in "SystemCurrency" currency from system configuration or from current fiscal year(as we do in transactions)?
I think it makes sense to store the currency from the Fiscal year instead of the "System".
— 2. Can invoice line has fund distributions from different fiscal years?
No, an invoice will be paid in one fiscal year. - Also note, if the invoice is approved in FY1 and then rollover happens and the current fiscal year changes to FY2. When the invoice is transitioned to "Paid" the payments should be made against FY1 - the year in which the invoice was approved.

Andrei Makaranka August 17, 2020 at 1:46 PM
Edited

Hi ,

A have several questions:
1. Currently we store two currencies in voucher :

  • InvoiceCurrency - currency from Invoice

  • SystemCurrency - currency from system configuration.
    And in voucher creation time we retrieve rate of exchange(ROE) between those currencies and store as voucher rate of exchange.

Should we store in "SystemCurrency" currency from system configuration or from current fiscal year(as we do in transactions)?
2. Can invoice line has fund distributions from different fiscal years?

Thank you in advance

Andrei Makaranka July 17, 2020 at 1:47 PM

Should be splitted on 2 stories as the estimation will be greater than 5SP.
Please take a look.

Done

Details

Assignee

Reporter

Tester Assignee

Priority

Story Points

Sprint

Development Team

Thunderjet

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created December 18, 2019 at 9:23 PM
Updated September 7, 2020 at 3:25 PM
Resolved September 7, 2020 at 3:25 PM
TestRail: Cases
TestRail: Runs

Flag notifications