Implement MARC import v1: Extend Instances to include MARC payload.

RCA Group

None

Description

None

Environment

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Niels Erik NielsenAugust 1, 2018 at 10:37 AM

Right , this is the complete list of API access declared in ui-inventory itself*:

path: 'circulation/loans?query=(itemId==!{itemId}) sortby loanDate/sort.descending&limit=1', path: 'circulation/requests?query=(itemId==:{itemid}) sortby requestDate desc', path: 'holdings-storage/holdings', path: 'holdings-storage/holdings', path: 'holdings-storage/holdings/:{holdingsrecordid}', path: 'holdings-storage/holdings?query=(instanceId==:{id})', path: 'instance-storage/instances', path: 'instance-storage/instances/:{id}', path: 'inventory/items', path: 'inventory/items', path: 'inventory/items/:{itemid}', path: 'inventory/items?query=(holdingsRecordId==!{holdingsRecord.id})', path: 'loan-types', path: 'locations/%{permanentLocationQuery.id}', path: 'locations/%{temporaryLocationQuery.id}', path: 'material-types', path: 'platforms', path: 'users?query=(id==%{borrowerId.query})',

In other words, ui-inventory currently use mod-inventory for the somewhat limited purposes of:

1) Mapping certain Item UUIDs to labels (loan type, location, material type) for the Item Detail View.
2) Resolving "effective location"

*: Not counting API access declared by components, but they would not add to the list I think.

Julian LadischJuly 27, 2018 at 7:43 AM

Closing this issue for now.
Please reopen if there is a requirement that mod-inventory should also provide some of the source record APIs (which?) that already exists in mod-inventory-storage.

Marc JohnsonJuly 26, 2018 at 10:42 AM

I concur, at this point there is limited value in replicating the source record endpoint in mod-inventory.

There might be value in the sourceRecordFormat being in the instance representation. However I think this is likely now sufficiently out of sync with the previous changes to storage, that the default UI does not use it.

Do you think there is value (at the moment) in that property being available in the business logic view of an instance (a quick look at UI inventory suggests that it uses instance-storage, and only items from the inventory interface)?

Julian LadischJuly 26, 2018 at 10:33 AM
Edited

We have a working /instance-storage/instances/{instanceId}/source-record/marc-json endpoint in mod-inventory-storage:
https://s3.amazonaws.com/foliodocs/api/mod-inventory-storage/2/instance-storage.html#instance-storage-instances-instanceid-source-record-marc-json
The instance at /instance-storage/instances/{instanceId} contains "sourceRecordFormat": "MARC-JSON" if the source record exists:
https://s3.amazonaws.com/foliodocs/api/mod-inventory-storage/2/instance-storage.html#PUT/instance-storage/instances/\{instanceId}
This has been covered by https://folio-org.atlassian.net/browse/MODINVSTOR-26#icft=MODINVSTOR-26.

I don't think we need to duplicate the source record MARC payload endpoint in mod-inventory. Can we close this issue?

Jakub SkoczenJune 4, 2018 at 1:14 PM

what is the status of this issue?

Won't Do

Details

Assignee

Reporter

Priority

Development Team

Other dev

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created January 18, 2018 at 11:31 AM
Updated November 3, 2023 at 2:56 PM
Resolved July 27, 2018 at 7:43 AM
TestRail: Cases
TestRail: Runs

Flag notifications