Looks good, karate tests passed, thanks for finding an approach on how to speedup overall acq performance with these indexes and simplify rollover script code.

I checked the performance impact of this change on fiscal year rollover.

The finance rollover (including the encumbrance script) is very fast, so I could not measure a difference for that.

The order rollover is still slow (despite and ), and it did make a difference because of all the requests to retrieve transactions based on the fiscal year id and po line ids (the PR improves the index for po line ids and it simplifies SQL expressions). Overall the rollover was about 30% faster (single measurement using 5000 order lines with encumbrances).

The transactionType is not used in the order rollover, but it is used in many other places, so this change will speed up other workflows.

is not fixed yet, but we have a workaround now: generally use ObjectMapperTool.getMapper().writeValueAsString(entity) instead of JsonObject.mapFrom(entity).encode(), and simply send entity instead of JsonObject.mapFrom(entity) when using pgClient.update().

I created about it.

When updating RMB from 35.2.0 to 35.3.0-SNAPSHOT to use your latest PR, I get a lot of errors like this:

date/time field value out of range: "1715011526007"

I imagine this is related to RMB 35.2.1 and 35.2.2, but I don’t see any upgrade documentation for these versions. Is there something I need to do in order to use the latest RMB in mod-finance-storage ?