Option to provide a summary id parameter in the transaction API

Description

Purpose/Overview:

To resolve MODFISTO-260, batch transactions cannot be linked with the order id / invoice id anymore. So we need to pass an additional parameter, the summary id, for POST/PUT transaction calls.

Also, since transaction summaries are not using order or invoice ids as the key anymore, they are unique and should not need to be modified, so we can deprecate PUT for transaction summaries (there might be a need for that for troubleshooting which we will have to check, but this can be done later).

Requirements/Scope:

  1. Add optional transactionSummaryId query parameter for the following:
    POST /finance-storage/transactions
    PUT /finance-storage/transactions/{id}

  2. The following should be deprecated:
    PUT /finance-storage/order-transaction-summaries/{id}
    PUT /finance-storage/invoice-transaction-summaries/{id}

Approach:

Update ramls/transaction.raml and ramls/transaction-summary.raml.

Use the new summary id instead of the order id or invoice id as the key for transaction summaries.

Acceptance criteria:

  • Match requirements

  • Update unit tests

Update:
I had to go beyond this scope in order to use the new summary id, and implemented most of the needed changes in MODFISTO for MODFISTO-260. Given the scope change I postponed the PUT summary deprecation.

Environment

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Damien May 30, 2023 at 3:03 PM

This is deprecated by .

Andrei Makaranka February 23, 2022 at 1:43 PM

,

Approach still not finalized and it will be done after collecting all possible use cases and POC.
Wiki : https://folio-org.atlassian.net/wiki/display/DD/Support+for+transaction+processing+by+two+or+more+users+in+parallel
Thanks

Sherzod Nurjonov February 23, 2022 at 7:56 AM
Edited

Hi , can we close this ticket? If yes, we would add this to the current release. Because I can see that some code merged to master in the scope of this ticket.

BR,
Sherzod

Andrei Makaranka October 18, 2021 at 9:29 AM

Approach implementation postponed. More time is needed for a more detailed study of the approach and elaboration all possible cases.

Won't Do

Details

Assignee

Reporter

Priority

Development Team

Thunderjet

Release

Poppy (R2 2023)

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created October 14, 2021 at 3:46 PM
Updated May 30, 2023 at 3:03 PM
Resolved May 30, 2023 at 3:03 PM
TestRail: Cases
TestRail: Runs