Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Remove usage of okapi-common lib, based on Vert.x classes, from Spring project

Description

mod-data-export-spring uses okapi-common library as a dependency. The dependency was introduced with PR: https://github.com/folio-org/mod-data-export-spring/pull/247

The problem with this library is it extensively utilizes Vert.x related classes that shouldn’t be included into the module bases on Spring/Spring Boot:

This in particular could lead to unwanted attempts of loading io.vertx.* classes and as a convenience to errors with class loading similar to the following:

In fact only 2 classes from the library are necessary:

  • org.folio.okapi.common.ModuleId

  • org.folio.okapi.common.SemVer

These classes have no dependencies to io.vertx.* classes. It’s safe to just copy them into module’s source code and remove the dependency to okapi-common lib at all.

Environment

None

Potential Workaround

None

Attachments

5

Checklist

hide

Activity

Show:

NinaChistova April 29, 2024 at 6:47 AM

Edifact export was tested on Q-bugfest

Works as expected

 

JenkinsNotifications April 26, 2024 at 7:49 AM

Deployed to the Quesnelia bf env. Moved status to In bugfix review from status Awaiting deployment. Please proceed with the verification.

Tatsiana Hryhoryeva April 25, 2024 at 7:01 AM

Hi ,

Verified on https://folio-snapshot.dev.folio.org/ environment, Edifact export works as expected

cc:

Natalia Zaitseva April 24, 2024 at 3:25 PM

could you please release the module?

Done

Details

Assignee

Reporter

Labels

Priority

Story Points

Sprint

Development Team

Firebird

Fix versions

Release

Quesnelia (R1 2024) Bug Fix

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created April 11, 2024 at 11:14 AM
Updated May 9, 2024 at 11:57 AM
Resolved April 25, 2024 at 7:55 AM
TestRail: Cases
TestRail: Runs