Issues related to display errors from DI on Confirmation screen of bulk edit MARC fields

Description

Overview:
When commit changes related to bulk edit of MARC fields the data import job is running. As the result of DI job the following could happen:

  • Instance is updated without error

  • Instance is updated with error

  • Instance is not updated

Based on the outcome of DI job the Preview of record changed and Errors should be populated on Confirmation screen in Bulk edit app

In current implementation regardless the outcome of DI job all Instances are included in the Preview of record changed. Also, in current implementation not all errors from DI are displayed in Errors on Confirmation screen. If error from DI is displayed, associated record identifier is not always displayed

Steps to Reproduce:

Instance is not updated by DI, e.g.

  1. Find or create MARC Instance with duplicated SRS, prepare file with that MARC Instance UUID

  2. Go to “Bulk edit“ app

  3. Select “Inventory - instances“ record type

  4. Select “Instance UUIDs“ record identifier

  5. Click “or choose file“ button => Upload prepared file with MARC Instance UUID

  6. Click “Actions“ > “Instances with source MARC (POC)“

  7. Select any options/actions to edit MARC fields of Instance records (e.g. add 500 field)

  8. Click “Confirm changes“

  9. Click “Commit changes“

Expected Results:

On Confirmation screen of Bulk edit app the record is not displayed in the Preview of record changed and is not included in .mrc file. Identifier of such record is displayed in “Errors“ with the reason for the error provided by DI

Actual Results:

  • On Confirmation screen of Bulk edit app the record is displayed as updated in the Preview of record changed

  • Record is not always displayed in “Errors“

  • If record is displayed in “Errors“, record identifier is not always displayed

2024-10-15_18h39_28.png

Additional scenarios in scope of this ticket:

If Instance is updated by DI with error this is expected on Confirmation screen of Bulk edit app the record is displayed in the Preview of record changed and is included in .mrc file. Identifier of such record is displayed in “Errors“ with the reason for the error provided by DI.

If Instance is updated by DI without error this is expected on Confirmation screen of Bulk edit app the record is displayed in the Preview of record changed and is included in .mrc file.

The issue described in https://folio-org.atlassian.net/browse/MODBULKOPS-375 is to be addressed in scope of current ticket:

  • when do bulk edit of MARC Instance with duplicated SRS, “Something went wrong” error appears on Confirmation screen, and link to download file is present in “Actions“ (however MARC Instance is not updates and Preview is empty as expected)

Acceptance criteria:

  • Logic with displaying DI errors is implemented

  • Logic to prevent downloading empty committed .mrc file is implemented

  • Karate test is created to cover path with failed records

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Attachments

35

Checklist

hide

Activity

Show:

Tatsiana Hryhoryeva December 11, 2024 at 11:25 AM

Verified on https://bugfest-ramsons.int.aws.folio.org/ environment, works as expected

Scenario 1 - Instances updated without errors from DI

2024-12-11_12h45_20.png

Scenario 2 - Instances updated with errors from DI (MARC Instance with duplicate SRS)

2024-12-11_12h55_12.png

Scenario 3 - Instances not updated by DI (MARC Instance set for deletion)

2024-12-11_13h00_43.png

Mikita Siadykh December 10, 2024 at 7:04 AM

Flag On Flag added

Bugfest verification is blocked by data import issues

Mikita Siadykh December 10, 2024 at 7:04 AM

I will move back to in bugfix review as it was closed and was counted in all metrics as completed (and now metrics go crazy) and add a flag that verification on bugfest is blocked by data import issues

Tatsiana Hryhoryeva December 5, 2024 at 4:54 AM

Also verification is blocked until https://folio-org.atlassian.net/browse/MODSOURMAN-1261 is resolved

Magda Zacharska November 29, 2024 at 3:11 AM

Flagged
Done

Details

Assignee

Reporter

Priority

Story Points

Sprint

Development Team

Fix versions

Release

RCA Group

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created October 16, 2024 at 12:46 PM
Updated December 11, 2024 at 11:30 AM
Resolved November 20, 2024 at 9:12 PM
TestRail: Cases
TestRail: Runs

Flag notifications