Dao tests ignore verifications

Description

Overview

Dao tests, taking PieceEventsDaoTestas an example have verifications in Future.onComplete handlers while there’s no mechanism to wait for completion so tests complete without any problems.

If Thread.sleep f.e. for 2 seconds is added to the end of a test method - you can see assertions fail because there’s no actual postgres container, but tests still pass

Suggested approach

  1. Use vertx for async assertions as in InstanceEventDaoTest

  2. Either

    1. rework tests to mock postgres calls as in InstanceEventDaoTest

    2. Add postgres setup

Environment

None

Potential Workaround

None

Attachments

2

Checklist

hide

Activity

Show:

Details

Assignee

Reporter

Priority

Development Team

Volaris

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created February 12, 2025 at 12:31 PM
Updated February 12, 2025 at 12:31 PM
TestRail: Cases
TestRail: Runs