Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Use filter type=request-log

Description

mod-audit currently uses a module descriptor with a routing entry of type=request-only. This prohibits large HTTP requests to Folio, such as uploads, becuase that filter passes the whole request to mod-audit and checks response before passing it into next module, such as a request-response handler.

With Okapi 2.23.0 you can use type=request-log which will pass request in parallel with handler and , thus, avoid saving it in memory.

Environment

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Hongwei Ji February 6, 2019 at 2:49 PM

As discussed in core-platform standup, I will make a new release (v0.0.5) for mod-audit-filter and close this ticket. The left work will happen in Okapi.

Hongwei Ji February 5, 2019 at 5:38 PM

Created OKAPI-699 and OKAPI-700

Hongwei Ji February 5, 2019 at 2:33 PM

, it is not a show stopper. It was just the first thing I noticed when trying the new request-log type. On top of that, the Okapi API testing have been failing in our env since v2.23.0, so I tried the same test on the latest folio-testing Vagrant box (Feb 4 with Okapi v2.24.0) and noticed some failures as well. One interesting/strange one is that Okapi seems returns incorrect response code from the handler, and there is no x-okapi-trace header the handler call itself. So overall I think there are something changed and need more time to looking into it. I can either leave this ticket open or create another one.

Adam Dickmeiss February 5, 2019 at 12:42 PM

And that's a show stopper? In that case, I'll make a solution for you.

Hongwei Ji February 4, 2019 at 4:29 PM

, it seems that with new request-log type, there will be no okapi trace header for response time tracking.

Done

Details

Assignee

Reporter

Labels

Priority

Story Points

Sprint

Development Team

Core: Platform

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created January 21, 2019 at 11:39 AM
Updated February 8, 2019 at 12:27 PM
Resolved February 6, 2019 at 2:49 PM
TestRail: Cases
TestRail: Runs