Block sending a requests with an empty barcode - KIWI
RCA Group
Description
Environment
Potential Workaround
defines
is cloned by
Confluence content
mentioned on
Checklist
hideTestRail: Results
Activity
Ann-Marie BreauxNovember 11, 2021 at 2:15 PM
Good to know, @Kateryna Senchenko. Thank you very much for the quick reply. I've added a note in the Slack #release-bug-triage channel. I'll also forward the CPT invite for Monday, in case the conversation gets too technical for me.
Kateryna SenchenkoNovember 11, 2021 at 2:05 PM
Hi @Ann-Marie Breaux, we discussed it again - and it appears that https://folio-org.atlassian.net/browse/MODINV-508#icft=MODINV-508 would be beneficial on it's own, since it prevents sending unnecessary calls to mod-inventory-storage, and it would be better to get it as a hot fix for Juniper. As for https://folio-org.atlassian.net/browse/MODINVSTOR-523#icft=MODINVSTOR-523 - all our tests with high data import load show that we do need the barcode unique index to be in place, otherwise data import is painfully slow. @Roman_Fedynyshyn please confirm - things got much better when the index was added on Juniper. I'm not sure whether adding of the index should necessarily be a hot fix, or it can be added manually for a particular library, but it is necessary for data import to perform adequately.
Ann-Marie BreauxNovember 11, 2021 at 1:49 PMEdited
Hi @Kateryna Senchenko and @Aliaksandr Fedasiuk I know we discussed this yesterday, but I forgot to add or update the above comment. I think we decided that this cannot be a Juniper HF unless https://folio-org.atlassian.net/browse/MODINVSTOR-523#icft=MODINVSTOR-523 is also released as a HF, and there was a definite decision to remove https://folio-org.atlassian.net/browse/MODINVSTOR-523#icft=MODINVSTOR-523 from Juniper (in https://folio-org.atlassian.net/browse/MODINVSTOR-782#icft=MODINVSTOR-782). If there's no https://folio-org.atlassian.net/browse/MODINVSTOR-523#icft=MODINVSTOR-523 in Juniper, then https://folio-org.atlassian.net/browse/MODINV-508#icft=MODINV-508 cannot be part of Juniper. Is that correct?
Ann-Marie BreauxNovember 10, 2021 at 2:24 PM
@Kateryna Senchenko and @Aliaksandr Fedasiuk Please review one more time in conjunction with https://folio-org.atlassian.net/browse/MODINVSTOR-792#icft=MODINVSTOR-792 and decide if this should be released as a Juniper HF. If so, I'll need to ask for permission from CPT first. (See also @Aliaksandr Fedasiuk's comments on MODSOURCE-397
Kateryna SenchenkoOctober 29, 2021 at 8:32 AM
@Ann-Marie Breaux, @Aliaksandr Fedasiuk, a small clarification - v18.0.0 is a Kiwi main release version, no additional releases needed, we're all set. Thank you
According information from https://folio-org.atlassian.net/browse/MODINVSTOR-792#icft=MODINVSTOR-792 sending requests with an empty barcode should be blocked.