Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

SPIKE: review the Java Apache Commons Validator implementation

Description

Apache Commons Validator project has ISBN validators, converters and check digit calculations implemented in Java:
https://commons.apache.org/proper/commons-validator/apidocs/org/apache/commons/validator/routines/ISBNValidator.html
https://commons.apache.org/proper/commons-validator/apidocs/org/apache/commons/validator/routines/checkdigit/ISBNCheckDigit.html
https://commons.apache.org/proper/commons-validator/apidocs/org/apache/commons/validator/routines/checkdigit/ISBN10CheckDigit.html
https://commons.apache.org/proper/commons-validator/apidocs/org/apache/commons/validator/routines/checkdigit/EAN13CheckDigit.html

Project website: https://commons.apache.org/proper/commons-validator/

Consider using that library.

Consider contributing back any additional code that the FOLIO project implements.

Acceptance criteria

  • PoC demonstrating how to use validator functions with real ISBN numbers. A set of tests could be created in the project created in the scope of https://folio-org.atlassian.net/browse/ISBNUTIL-1

  • Implement 3 cases verification. Description: ISBNUTIL-2

  • Check number format conversion.

Environment

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Kateryna SenchenkoJanuary 11, 2019 at 2:29 PM
Edited

PR on folio-isbn-util is now created. Thank you for your help and the example implementation (I used your version of convertToISBN10 method and mentioned you as the author). Please take a look at the PR, I added you as a reviewer.

Julian LadischJanuary 10, 2019 at 12:09 AM

This is an example how Apache Commons Validator may be used: https://github.com/julianladisch/folio-isbn-util/tree/ISBNUTIL-4-apache-commons-validator

Kateryna SenchenkoJanuary 9, 2019 at 12:52 PM

Thank you , we'll take a look.

Julian LadischJanuary 9, 2019 at 12:45 PM

Done

Details

Assignee

Reporter

Labels

Priority

Story Points

Sprint

Development Team

Folijet

Parent

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created December 20, 2018 at 5:47 PM
Updated March 20, 2019 at 9:02 AM
Resolved January 14, 2019 at 7:44 AM
TestRail: Cases
TestRail: Runs

Flag notifications