folio-testing.aws.indexdata.com does not use latest stripes-connect etc.

Description

As shown in the About page http://folio-testing.aws.indexdata.com/about this site is using:

  • stripes-core 1.14.1-SNAPSHOT.610

  • stripes-loader

  • stripes-connect 2.2.1

  • stripes-components 0.15.0

  • stripes-logger 0.0.2

(Ignore stripes-loader for the moment: it's a special case.)

As you can see, while we have a snapshot representing the latest stripes-core, we are using the most recent released versions of stripes-connect, stripes-components and stripes-logger.

This prevents some new facilities from working: for example, is unable to verify the fix for .

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

John Malconian June 26, 2017 at 4:18 PM

Closing issue. Opened related issue to investigate other solutions for CI package versioning.

Mike Taylor June 26, 2017 at 3:43 PM

John, why don't you close this one – since the actual bug is fixed – and add a new one for the nicer generated-package version numbers?

John Malconian June 23, 2017 at 2:22 PM

Super-high patchlevels is an interesting idea. I like it. Let me chew on that.

Mike Taylor June 23, 2017 at 1:16 PM

Thanks, John, got it. The key bit I was missing i that you are now overwriting your previous build/install of the package each time.

0.16.1-SNAPSHOT.23 > 0.15.0 is NOT true

That is so broken it hurts. Is it special to "SNAPSHOT"? Could we use some other term?

Or just use super-high patchlevels, like 0.16.10003

John Malconian June 23, 2017 at 1:12 PM

Every time there is a commit to master, a build is triggered in Jenkins which, for Stripes and UI modules, essentially does an 'npm install' and 'npm publish'. The 'publish' is performed to a CI NPM repository. The package versions that are published are the same versions specified in the package.json and the existing package in the CI NPM repository from the previous CI build is overwritten with the latest one. That is why the package version is the same as the 'released' version but the contents are HEAD of master.

This is less than ideal of course, because you'd like more accurate information about which version of an NPM package you are using which is the problem I attempted to solve in , however, because of the lame way NPM handles "prerelease" dependency resolution, the solution implemented in caused problems with some of the core stripes packages which is why I've had to reverse some of the changes I made to how those core stripes dependencies are packaged for snapshot testing.

Let me know if this still doesn't make sense. I'd like to solve this problem for all NPM snapshot packages but, at the same time, I don't want to break everything while trying to figure out a better solution.

Done

Details

Assignee

Reporter

Priority

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created June 22, 2017 at 2:31 PM
Updated November 12, 2018 at 2:23 PM
Resolved June 26, 2017 at 4:18 PM
TestRail: Cases
TestRail: Runs