Add edge-dematic module to testing env/testing and snapshot VMs
Description
Environment
Potential Workaround
Attachments
- 04 Mar 2021, 08:28 PM
blocks
is blocked by
relates to
Checklist
hideTestRail: Results
Activity
Wayne SchneiderMarch 10, 2021 at 2:54 PM
Based on comments in https://folio-org.atlassian.net/browse/EDGDEMATIC-9#icft=EDGDEMATIC-9, it seems like this is working well enough for UAT. Closing this issue.
Wayne SchneiderMarch 9, 2021 at 7:57 PM
Thanks, Slava. That does not work the same as the other edge modules, however (which accept the single dash -D
options as program arguments), so it still requires special configuration. But I've updated the build script to allow for more flexibility. In my testing on folio-snapshot-test, I get the following response to the request https://folio-snapshot-test.dev.folio.org:8000/asrService/asr/lookupNewAsrItems/12345?apikey=eyJzIjoidDJFZTU0a2s5bCIsInQiOiJkaWt1IiwidSI6ImRpa3UifQ==
:
<asrItems/>
So it seems like at least the module is responding as expected. The Docker container log shows that the institutional user is logged in and able to complete requests.
Just a note – you may want to tune down the default logging from DEBUG
to INFO
.
Putting this issue in review. After the overnight reference environment builds, the module should be available in folio-testing and folio-snapshot.
Viachaslau KhandramaiMarch 6, 2021 at 10:38 AM
Hi @Wayne Schneider,
now it works with VM options (before -jar):
-Dokapi_url=http://localhost:2222 -Dsecure_store_props=/Users/viachaslau_khandramai/Documents/test-ephemeral.properties
as well as with Program arguments (after -jar):
--Dokapi_url=http://localhost:2222 --Dsecure_store_props=/Users/viachaslau_khandramai/Documents/test-ephemeral.properties
or
--okapi_url=http://localhost:2222 --secure_store_props=/Users/viachaslau_khandramai/Documents/test-ephemeral.properties
The only one difference - two dashes in case of Program arguments.
Thanks,
Slava
Wayne SchneiderMarch 5, 2021 at 4:25 PM
In our testing, we found that edge-dematic requires the -D
options to be before the -jar
option, rather than processing them as command arguments after -jar
. But otherwise the new Dockerfile seems to work well.
We should be able to accommodate this by putting the -D
options in the JAVA_OPTIONS
environment variable. Once the PR is merged, we can build a test environment.
Wayne SchneiderMarch 5, 2021 at 2:21 PM
Hi, Slava. I believe with the changes to the Dockerfile, you should get the same command-line as above. I will test.
And, probably, you can provide useful remarks how to provide support of $JAVA_OPTIONS on our ens.
The base container image you are using should support the JAVA_OPTIONS
environment variable. Do you need options passed to the container? We can set environment variables if needed.
A new back-end edge module edge-dematic should be added to the folio-testing reference environment as well as for the Vagrant VM boxes for folio-testing and folio-snapshot for testing and demo purposes. This module depends on interfaces from mod-remote-storage.