Require UUIDs that are RFC 4122 compliant
Description
Checklist
hideTestRail: Results
Activity
Show:
Jag Goraya May 7, 2019 at 9:25 AM
can you raise a PR for the generator please and assign for Code Review. The tests will be dealt with separately.
Done
Details
Details
Components
Assignee
Unassigned
UnassignedReporter
Julian Ladisch
Julian LadischLabels
Priority
P3Story Points
1
Sprint
None
Development Team
Bienenvolk
TestRail: Cases
Open TestRail: Cases
TestRail: Runs
Open TestRail: Runs
Created March 12, 2019 at 12:11 PM
Updated May 20, 2019 at 2:55 PM
Resolved May 20, 2019 at 2:55 PM
TestRail: Cases
TestRail: Runs
Other FOLIO modules like mod-orders require RFC 4122 compliant UUIDs, for example when storing an agreement_id.
RFC 4122 compliant UUIDs have this form:
xxxxxxxx-xxxx-Mxxx-Nxxx-xxxxxxxxxxxx
where M is the UUID version (0-5)
and N is the UUID variant (encoded as 8, 9, a, or b).
mod-agreements and mod-licenses use UUIDs where N and M may be any other hex digit, and that have no minus/hyphen, for example ff808181695e6b4a01695e6d6fbf0ef3 (M=6, N=0).
Such an UUID
will be rejected if N or M is invalid: https://github.com/folio-org/acq-models/blob/25179760d1c7223c9d54c811bb460a1c3ed5a89c/mod-orders-storage/schemas/po_line.json#L22
requires conversion https://github.com/folio-org/ui-agreements/blob/f66471d399d40fc9cf888cf5c96796eba5218e69/src/util/hyphenateUuid.js
Consider changing mod-agreements and mod-licenses so that all UUIDs are RFC 4122 compliant for better inter-module compatibility.