Agreements: Agreement period date validation is broken

Description

Tested on https://zbw.folio.gbv.de (Poppy CSP#5), Bugfest Quesnelia, and Bugfest Ramsons.

Steps to recreate

  1. Open the Agreements app and create a new agreement.

  2. Add two agreement periods:

    • Period 1: Start = 01/01/2021, end = 12/31/2024

    • Period 2: Start = 01/01/2025, end = empty

  3. Save the agreement.

  4. Edit the agreement and remove period 2. Now try to save the agreement.

Expected behavior

  • The agreement is being saved.

  • The agreement only has one (current) period.

Actual behavior

  • The agreement can't be saved and an error message is displayed: The following periods have overlapping dates: 1 & 2

Supplementary information

  • Save without an end date in period 1 does not work as well.

  • Change the start date of period 1 to 01/01/2026. This is after the end date of period 2 and should trick the validation, but it does not work as well.

  • Set the end date of period 1 in the past (12/31/2023) is also not working.

  • There seem to be no workaround that involves the UI.

  • There doesn't seem to be a ticket yet.

Possible workaround:

Put a dummy period like 1/1/1000 and 2/2/1000 into the fields of the period to delete.

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Checklist

hide

Activity

Show:

Martina SchildtNovember 25, 2024 at 5:32 PM

Sorry for my belated response , it took me a while to recreate the issue. Reason: the initial test was done in Firefox, there is no issue when using Chrome as a browser. Please resolve or delete the issue. Sorry for causing extra work.

Owen StephensNovember 25, 2024 at 3:42 PM

Can this issue be recreated using Chrome is it just Firefox ?

Details

Assignee

Reporter

Labels

Priority

Development Team

Bienenvolk

RCA Group

TBD

Affected releases

Quesnelia (R1 2024)
Poppy (R2 2023)

Affected Institution

!!!ALL!!!

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created November 13, 2024 at 11:16 AM
Updated November 25, 2024 at 5:32 PM
TestRail: Cases
TestRail: Runs

Flag notifications