Identifiers in the ISSN namespace should be labelled just "ISSN" in the UI

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Peter Murray September 16, 2021 at 10:26 PM

I'm good...feel free to close.  Thanks!

Owen Stephens September 16, 2021 at 11:43 AM

Thanks  - as this update from Lokalise has resolved our immediate problem I'm going to close this issue unless you need it to remain open from your side?

Peter Murray September 14, 2021 at 2:57 PM

Sorry for the delay.  I've been working on this over two days, and when I went to restart the troubleshooting process this morning, I found that a Lokalise-to-GitHub batch process did indeed make the change to en_US.  It didn't do that yesterday, and—to be honest—I'm not sure what fixed the issue.  I'll keep an eye out for similar circumstances.

Owen Stephens September 10, 2021 at 8:57 AM

 it makes sense, but the change we made was to the en.json file - so we're still puzzled by the behaviour of Lokalise here. We did also update en_US.json in the same PR (https://github.com/folio-org/ui-agreements/pull/838/files) but we thought that this was accepted as common practice on the basis that Lokalise would pick up the change to en.json and bring everything back into sync anyway.

If you look at https://github.com/folio-org/ui-agreements/blob/207ebaca952b384dd1916d76d36311b79cbc6db1/translations/ui-agreements/en.json#L363 you can see that this reads:

 

But looking at the PR from Lokalise on the 4th August, this writes to the en_US.json file with

 

Could Lokalise have failed to pick up the change to en.json. Or is changing en_US.json at the same time as en.json in the same repo going to cause problems for Lokalise?

 

Peter Murray September 10, 2021 at 12:52 AM

Does the above comment make sense?  Okay to close this?

Done

Details

Assignee

Reporter

Priority

Sprint

Development Team

Bienenvolk

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created September 6, 2021 at 2:00 PM
Updated September 22, 2021 at 1:05 PM
Resolved September 17, 2021 at 7:30 AM
TestRail: Cases
TestRail: Runs