Use normalization for request.item.identifiers (for search requests by ISBN)
Description
Environment
Potential Workaround
has to be done after
is blocked by
relates to
Checklist
hideTestRail: Results
Activity
Brooks TravisApril 29, 2021 at 2:05 PM
Erroneously moved this to "Awaiting Release". It's done.
Brooks TravisApril 26, 2021 at 11:25 PM
Verified functionality in snapshot using Postman to query /request-storage/requests?query=(itemIsbn="978-0-26-201210-2")
Returns requests on Semantic Web Primer in snapshot: ISBN 9780262012102
Julian LadischApril 26, 2021 at 4:07 PM
https://folio-org.atlassian.net/browse/UIREQ-354#icft=UIREQ-354 requests this feature for the general search slot at the left top of the requests app because the second step in "Steps to reproduces" enters the search string into that general search slot.
Julian LadischApril 26, 2021 at 4:00 PM
item.identifiers = "foo bar" OR itemIsbn = "foo bar"
Why is the
item.identifierspart of this needed?
Because https://folio-org.atlassian.net/browse/UIREQ-354#icft=UIREQ-354 explicitly wants "to search for requests by instance ISBN (and other Identifiers)".
Marc JohnsonApril 26, 2021 at 11:35 AM
@Brooks Travis
I'm not sure if I can test this, or not. I'm able to retrieve a request from /circulation-storage/requests using the ISBN with no spaces or "-" characters, but if I try to use the EAN-13 formatted version of the same ISBN I get nothing. This is in snapshot. See ISBN: 9781000329483 (EAN-13: 978-1-00-032948-3).
What CQL query did you use for this testing? the index needed is itemIsbn e.g. `itemISBN=9781000329483` Apologies that this was not made clear in the issue.
Kyle Felker I'm not quite sure where I'm supposed to be trying this query out.
Snapshot is the correct environment for this testing
In scope of RMB-499 we're going to introduce normalization for ISBN-like identifiers. The scope of this story is:
Migrate to the latest RMB version where the feature is available;
Create/remove indexes for the identifiers array.
Note: CQL likely needs to be updated on UI as well:
item.identifiers = "foo bar" OR itemIsbn = "foo bar"Should itemIsbn also find in the invalid ISBN identifier field like the Inventory keyword (UIIN-998) and identifier (UIIN-999) search does?
Should mod-circulation-storage implement an itemIsxn index that combines ISBN, ISSN, invalid ISBN, invalid ISSN, linking ISSN (see MODINVSTOR-475 = UIIN-1243 how Inventory is going to use isxn), and drop the itemIsbn index?