Changes in an agreement does not seem to be saved when clicking Save
Description
CSP Request Details
CSP Rejection Details
Potential Workaround
Attachments
- 10 Jun 2020, 04:12 AM
- 08 Jun 2020, 09:07 AM
- 28 May 2020, 08:42 PM
- 28 May 2020, 08:41 PM
Checklist
hideTestRail: Results
Activity
Theodor Tolstoy (One-Group.se) September 24, 2020 at 5:51 PM
This seems to work as expected now, so closing this issue.
md331 June 10, 2020 at 1:01 PMEdited
Interesting, thanks for that Marie.
While we generally share the same UI components, most of the underlying logic tends to be different across modules developed by different teams like Orders and Agreements (or Licenses) are. However, two bits stand out to me from that log file anyway.
1. The errors of Submit validation failed
... at onSubmitFail
. Orders is using the redux-form library to manage its forms and it appears like the validation rules for the order form are being run and the values you entered are being called invalid here|https://github.com/folio-org/stripes-form/blob/9fbb59292abf471e9bf2b15e2109960fe9b9dbed/lib/stripesForm.js#L52]. However, I guess it's not actually showing you what the errors are. This is something that should be taken up with the team working on Orders. I don't pretend to know exactly how their code works, but I've had similar issues when errors aren't being shown because the field with an error isn't marked as dirty
. I'm not sure, just throwing out some ideas in case it helps them.
2. The errors of TypeError: Cannot read property 'sendCallout' of null
. We saw an issue like this in Stripes and went down a big rabbit hole trying to figure it out. In fact...as I went digging through old Slack conversations...it appears as though the source of that was https://folio-org.atlassian.net/browse/CHAL-300#icft=CHAL-300.
https://folio-org.atlassian.net/browse/CHAL-300#icft=CHAL-300 actually captures both of the issues in the Orders log you sent. I know they've done some heavy refactoring since Fameflower and issued a hotfix release as well, so if the hotfix is installed on your machine and you're still getting this issue, and continue to get in the forthcoming Goldenrod Bugfest environment, https://folio-org.atlassian.net/browse/CHAL-300#icft=CHAL-300 should be looked into again.
–
Alas, while I've typed a bunch there, I haven't gotten any clarity on the issue you're seeing in Agreements... But hopefully a log file from that will be helpful.
Marie Widigson June 10, 2020 at 4:20 AM
Thank you for the log-file help, @md331. Due to the intermittent character of this bug, I've not been able to reproduce it today or yesterday.
However, yesterday I reported a similar issue with Save & close in the order app (so far it has not made it to Jira, still in EBSCO Connect only, case #4243304).
It's intermittent there as well.
Here is what (sometimes) happens in Orders.
1. Create new one-time order using a template.
2. Save & Close “blinks” when clicked on, but stays blue. Window stays open.
3. Clicking the upper left x returns the Close without saving/Keep editing-dialog.
4. Choosing Close without saving closes the window and the changes are in fact saved.
5. I can now add a POL.
In some cases clicking the Save & Open-button at POL, it “blinks” but stays blue and the window stays open. Have to use the upper left x again.
In other cases (such as in the case with the files attached) the POL saves and order opens as expected.
I saved bot HAR and Console files (thanks again!) for this issue. Attaching the Console log here if they could help trouble shooting?
The HAR-file could be found at https://chalmersuniversity.box.com/s/gjahhjukzr6kznc3n65vt0plof0adsmq
Hope this helps.
/Marie
md331 June 8, 2020 at 4:30 PM
So in the screenshots, you're in the Network
tab. Switch over to the Console
tab, right-click and hit Save as..
and it'll create a .log
file for you to download. Save it and attach that file.
Marie Widigson June 8, 2020 at 3:58 PM
Please let me know exactly what you need and I will try to provide it. @md331
All the best
Marie
Overview:
Intermittent bug. After having made a change in an agreement and saving, the changes does not seem to be saved. But when clicking the x they are.
Steps to reproduce:
1. Login to Chalmers' FOLIO Fameflower
2. Go to an Agreement (This test agreement may be used 488dea06-688d-43b9-abb8-6565c7795229 )
3. Make a change in for example Name field
4. Click Save & Close
Expected Result:
That the page is closed and changes are saved.
Actual Result:
The full pane is still open.
Changes does not seem to be saved.
Save & close-button is grey.
When clicking the x in the upper left corner, the page closes and the changes are in fact saved.
This is happening intermittently, both to me and to my colleagues.
(I've got a HAR-file saved if you would like to see it, but I'm not sure how to clean it from the token.)