2025-04-28 Meeting notes

2025-04-28 Meeting notes

Date

 

Attendees 

TimeItemWhoNotes
1 minScribeAll
Florian Gleixner is next, followed by Marc Johnson, then Ingolf Kuss

Reminder:  Please copy/paste the Zoom chat into the notes.  If you miss it, this is saved along with the meeting recording, but having it here has benefits.

5-15 minLiaison Updates
  • CC:  Maccabee Levine
    • Vision statement vote postponed until consideration of various other documents/proposals being drafted by subgroups that involve contribution network, membership, resourcing
    • Subgroup: "Cultivating an active healthy software development contribution network"
      • Mike will polish and share the in a today, discussion at next CC meeting. GDoc comments welcome. Draft by @Mike Gorrell (lead), @Boaz Nadav Manes @spampell @Christopher Spalding, @Kirstin Kemner-Heek
      • Create some development streams for folio organizations.
      • Bulletin board of needs, roster of development orgs capable of doing development. Wiki so light, self-policing.
      • Maintenance of certain modules may be sponsored for period of time. Or, general support pool from community membrsr dues. Points system of module weight, to allocate support need.
      • Second tier support pool. Organization that has specific expertise, not day-to-day maintenance but things they are expert on.
  • PC: Jenn Colt for Tod OlsonMarc Johnson:
    • Good feedback from Eureka early adopters
    • Wolfcon Topics
    • Priority list - try to organize work
  • RMS Group: Jakub Skoczen: no updates.
  • Security Team: Craig McNally:
    • The Security Team would like the TC to chime in on an adjustment to the sonarcloud rules...  See below.
  • Eureka Early Adopters:  Craig McNally:
    • GBV has a working platform complete on Eureka running, now working on formalizing things
    • Texas A&M is getting close too.
    • Latest status updates can be found here , spreadsheet there is up-to-date
5-10 minUpcoming MeetingsAll
  • - Dedicated Discussion - Officially supported technologies - Trillium
  • - Regular TC meeting
  • - Dedicated Discussion - TBD
  • - Regular TC meeting
  • - Dedicated Discussion - TBD
  • Dedicated Discussion Topics:
    • Developer Advocate
    • Evaluating existing modules
    • Communication plan to promote updates to OST pages
      • Need to update OST pages with communication plan changes
      • Need a retro on changes to OST(?)
    • TC Roles and Responsibilities
    • FQM RFC
    • WOLFcon Planning
    • OST discussion around the Grails 7 and Java 17 issues; get to talk to the stakeholders
10 minTCR Board ReviewAll

Previous:


Today:

0 min

Technical Council Sub-Groups Updates

All

Nothing to discuss today

5 min

GitHub RFCs

Wiki RFCs

All

  • Craig McNally asked for volunteers to help update the RFC process documentation and update the existing RFCs to include stub entries. None were forthcoming
    • Still need to do this
  • Craig McNally will reach out to RFC proposer to create stub wiki pages that refer to the github RFCs
    • Still need to do this
  •  

    Today: Joshua Greben volunteers

5 minDecision LogAll
  • Need to log FQM decision, record can get made by Vince/Matt or TC any time
  • Vince has updated the document, Matt has a little more to add

Craig McNally will ask Vince/Matt

1 min

Officially Supported Technologies (OST)

All

Craig McNally asked about whether we could update the calendar page. Marc Johnson advised that we are waiting for a Trillium timeline. Craig McNally will follow up with Oleksii Petrenko about when the schedule might be published

Draft Trillium timeline is available:  https://folio-org.atlassian.net/wiki/x/BIAqNg

To Do:

  • Updated Recurring Calendar page dates and document statuses
5 minWOLFcon `25AllDeadline for submissions has been extended to  
5-10 minSonar Rule Adjustment

Craig McNally

Julian Ladisch

Kevin Day

  • The Security Team would like to add a new rule which emits a warning when //NOSONAR is used. 
  • This is a mechanism which can be used to instruct sonar to ignore specific lines of code. 
  • There are alternative (better) ways to do this which only tell sonar to ignore certain rules for specific lines/blocks of code, e.g. @SuppressWarnings("java:S4790")
  • This is already documented on the dev site:  https://dev.folio.org/guides/code-analysis/#rule-customization
  • We'd like to introduce this warning to discourage the use of //NOSONAR
  • Maccabee Levine: Does this work for other languages like Go?
  • Julian Ladisch: The rule will only be added for Java
  • Marc Johnson: Sonar has very limited support for Go
  • Acceped by lazy consensus
?Environment variable naming Kevin Day

From slack:

I've been looking at the inconsistencies in the environment variable naming in Eureka, specifically with KeyCloak, and so I created a Story KEYCLOAK-53.

This had me thinking and wondering if we as the Tech Council may want to discuss naming practices regarding core functionality to make environment variables across multiple and within modules more consistent.

Has there ever been any discussion on environment variable practices and naming consistencies?

I'm thinking that this might be worth discussing.
I can see this being relevant for special modules like Kong, KeyCloak, FQM, etc...


Notes:

  • There have definitely been conversations about this in the past.  Matt Weaver points out that one such conversation wrt ports happened recently.  See https://open-libr-foundation.slack.com/archives/C210RP0T1/p1741100367668439
  • For KEYCLOAK-53, the Eureka team has adopted the "KC_*" prefix for environment variables which pertain to Keycloak (KC over KEYCLOAK for brevity).  Similarly, KAFKA_*, and KONG_*, etc.
    • However, for folio-keycloak, some environment variables are used by the keycloak container.  These expect the "KEYCLOAK_*" prefix.   
    • As Julian Ladisch points out in the issue comments, KEYCLOAK_ADMIN and KEYCLOAK_ADMIN_PASSWORD have been deprecated, and should be replaced with KC_BOOTSTRAP_ADMIN_USERNAME and KC_BOOTSTRAP_ADMIN_PASSWORD instead.  We will probably just use KEYCLOAK-53 to track this work.
    • Julian Ladisch already has PRs created.  Thank you Julian Ladisch!
    • Tod Olson should be also a topic for sysops.
    • Marc Johnson different languages have different rules for environment variables, for example using underscores.
    • Craig McNally at least at framework level, variables should be consistent
    • Florian Gleixner Environment variables shlould look the same during deployment. For example a container entrypoint can translate.
    • This should be discussed by the sysops SIG and then be discussed in a Wednesday meeting.
NAZoom Chat


17:10:25 From Jakub To Everyone:
       No updates regarding the RMS from me

17:19:17 From Maccabee Levine To Everyone:
       We could also start to round-robin this kind of thing in the same way we do notes, and TCRs.  But thanks Josh!

Topic Backlog

Decision Log ReviewAll

Review decisions that are in progress.  Can any of them be accepted?  rejected?

Translation SubgroupAllSince we're having trouble finding volunteers for a subgroup, maybe we can make progress during a dedicated discussion session?
Communicating Breaking ChangesAll

Currently there is a PoC, developed by Maccabee Levine, of a utility to catalog Github PRs that have been labeled with the "breaking change" label. We would like to get developer feedback on the feasibility of this label being used more often, and the usefulness of this utility. 

Officially Supported Technologies - UpkeepAll

Previous Notes:

  • A workflow for these pages. When do they transition from one state to another. Do we even need statuses at all ?

Stripes architecture group has some questions about the Poppy release.

Zak: A handshake between developers, dev ops and the TC. Who makes that decision and how do we pass along that knowledge ? E.g. changes in Nodes and in the UI boxes. How to communicate this ? We have a large number of teams, all have to be aware of it.  TC should be alerted that changes are happening. We have a couple of dedicated channels for that. Most dev ops have subscribed to these channels. How can dev ops folk raise issues to the next level of community awareness ? There hasn't been a specific piece of TC to move that along.

Craig: There is a fourth group, "Capacity Planning" or "Release Planning". Slack is the de facto communication channel.  There are no objections to using Slack. An example is the Java 17 RFC. 

Craig: The TC gets it on the agenda and we will discuss it. The TC gets the final say.

Marc Johnson: We shouldn’t use the DevOps Channel. The dev ops folks have made it clear that it should only be used for support requests made to them.

Jakub: Our responsibility is to avoid piling up technical debt.

Marc: Some set of people have to actually make the call. Who lowers the chequered flag ?

Craig: It needs to ultimately come to the TC at least for awareness. There is a missing piece. Capacity Planning needs to provide input here. 

Marc: Stakeholders / Capacity Planning could make that decision. Who makes the decision ? Is it the government or is it some parts of the body ?

Marc: the developers community, the dev ops community and sys ops are involved. For example the Spring Framework discussion or the Java 17 discussion. But it was completely separate to the TC decision. It is a coordination and communication effort.

Marc: Maybe the TC needs to let go that they are the decision makers so that they be a moderating group.

Jakub: I agree with Marc. But we are not a system operating group. Dependency management should be in the responsibility of Release management. There are structures in the project for that.

Jason Root: I agree with Jakub and with Marc also. Policies should drive operational/release/support aspects of Folio.

Jason Root: If the idea of “support” is that frameworks are supported, then of course the project should meet that.

Marc Johnson
Some group needs to inform OleksAii when a relevant policy event occurs.
These documents effectively ARE the manifestation of the policy.

Craig: This is a topic for the next Monday session.

Craig to see if Oleksii Petrenko could join us to discuss the process for updating the officially supported technologies lists.


Dev Documentation VisibilityAll

Possible topic/activity for a Wednesday session:

Discuss/brainstorm:

  • Ideas for the type of developer-facing documentation we think would be most helpful for new developers
  • How we might bring existing documentation up to date and ensure it's consistent 
  • etc.
API linting within our backend modulesAll

https://folio-project.slack.com/archives/CAQ7L02PP/p1713343461518409


Hello team, I would like to discuss API linting within our backend modules. Some time ago, we transitioned our linting process from Jenkins to GitHub Actions as outlined in https://folio-org.atlassian.net/browse/FOLIO-3678. I am assuming that this move was done via some technical council decision. Please correct me if I'm wrong.
In my observations, I've found two problems:
  1. Schema linting does not occur if the schemas are in YAML format.
  2. There are issues with resolving some deeper references during API linting.
Although I'm unsure about how to improve the existing linting implementations within Folio, I propose to consider an open-source solution that handles OpenAPI linting effectively and allows us to define custom rules. For your reference: https://stoplight.io/open-source/spectral A test of this solution can be found in this PR: https://github.com/folio-org/mod-search/pull/567. The same PR also provides an example of custom rule definition: https://github.com/folio-org/mod-search/pull/567/files#diff-d5da7cb43c444434994b76f3b04aa6e702c09e938de09dbc09d72569d611d9ab.Also, by employing 'Spectral', I discovered AsyncAPI (https://www.asyncapi.com/en), an API design tool similar to OpenAPI but for asynchronous interactions. I suggest that we consider using AsyncAPI in FOLIO to generate documentation for Kafka interactions.


PR TemplatesAll

https://folio-project.slack.com/archives/CAQ7L02PP/p1713445649504769

Hello team, Small request to consider.
Regarding pr templates.
  1. From my perspective, pr template is not good idea. Even the biggest open source projects that are contributed by many people don't have any pr template. Currently what we have for acq modules https://github.com/folio-org/mod-orders-storage/blob/master/PULL_REQUEST_TEMPLATE.md
  2. These pr template is inconsistent in different teams.
What I suggest is that, pr template shouldn't be any instructions, because most developer who are creating pr have already understand the rules. If we put just two section into template, it will encourage developers to write more about their work and that lead to knowledge  sharing among developers.
Proposed Mod KafkaAll

https://folio-project.slack.com/archives/CAQ7L02PP/p1714471592534689

Mike Taylor

Proposal. If and only if a FOLIO instance is running Kafka, it should insert and enable a module called mod-kafka, which consists entirely of a module descriptor that says it provides the interface kafka. The purpose is so that other modules can use the standard <IfInterface> and similar tools to determine whether they should attempt Kafka operations. Rationale: the FOLIO ILS depends absolutely on Kafka, but other uses of the platform will not. One such example: a dev platform that includes only mod-users, used as a source of change events for Metadb.

Related content