https://folio-org.atlassian.net/browse/ERM-2201

@Ethan Freestone 

Code for multi-value property has broken single-value properties. 

• Approach

  • Add debug into binding to isolate issue

  • Check each web binding for single and multi-value individually

  • Domain class is exposed by library, so not easy to test in web-toolkit

• Components and Changes

  • Frontend: NA

  • Backend: web-toolkit, dependency bump for mod-licenses, mod-agreements

• Tests / Data: NA

• Dependencies / Known Unknowns: NA

• QA: snapshot 

• Development Estimate: ??

https://folio-org.atlassian.net/browse/ERM-2203

@Monireh Rasouli 

• Approach

  • only GET if there is 

  • hook: useCustomProperties

  • pass enabledProp query parameter to only fire if >1 license

• Components and Changes

  • Frontend: ui-agreements/agreement.js

  • Backend: NA

• Tests / Data: NA

• Dependencies / Known Unknowns: 

• QA: snapshot 

• Development Estimate: 1d

https://folio-org.atlassian.net/browse/ERM-2204

@Monireh Rasouli 

• Approach

  • add callout from stripes-kint-components

  • add default message

  • allow message to be overwritten

  • implement override function to agreements & licenses

• Components and Changes

  • Frontend: stripes-kint-components, ui-agreements, ui-licenses

  • Backend: none

• Tests / Data: no

• Dependencies: required for stripes-kint-components 2.6.0

• Known Unknowns

• QA: snapshot 

• Development Estimate: 1d

https://folio-org.atlassian.net/browse/ERM-2205

• Approach

  • Check refdata is being passed 

  • Check that the issue is happening in other places that refdata is being used (CONFIRMED in licenses)

  • Check that new things are fetched (invalidation is working correctly)

  • Check we're not memo-ising the filter state (such as caching)

  • if we're not caching, where is the update happening (eg, in stripes) > then coordinate to force / trigger a refresh 

• Components and Changes

  • Frontend: agreementFilters

  • Backend: none

• Tests / Data: ?

• Dependencies: ?

• Known Unknowns: may be Stripes / SaS / StripesConnect related

• QA: snapshot

• Development Estimate: ? 

https://folio-org.atlassian.net/browse/ERM-2206

• Approach

  • unlikely to be react, and sure we don't make second fetch for ISSN

  • find the component that is supposed to be rendering

  • if data is there, check shape path

  • if data not there and not in network, check view file on backend

• Components and Changes

  • Frontend: ui-agreements

  • Backend: ? 

• Tests / Data: test the shape still works

• Dependencies / Known Unknowns: 

  • identifier property added at package and title level: shouldn't be an issue as we should not be filtering object by key

• QA: snapshot

• Development Estimate: 0.5d (path) 1d (view) 

https://folio-org.atlassian.net/browse/ERM-2207

@Monireh Rasouli 

• Approach

  • configuration.item.entries.post needed where configuration.item.entries.put is granted 

  • add entry to package.json 

• Components and Changes

  • Frontend: all front-end modules apart from plugins and stripes-*-components

  • Backend: NA

• Tests / Data: NA

• Dependencies / Known Unknowns: NA

• QA: snapshot

• Development Estimate: 1d

https://folio-org.atlassian.net/browse/ERM-2208

@Monireh Rasouli 

• Approach

  • if paging works in places other than agreementLines, then key may be incorrect

  • fetch to mod-config may be using wrong lookup key or parsing out wrong key

  • works for agreements, not resources

    • function may be assuming default location 

    • useAgreementSettings hook

  • use debug to check returned output form lookup

  • use debug to check we are looking in the right place

• Components and Changes

  • Frontend: ui-agreements

  • Backend: NA

• Tests / Data / Dependencies / Known Unknowns: none

• QA: snapshot

• Development Estimate: 1d

https://folio-org.atlassian.net/browse/ERM-2209

@Peter Böhm 

• Approach

  • add nullable true constraint to fields in schema

  • (should already be nullable on domain classes)

• Components and Changes

  • Frontend: NA

  • Backend: ermPackageImpl

• Tests / Data: NA

• Dependencies: / Known Unknowns: NA

• QA: snapshot

• Development Estimate: 0.5d

https://folio-org.atlassian.net/browse/ERM-2157

https://folio-org.atlassian.net/browse/ERM-2155

@Ethan Freestone 

For https://folio-org.atlassian.net/browse/ERM-2157

https://folio-org.atlassian.net/browse/ERM-2157

https://folio-org.atlassian.net/browse/ERM-2182

@Ethan Freestone 

For https://folio-org.atlassian.net/browse/ERM-2157

https://folio-org.atlassian.net/browse/ERM-2157

https://folio-org.atlassian.net/browse/ERM-2158

@Ethan Freestone 

For https://folio-org.atlassian.net/browse/ERM-2157

https://folio-org.atlassian.net/browse/UXPROD-3591

https://folio-org.atlassian.net/browse/ERM-2094

https://folio-org.atlassian.net/browse/ERM-2134

https://folio-org.atlassian.net/browse/STRIPES-675

https://folio-org.atlassian.net/browse/ERM-2153

@Ethan Freestone 

See what can be done for 2.6.0 release

https://folio-org.atlassian.net/browse/ERM-2174

@Ethan Freestone 

• Approach

  • need to check GSON files

• Components and Changes

  • Frontend

  • Backend

• Tests / Data

• Dependencies

• Known Unknowns

• QA: local | testing | snapshot | other

• Development Estimate

https://folio-org.atlassian.net/browse/ERM-2184

https://folio-org.atlassian.net/browse/STRIPES-675

https://folio-org.atlassian.net/browse/ERM-2148

@Claudia Malzer 

https://folio-org.atlassian.net/browse/STRIPES-675

https://folio-org.atlassian.net/browse/ERM-2151

@Claudia Malzer 

https://folio-org.atlassian.net/browse/UXPROD-3591

https://folio-org.atlassian.net/browse/ERM-2172

@Peter Böhm 

• Current State: 

  • Outstanding problems: https://folio-org.atlassian.net/browse/ERM-2172

    • lookUporCreateContentType

      • has to be invoked as a static refdata method

    • alternate resource name

      • line 148 should be in line 145

      • collection needs to be added one by one, and then merged together at the end

    • null-proof empty lists

      • should be resolved by switching up for alt resource name (remove lines 149-150)

      • no need to assign an array, but put it directly into the pkg

      • may need to def it for grails

• TODO: 

  • check whether collection is nullable by default

• Development Estimate: Wed 1 Jun / Mon 16 May EOD / Mon 9 May / Thu 5 May / Wed 13 Apr

https://folio-org.atlassian.net/browse/UXPROD-3406

https://folio-org.atlassian.net/browse/ERM-2157

@Monireh Rasouli 

• Current State

  • All developed and tests written. 

• ISSUES

  • TO FIX. Three components failing (custom properties settings, views)

• TODO

  • TO FIX. Custom Properties Settings and View tests

• Development Estimate: 1 Jun (with tests, assuming permissions issues resolved)

https://folio-org.atlassian.net/browse/ERM-2202

@Ethan Freestone 

In Code Review. Waiting for stripes-kint-components release.