ERM Sprint 129

ERM Sprint 129

Sprint Goal / Focus

  • Remote KB Harvest Sync (Settings)

Sprint Schedule

  • Sprint: 129

    • Start Mon 6 Dec

    • Finish Fri 17 Dec

    • Sprint Board

    • Jira Sprint: 1114

  • Release: 2022.1 Lotus  

    • Sprint 133: Module Release Deadline

      • Backend 16 Feb 2022

      • Frontend 18 Feb 2022

    • Sprint 136: Bugfix Deadline (25 March 2022)

Sprint Capacity

Team AvailabilitySchedule | Calendar

Notes / Exceptions:

  • None

Lead Roles:

  • Front End Code Review: @Ethan Freestone

  • Back End Code Review:  @Ethan Freestone

  • QA: @Owen Stephens 

QA Environment: folio-snapshot

Planning Questions

  • Does the issue meet the criteria for Definition of Ready?

  • What front and back end components are affected?

  • What changes need to be made? (additions, removals or modifications)

  • What development tests need to be written?  

  • What data does the developer need to verify their work?

  • What are the known unknowns? 

  • What is needed to QA? (environment, data, scripts)

Navigation

  1. Sprint Goal / Focus

  2. Sprint Capacity

  3. Review sprint candidates 

  4. Agree technical approach / define key implementation tasks

  5. Finalise estimates / costings

  6. Confirm sprint scope

  7. Confirm first actions

 

 

 


Sprint Planning  

 - not in sprint

 or @ - in sprint 

 

Planning Notes Template

  • Approach

  • Components and Changes

    • Frontend

    • Backend

  • Tests / Data

  • Dependencies

  • Known Unknowns

  • QA: local | testing | snapshot | other

  • Development Estimate

Sprint Focus

Feature ID

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

Feature ID

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

https://folio-org.atlassian.net/browse/UXPROD-3337

https://folio-org.atlassian.net/browse/UXPROD-3338

https://folio-org.atlassian.net/browse/ERM-1906

https://folio-org.atlassian.net/browse/ERM-1907

https://folio-org.atlassian.net/browse/ERM-1908

https://folio-org.atlassian.net/browse/ERM-1909

https://folio-org.atlassian.net/browse/ERM-1910

https://folio-org.atlassian.net/browse/ERM-1911

Needs conversation between Owen and Gill. 

Will push back to new year, which may force a quick fix. 

https://folio-org.atlassian.net/browse/UXPROD-3339

https://folio-org.atlassian.net/browse/ERM-1799

@Peter Böhm 

/ @Ethan Freestone 

  • Approach

    • most identifiers are stored on TI, not PCI or PTI

      • this change duplicates it in multiple places

    • add new class (collection of matchkey information) to ermResource abstract class

    • tweak ingest to assign class to PCI and PTI

    • enact this where the entry points converge

      • creation of TIs happens in TitleInstanceResolver -

      • PCI and PTIs are created in a shared process during the ingest

    • store as domain class (matchkey/value string pair) rather than json

  • Components and Changes

    • Frontend: none

    • Backend: mod-agreements

  • Tests / Data

    • won't need to expose through api

    • locally verify with SQL queries to ensure appear in 

  • Dependencies: none

  • Known Unknowns: not yet

  • QA: local vagrant

  • Development Estimate: 

 

https://folio-org.atlassian.net/browse/ERM-1923

https://folio-org.atlassian.net/browse/ERM-1920

  • Ethan to refer to Steve

 

https://folio-org.atlassian.net/browse/ERM-1948

@Owen Stephens 

In QA

https://folio-org.atlassian.net/browse/UXPROD-3338

https://folio-org.atlassian.net/browse/ERM-1949 

https://folio-org.atlassian.net/browse/ERM-1950

@Claudia Malzer 

  • 1949: cursor

    • cursor is the change point for differential updates

    • collapse existing buttons to incorporate 

    • reset to null (rather than with value)

  • 1950: syncStatus

    • issue

      • syncStatus has two states (idle or in-process)

      • can sometimes stick at in-process

    • add option to conditionally confirm sync reset for jobs updated over 24 hours earlier

      • date checking within 24 hours: convert difference from milliseconds

    • user needs Settings privileges

  • Components and Changes

    • Frontend:

      • ui-local-kb-admin

    • Backend: none

  • Tests / Data

    • no RTL/JEST or integration tests to be added

    • test locally with, eg, 5 minutes rather than 24 hours

    • use postman to update time via API

  • Dependencies / Known Unknowns : none

  • QA: snapshot 

  • Development Estimate: code review for Wed

https://folio-org.atlassian.net/browse/FAT-81

https://folio-org.atlassian.net/browse/ERM-1484

https://folio-org.atlassian.net/browse/ERM-1485

https://folio-org.atlassian.net/browse/ERM-1486

@Monireh Rasouli 

 

https://folio-org.atlassian.net/browse/UXPROD-3338

 

https://folio-org.atlassian.net/browse/ERM-1922

@Claudia Malzer 

Pending UX input




 

 

 

 

 

Rolled Over From Previous Sprint

For Development

 

Feature ID

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

Feature ID

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

https://folio-org.atlassian.net/browse/FAT-81

https://folio-org.atlassian.net/browse/ERM-1483

@Monireh Rasouli 

In Progress

TODO: not seeing the data

https://folio-org.atlassian.net/browse/FAT-81

https://folio-org.atlassian.net/browse/ERM-1480

@Ethan Freestone 

For Code Review

https://folio-org.atlassian.net/browse/FAT-81

https://folio-org.atlassian.net/browse/ERM-1482

@Ethan Freestone 

For Code Review

 

https://folio-org.atlassian.net/browse/ERM-1937

@Owen Stephens 

Changed are as expected.

Transferred to QA

 

https://folio-org.atlassian.net/browse/ERM-1938

@Owen Stephens 

https://folio-org.atlassian.net/browse/ERM-1939

  • Owen to review

https://folio-org.atlassian.net/browse/ERM-1940

  • Ethan to progress

  • Approach

    • add controller

    • check regression / translations

  • Components and Changes

    • Frontend: ui-agreements

      • settings index

      • translations

    • Backend: mod-agreements

      • expose Controller 

  • Tests / Data

    • stripes-kint-component

  • Dependencies: none

  • Known Unknowns: 

    • not been unit/integration tested before, so current is unknown

  • QA: snapshot 

  • Development Estimate: Thu or Mon 

 

https://folio-org.atlassian.net/browse/ERM-1850

@Peter Böhm 

Reviewed example with Ethan

Vagrant issues

Making progress on subquery

Expected for code review end of Wednesday

No dependencies

 

 

 

https://folio-org.atlassian.net/browse/ERM-1912

@Peter Böhm 

Test Approach: 

  • Source data has been fixed, so testing without faking the data is going to be problematic (faking or proxying)

  • Set internal value to empty

  • TODO: run integration tests

  • QA: regression test 

 

https://folio-org.atlassian.net/browse/ERM-1921

@Claudia Malzer 

Complete, but not raised as done as part of 1922

Will separate into new branch for code review today.

 

https://folio-org.atlassian.net/browse/ERM-1904

Pending input from Ian

 

https://folio-org.atlassian.net/browse/ERM-1922

Pending input from Gill

 

https://folio-org.atlassian.net/browse/ERM-1929

Pending input from Gill

For QA

Feature ID

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

Feature ID

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

 

https://folio-org.atlassian.net/browse/ERM-1927

@Owen Stephens 

Seems unreliable on radio button selection. This is a stripes level issue. 1927 to return to QA. 

TODO: Owen to raise a stripes issue. 

 

https://folio-org.atlassian.net/browse/ERM-1926

@Owen Stephens 

 

 

https://folio-org.atlassian.net/browse/ERM-1931

@Owen Stephens 

 

 

https://folio-org.atlassian.net/browse/ERM-1932

@Owen Stephens 

 

 

https://folio-org.atlassian.net/browse/ERM-1900

@Owen Stephens 

 

 

https://folio-org.atlassian.net/browse/ERM-1882

@Owen Stephens 

 

 

https://folio-org.atlassian.net/browse/ERM-1883

@Owen Stephens 

 

 

https://folio-org.atlassian.net/browse/ERM-1884

@Owen Stephens 

 

 

https://folio-org.atlassian.net/browse/ERM-1912

@Owen Stephens 

 

For Release Prep

Feature ID

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

Feature ID

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

 

 

 

 

 

Bugfix Cycle

Feature ID

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

Feature ID

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

 

 

 

 

Brought In

Feature ID

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

Feature ID

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

 

https://folio-org.atlassian.net/browse/ERM-1953

@Monireh Rasouli 

Remedial work for https://folio-org.atlassian.net/browse/ERM-1937

  • Approach

    • add new fetch 

    • filter new fetch based on id

    • provision fallback (show UUID) in case of fetch fail

  • Components and Changes

    • Frontend: ui-agreements

    • Backend

  • Tests / Data

    • tweak test for filters

    • test for fallback

  • Dependencies / Known Unknowns: none

  • QA: snapshot 

  • Development Estimate: code review by Friday

https://folio-org.atlassian.net/browse/UXPROD-3140

https://folio-org.atlassian.net/browse/ERM-1744

https://folio-org.atlassian.net/browse/ERM-1745

@Monireh Rasouli