Needs conversation between Owen and Gill. 

Will push back to new year, which may force a quick fix. 

• Approach
  • most identifiers are stored on TI, not PCI or PTI
    • this change duplicates it in multiple places
  • add new class (collection of matchkey information) to ermResource abstract class
  • tweak ingest to assign class to PCI and PTI
  • enact this where the entry points converge
    • creation of TIs happens in TitleInstanceResolver -
    • PCI and PTIs are created in a shared process during the ingest
  • store as domain class (matchkey/value string pair) rather than json
• Components and Changes
  • Frontend: none
  • Backend: mod-agreements
• Tests / Data
  • won't need to expose through api
  • locally verify with SQL queries to ensure appear in 
• Dependencies: none
• Known Unknowns: not yet
• QA: local vagrant
• Development Estimate: 

• Ethan to refer to Steve

• 1949: cursor
  • cursor is the change point for differential updates
  • collapse existing buttons to incorporate 
  • reset to null (rather than with value)
• 1950: syncStatus
  • issue
    • syncStatus has two states (idle or in-process)
    • can sometimes stick at in-process
  • add option to conditionally confirm sync reset for jobs updated over 24 hours earlier
    • date checking within 24 hours: convert difference from milliseconds
  • user needs Settings privileges
• Components and Changes
  • Frontend:
    • ui-local-kb-admin
  • Backend: none
• Tests / Data
  • no RTL/JEST or integration tests to be added
  • test locally with, eg, 5 minutes rather than 24 hours
  • use postman to update time via API
• Dependencies / Known Unknowns : none
• QA: snapshot 
• Development Estimate: code review for Wed

In Progress

TODO: not seeing the data

For Code Review

Changed are as expected.

Transferred to QA

• Ethan to progress
• Approach
  • add controller
  • check regression / translations
• Components and Changes
  • Frontend: ui-agreements
    • settings index
    • translations
  • Backend: mod-agreements
    • expose Controller 
• Tests / Data
  • stripes-kint-component
• Dependencies: none
• Known Unknowns: 
  • not been unit/integration tested before, so current is unknown
• QA: snapshot 
• Development Estimate: Thu or Mon 

Reviewed example with Ethan

Vagrant issues

Making progress on subquery

Expected for code review end of Wednesday

No dependencies

Test Approach: 

• Source data has been fixed, so testing without faking the data is going to be problematic (faking or proxying)
• Set internal value to empty
• TODO: run integration tests
• QA: regression test 

Complete, but not raised as done as part of 1922

Will separate into new branch for code review today.

Seems unreliable on radio button selection. This is a stripes level issue. 1927 to return to QA. 

TODO: Owen to raise a stripes issue. 

• Approach
  • Check if eUsage plugin is present
    • pluggable component returns a data key, rather than module-name
    • so, if pluggable render returns null ... 
  • If not, do not show Usage data accordian
  • Add new Agreement Display setting using mod-config
  • Set default as false (no change to existing behaviour)
  • Applies to Edit screen only
• Components and Changes
  • Frontend: ui-agreements
  • Backend: none
• Tests / Data
  • extend settings page tests
  • extend agreement edit page tests
• Dependencies: none
• Known Unknowns
  • eusage not working for dev 
• QA: snapshot 
• Development Estimate: Wed for code review

Pending UX input