Versions Compared

Version Old Version 2 New Version Current
Changes made by

Jag Goraya

Jag Goraya

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Date

    

Time

10:30am ET, 3:30pm UK, 4:30pm Germany

Location

Video Call in

Previously2021-01-27 ERM Weekly Delivery Update
ReferencesJIRA Issue Board

Goals

Participants

Apologies

Discussion items

Time

Item

Notes

Action Items

<5 minsIntroductions



Previous Actions

Consistent Dev Environment

Aditya matukumalli to add workspace setup guide to ensure consistency in local test & development environments



WIP Update 

Release Candidates

Code Review: 

QA / UAT 

  • Jira Legacy
    serverSystem JiraJIRA
    serverId01505d01-b853-3c2e-90f1-ee9b165564fc
    keyERM-1239
    /
    Jira Legacy
    serverSystem JiraJIRA
    serverId01505d01-b853-3c2e-90f1-ee9b165564fc
    keyERM-1240
     
    • Jsut passed
    • Ready for QA pending testing refresh 

For Release

  • NA

Items at Risk / Spillover

In Progress

  • Jira Legacy
    serverSystem JiraJIRA
    serverId01505d01-b853-3c2e-90f1-ee9b165564fc
    keyERM-1241
    • Some cleanup work done in shared component
    • Almost complete 
    • Re-running local tests and then ready for code review
    • Some EOL discrepancies resulting in apparently empty diffs when converting between EOL types
  • Jira Legacy
    serverSystem JiraJIRA
    serverId01505d01-b853-3c2e-90f1-ee9b165564fc
    keyERM-1527
    • Changes requested from code review
    • Now getting Jenkins errors
      • Seem unrelated to submitted code
      • appears that Jenkins is overloaded
    • PR expected this morningShould be able to re-run via PR fail message > details link
      • will take to Jenkins login 
      • from which to trigger refresh
    • Adi to reach out to John Malconian to get Jenkins access for ERM repositories for Peter 
    • In the meantime, refresh has allowed this to get pushed through to Code Review
  • RTL Test Conversion:
      • Jira Legacy
        serverSystem JiraJIRA
        serverId01505d01-b853-3c2e-90f1-ee9b165564fc
        keyERM-1473
  • Jira Legacy
    serverSystem JiraJIRA
    serverId01505d01-b853-3c2e-90f1-ee9b165564fc
    keyERM-15311534
    /
    Jira Legacy
    serverSystem JiraJIRA
    serverId01505d01-b853-3c2e-90f1-ee9b165564fc
    keyERM-15321531
     
    • need to be merged together
    • some back and forth to get this done in functional logic
    • hooks not working nicely with old REACT methods
    • the changes so far are good enough
    • Adi to set up refactor holding issue in Jira to hook functional logic related techdebt issues
      • labels: erm, techdebt, functional-logic
      • Jira Legacy
        serverSystem JIRA
        serverId01505d01-b853-3c2e-90f1-ee9b165564fc
        keyERM-1548
  • Jira Legacy
    serverSystem JiraJIRA
    serverId01505d01-b853-3c2e-90f1-ee9b165564fc
    keyERM-1534
     
    1532
    • cannot be merged yet because tests are failing locally
  • Jira Legacy
    serverSystem JiraJIRA
    serverId01505d01-b853-3c2e-90f1-ee9b165564fc
    keyERM-1539
    • started to look at this
    • code located and looks straightforward
    • expect to complete Thursday

Sprint Backlog

  • Jira Legacy
    serverSystem JiraJIRA
    serverId01505d01-b853-3c2e-90f1-ee9b165564fc
    keyERM-1546
    • part the one
      • endpoint set up for myDashboards
      • checks okapi patron login to resolve or create a proxy user 
      • from there can access dashboard objects
    • part the two:
      • widgetType domain class, generic widgetDefinition,  simple widget classes written
    • process for adding in the future 
      • validate imported definition json against standard widget definition
      • then validates definition within json 
    • next: hook widget instance and wire the two parts together
  • Jira Legacy
    serverSystem JiraJIRA
    serverId01505d01-b853-3c2e-90f1-ee9b165564fc
    keyERM-1538
  • Jira Legacy
    serverSystem JiraJIRA
    serverId01505d01-b853-3c2e-90f1-ee9b165564fc
    keyERM-1544

Needs Elaboration

Closed

  • NA


<10 minsAOB

New Issues

Added to sprint

  • Upgrade to Stripes CLI v2
    • urgent upgrade required to address circular dependency issue
    • expected to land by Friday
    • To be handled by Adi
    • Action required by other developers: 
  • Jira Legacy
    serverSystem JIRA
    serverId01505d01-b853-3c2e-90f1-ee9b165564fc
    keyERM-1537
    • to follow keyboard shortcuts
    • could check accordion children to determine whether to display
      • Ethan to add comment with link
    • Not clear whether there is a precedent for this in FOLIO
      • solution should be reviewed for efficiency 
      • 'hide' approach is local to agreements

Not added to sprint

  • Jira Legacy
    serverSystem JiraJIRA
    serverId01505d01-b853-3c2e-90f1-ee9b165564fc
    keyUIU-1915
    / 
    Jira Legacy
    serverSystem JiraJIRA
    serverId01505d01-b853-3c2e-90f1-ee9b165564fc
    keySTCOM-793
    / 
    Jira Legacy
    serverSystem JiraJIRA
    serverId01505d01-b853-3c2e-90f1-ee9b165564fc
    keyUIU-1916
    • Reviewed by Adi. 
    • Estimate: 1 sprint to complete
    • No capacity to action within ERM at this timeGill to provide feedback to KG

End of Line Standard