<!-- 
RSS generated by JIRA (1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d) at Thu Feb 08 23:05:56 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary add field=key&field=summary to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>FOLIO Jira</title>
    <link>https://folio-org.atlassian.net</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>1001.0.0-SNAPSHOT</version>
        <build-number>100246</build-number>
        <build-date>07-02-2024</build-date>
    </build-info>

<item>
            <title>[OKAPI-248] Can&apos;t enable non-okapi deployed modules in OKAPI cluster mode</title>
                <link>https://folio-org.atlassian.net/browse/OKAPI-248</link>
                <project id="10137" key="OKAPI">Okapi</project>
                    <description>&lt;p&gt;To reproduce, first register some running module (for example users-module) to OKAPI discovery endpoint using &lt;/p&gt;
{&quot;srvcId&quot;:&quot;users-module&quot;, &quot;instId&quot;:&quot;users-module&quot;, &quot;url&quot;:&quot;http://non-okapi-host:port&quot;}
&lt;p&gt;, and then try to enalbe the module for some existing tenant. Got error &quot;No running instances for module users-module. Can not invoke tenant init&quot;. The problem seems to be in DiscoveryManager.java. Comment out following check &quot;if (!clusterManager.getNodes().contains(md.getNodeId()))&quot; can avoid the error.&lt;/p&gt;</description>
                <environment></environment>
        <key id="53251">OKAPI-248</key>
            <summary>Can&apos;t enable non-okapi deployed modules in OKAPI cluster mode</summary>
                <type id="10001" iconUrl="https://folio-org.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10303?size=medium">Bug</type>
                                            <priority id="10001" iconUrl="https://dev.folio.org/assets/jira-priority/jira-p2.svg">P2</priority>
                        <status id="6" iconUrl="https://folio-org.atlassian.net/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10003">Done</resolution>
                                                        <assignee accountid="712020:38d1a08f-86a8-4df2-9191-239b16b0a81a">Heikki Levanto</assignee>
                                                                <reporter accountid="557058:4f6bed01-40a6-48d5-8471-7ef21f5ea97c">Hongwei Ji</reporter>
                                    <labels>
                            <label>back-end</label>
                            <label>sprint8</label>
                    </labels>
                <created>Mon, 6 Feb 2017 18:07:38 +0000</created>
                <updated>Fri, 3 Jan 2020 14:25:29 +0000</updated>
                            <resolved>Wed, 8 Feb 2017 10:05:44 +0000</resolved>
                                                                        <due></due>
                            <votes>0</votes>
                                    <watches>3</watches>
                                                    <timespent seconds="12600">3 hours, 30 minutes</timespent>
                                <comments>
                                                            <comment id="125415" author="712020:38d1a08f-86a8-4df2-9191-239b16b0a81a" created="Tue, 7 Feb 2017 09:52:45 +0000"  >&lt;p&gt;I see the problem.&lt;br/&gt;
It happens in the case when we have a module with an external URL, and when the module supports the &lt;tt&gt;/_/tenant&lt;/tt&gt; interface, the logic to find a running instance to make the POST request ot the tenant interface gets confused. &lt;/p&gt;

&lt;p&gt;I am on it, hope to fix it today.&lt;/p&gt;</comment>
                                                            <comment id="125416" author="712020:38d1a08f-86a8-4df2-9191-239b16b0a81a" created="Tue, 7 Feb 2017 10:11:58 +0000"  >&lt;p&gt;Hmm, as far as I can see, out ModuleTest does the same kind of thing with sample-module3, around line 815-876.  I will try to reproduce this manually.&lt;/p&gt;</comment>
                                                            <comment id="125417" author="712020:38d1a08f-86a8-4df2-9191-239b16b0a81a" created="Tue, 7 Feb 2017 11:04:47 +0000"  >&lt;p&gt;I could not reproduce this manually. See the attached 248.sh script for the steps I took. Can you see how this differs from the way you are doing things?&lt;/p&gt;</comment>
                                                            <comment id="125418" author="712020:38d1a08f-86a8-4df2-9191-239b16b0a81a" created="Tue, 7 Feb 2017 12:28:16 +0000"  >&lt;p&gt;Aha, running it in clustering mode rperoduced the problem.&lt;/p&gt;

&lt;p&gt;Changed the end of the Okapi invocation to `cluster -cluster-host 127.0.0.1`. Also had to increase the sleep to 5 seconds, so the cluster has time to get going.&lt;/p&gt;

&lt;p&gt; Now I have something to hunt!&lt;/p&gt;</comment>
                                                            <comment id="125419" author="712020:38d1a08f-86a8-4df2-9191-239b16b0a81a" created="Tue, 7 Feb 2017 12:52:56 +0000"  >&lt;p&gt;The error happens already when POSTing to discovery, listing the &lt;tt&gt;/_/discovery/modules&lt;/tt&gt; retrurns an empty list in clustering mode. Digging deeper.&lt;/p&gt;</comment>
                                                            <comment id="125420" author="712020:38d1a08f-86a8-4df2-9191-239b16b0a81a" created="Wed, 8 Feb 2017 10:05:44 +0000"  >&lt;p&gt;It was a simple logic error in the code that excluded module instances on nodes that are no longer running, just as Hongwei Ji reported. Now omitting the check for module instances that have an explicit URL.&lt;/p&gt;

&lt;p&gt;Committed and merged in master&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10003">
                    <name>Relates</name>
                                                                <inwardlinks description="relates to">
                                        <issuelink>
            <issuekey id="54115">OKAPI-719</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                            <attachment id="42031" name="248.sh" size="3130" author="712020:38d1a08f-86a8-4df2-9191-239b16b0a81a" created="Tue, 7 Feb 2017 11:03:50 +0000"/>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10000" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummarycf">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10019" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|hzxjxz:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10020" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10024" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>[CHART] Date of First Response</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Tue, 7 Feb 2017 09:52:45 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10025" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>[CHART] Time in Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>