<!-- 
RSS generated by JIRA (1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d) at Thu Feb 08 23:08:45 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary add field=key&field=summary to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>FOLIO Jira</title>
    <link>https://folio-org.atlassian.net</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>1001.0.0-SNAPSHOT</version>
        <build-number>100246</build-number>
        <build-date>07-02-2024</build-date>
    </build-info>

<item>
            <title>[FOLIO-845] enforce code style during build and PR</title>
                <link>https://folio-org.atlassian.net/browse/FOLIO-845</link>
                <project id="10290" key="FOLIO">FOLIO</project>
                    <description>&lt;p&gt;For JS the code style will be checked by importing new project: stripes-eslint that will include the code style. For Java we want to rely on the code style enforced by SQ (we need to verify if it&apos;s aligned with our style).&lt;/p&gt;</description>
                <environment></environment>
        <key id="80348">FOLIO-845</key>
            <summary>enforce code style during build and PR</summary>
                <type id="10001" iconUrl="https://folio-org.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10303?size=medium">Bug</type>
                                            <priority id="10001" iconUrl="https://dev.folio.org/assets/jira-priority/jira-p2.svg">P2</priority>
                        <status id="6" iconUrl="https://folio-org.atlassian.net/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10003">Done</resolution>
                                                        <assignee accountid="5f9abc1eb45b2e007453f423">John Malconian</assignee>
                                                                <reporter accountid="557058:b8e64633-1f7c-402d-9caf-9959a5ba5d0d">Jakub Skoczen</reporter>
                                    <labels>
                            <label>ci</label>
                            <label>montreal</label>
                            <label>sprint23</label>
                    </labels>
                <created>Tue, 19 Sep 2017 22:01:20 +0000</created>
                <updated>Mon, 12 Nov 2018 14:23:45 +0000</updated>
                            <resolved>Wed, 8 Nov 2017 22:02:56 +0000</resolved>
                                                                        <due></due>
                            <votes>0</votes>
                                    <watches>12</watches>
                                                    <timespent seconds="19800">5 hours, 30 minutes</timespent>
                                <comments>
                                                            <comment id="190288" author="5f9abc1eb45b2e007453f423" created="Thu, 28 Sep 2017 18:44:45 +0000"  >&lt;p&gt;Couple of comments about this.  &lt;/p&gt;

&lt;p&gt;1.   So Sonarqube does a few things that eslint does not (AFAIK).    Unit test code coverage is a big one as well as pretty dashboard that can be easily referred to.    There probably is a lot of redundancy in using both,  but I&apos;m not sure.   I&apos;m wondering if we should run both, at least for a while, and see where we net out. &lt;/p&gt;

&lt;p&gt;2.  I think all of the UI projects that have a npm lint script defined have something like &apos;eslint || true&apos;.   This will always return a &apos;0&apos; exit status.  So running &apos;npm run lint&apos; will make it  difficult for CI to catch failures.   I can always just run &apos;eslint&apos; directly, but then there is ambiguity about what files and directories should be checked. &lt;/p&gt;</comment>
                                                            <comment id="190291" author="5bffed52a1b46046f530c8f7" created="Thu, 28 Sep 2017 20:40:07 +0000"  >&lt;p&gt;1. Please, no more arbitrary barriers. By all means use Sonaqube on server-side stuff if you want. We already have code-quality tools &lt;em&gt;that we chose&lt;/em&gt; on the client side.&lt;/p&gt;

&lt;p&gt;2. The &lt;tt&gt;|| true&lt;/tt&gt; is cosmetic, to avoid having ESLint spill its guts whenever there&apos;s a non-clean lint. We can lose it without too much pain.&lt;/p&gt;</comment>
                                                            <comment id="190292" author="5f9abc1eb45b2e007453f423" created="Thu, 28 Sep 2017 20:43:55 +0000"  >&lt;p&gt;&lt;a href=&quot;https://folio-org.atlassian.net/secure/ViewProfile.jspa?accountId=5bffed52a1b46046f530c8f7&quot; class=&quot;user-hover&quot; rel=&quot;5bffed52a1b46046f530c8f7&quot; data-account-id=&quot;5bffed52a1b46046f530c8f7&quot; accountid=&quot;5bffed52a1b46046f530c8f7&quot; rel=&quot;noreferrer&quot;&gt;Mike Taylor&lt;/a&gt; I can go with that.   I only request that we lose &apos;|| true&apos; and I will be good to go!&lt;/p&gt;</comment>
                                                            <comment id="190294" author="5bffed52a1b46046f530c8f7" created="Thu, 28 Sep 2017 20:49:07 +0000"  >&lt;p&gt;By all means &amp;#8211; feel free to rip out the &lt;tt&gt;|| true&lt;/tt&gt; wherever you see it.&lt;/p&gt;</comment>
                                                            <comment id="190295" author="5f9abc1eb45b2e007453f423" created="Wed, 4 Oct 2017 20:01:56 +0000"  >&lt;p&gt;ui-requests, ui-organization, ui-users, and stripes-core report lint errors.   stripes-react-hotkeys has no linting set up.   All other relevant client-side modules are now &quot;lint-enabled&quot; in the CI.  Will create separate jira issues for outstanding client-side repos. &lt;/p&gt;</comment>
                                                            <comment id="190298" author="5bffed52a1b46046f530c8f7" created="Wed, 4 Oct 2017 21:19:19 +0000"  >&lt;p&gt;&lt;tt&gt;stripes-react-hotkeys&lt;/tt&gt; is a special case, and we should make no changes to it. It&apos;s a fork of the regular &lt;tt&gt;react-hotkeys&lt;/tt&gt; which we had to make because its maintainer ignores PRs. We made only the changes we absolutely needed, and otherwise want to keep it as close to the original as possible.&lt;/p&gt;</comment>
                                                            <comment id="190299" author="5f9abc1eb45b2e007453f423" created="Wed, 8 Nov 2017 22:02:56 +0000"  >&lt;p&gt;Linting via ESLint is enabled across all relevant front-end projects. &lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10000">
                    <name>Blocks</name>
                                                                <inwardlinks description="is blocked by">
                                        <issuelink>
            <issuekey id="61698">STCOR-87</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="36349">UIORG-34</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="25617">UIREQ-19</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="44515">UIU-249</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10000" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummarycf">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10019" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|hzxzpj:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10020" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10024" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>[CHART] Date of First Response</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Thu, 28 Sep 2017 18:44:45 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10025" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>[CHART] Time in Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>