<!-- 
RSS generated by JIRA (1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d) at Thu Feb 08 23:08:43 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary add field=key&field=summary to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>FOLIO Jira</title>
    <link>https://folio-org.atlassian.net</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>1001.0.0-SNAPSHOT</version>
        <build-number>100246</build-number>
        <build-date>07-02-2024</build-date>
    </build-info>

<item>
            <title>[FOLIO-842] Block direct commits to master branch/Require Reviewers for PRs</title>
                <link>https://folio-org.atlassian.net/browse/FOLIO-842</link>
                <project id="10290" key="FOLIO">FOLIO</project>
                    <description>&lt;p&gt;As decided during the plenary session we will want to use PRs for all activity on the master branches. This will allow us to run the build, tests and perform code review (where applicable) before the code ends up on the master branch and breaks dependent projects, CI jobs or deployments (e.g demo).&lt;/p&gt;</description>
                <environment></environment>
        <key id="80342">FOLIO-842</key>
            <summary>Block direct commits to master branch/Require Reviewers for PRs</summary>
                <type id="10003" iconUrl="https://folio-org.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10318?size=medium">Task</type>
                                            <priority id="10001" iconUrl="https://dev.folio.org/assets/jira-priority/jira-p2.svg">P2</priority>
                        <status id="6" iconUrl="https://folio-org.atlassian.net/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10003">Done</resolution>
                                                        <assignee accountid="5f9abc1eb45b2e007453f423">John Malconian</assignee>
                                                                <reporter accountid="557058:b8e64633-1f7c-402d-9caf-9959a5ba5d0d">Jakub Skoczen</reporter>
                                    <labels>
                            <label>ci</label>
                            <label>montreal</label>
                            <label>sprint23</label>
                    </labels>
                <created>Tue, 19 Sep 2017 21:49:18 +0000</created>
                <updated>Mon, 12 Nov 2018 14:23:45 +0000</updated>
                            <resolved>Fri, 6 Oct 2017 14:12:11 +0000</resolved>
                                                                        <due></due>
                            <votes>0</votes>
                                    <watches>11</watches>
                                                    <timespent seconds="9000">2 hours, 30 minutes</timespent>
                                <comments>
                                                            <comment id="190260" author="5f9abc1eb45b2e007453f423" created="Thu, 21 Sep 2017 18:33:04 +0000"  >&lt;p&gt;I&apos;ve enabled this on folio-org/okapi.    See attached screenshot for configuration.  I&apos;ve also enabled required PR reviews.  Jenkins tests must also pass in PR before merge.    Let&apos;s see how this works out.&lt;/p&gt;

&lt;p&gt;&lt;a href=&quot;https://folio-org.atlassian.net/secure/ViewProfile.jspa?accountId=5f8314dfbdef80006f6f572d&quot; class=&quot;user-hover&quot; rel=&quot;5f8314dfbdef80006f6f572d&quot; data-account-id=&quot;5f8314dfbdef80006f6f572d&quot; accountid=&quot;5f8314dfbdef80006f6f572d&quot; rel=&quot;noreferrer&quot;&gt;Adam Dickmeiss&lt;/a&gt; You have Github admin privs in case you need to revert changes. &lt;/p&gt;</comment>
                                                            <comment id="190262" author="5f8314dfbdef80006f6f572d" created="Thu, 21 Sep 2017 18:39:11 +0000"  >&lt;p&gt;Great. I checked if I could push straight to master and that failed as it should.&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
adam@fry:~/folio/okapi$ git push
X11 forwarding request failed on channel 0
Counting objects: 3, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 303 bytes | 0 bytes/s, done.
Total 3 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2), completed with 2 local objects.
remote: error: GH006: Protected branch update failed &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; refs/heads/master.
remote: error: At least one approved review is required by reviewers with write access.
To git@github.com:folio-org/okapi.git
 ! [remote rejected] master -&amp;gt; master (&lt;span class=&quot;code-keyword&quot;&gt;protected&lt;/span&gt; branch hook declined)
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;</comment>
                                                            <comment id="190265" author="5f9abc1eb45b2e007453f423" created="Thu, 21 Sep 2017 19:06:56 +0000"  >&lt;p&gt;I&apos;ve also enabled this and required PR reviews and status checks on folio-org/stripes-core.   Mike and Jason are granted the ability to dismiss PR reviews as necessary.   Not to be abused &lt;img class=&quot;emoticon&quot; src=&quot;/images/icons/emoticons/smile.png&quot; height=&quot;16&quot; width=&quot;16&quot; align=&quot;absmiddle&quot; alt=&quot;&quot; border=&quot;0&quot;/&gt;&lt;/p&gt;
</comment>
                                                            <comment id="190267" author="5f9abc1eb45b2e007453f423" created="Tue, 26 Sep 2017 17:55:09 +0000"  >&lt;p&gt;enabled for the following projects: &lt;/p&gt;

&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;okapi&lt;/li&gt;
	&lt;li&gt;stripes-core&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Let&apos;s see how this goes for a few days before enabling across other projects. &lt;/p&gt;</comment>
                                                            <comment id="190270" author="5f9abc1eb45b2e007453f423" created="Wed, 27 Sep 2017 21:19:51 +0000"  >&lt;p&gt;Enabled protected branches and required PR reviews for the following additional projects: &lt;/p&gt;

&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;stripes-components&lt;/li&gt;
	&lt;li&gt;stripes-redux&lt;/li&gt;
	&lt;li&gt;stripes-form&lt;/li&gt;
	&lt;li&gt;stripes-logger&lt;/li&gt;
	&lt;li&gt;stripes-react-hotkeys&lt;/li&gt;
	&lt;li&gt;stripes-util-notes&lt;/li&gt;
	&lt;li&gt;eslint-config-stripes&lt;/li&gt;
	&lt;li&gt;ui-requests&lt;/li&gt;
	&lt;li&gt;ui-users&lt;/li&gt;
	&lt;li&gt;ui-circulation&lt;/li&gt;
	&lt;li&gt;ui-checkout&lt;/li&gt;
	&lt;li&gt;ui-items&lt;/li&gt;
	&lt;li&gt;ui-instances&lt;/li&gt;
	&lt;li&gt;ui-organization&lt;/li&gt;
	&lt;li&gt;ui-scan&lt;/li&gt;
	&lt;li&gt;ui-plugin-find-user&lt;/li&gt;
	&lt;li&gt;ui-developer&lt;/li&gt;
	&lt;li&gt;ui-checkin&lt;/li&gt;
&lt;/ul&gt;
</comment>
                                                            <comment id="190272" author="5f9abc1eb45b2e007453f423" created="Thu, 28 Sep 2017 15:31:34 +0000"  >&lt;p&gt;I&apos;ve enabled protected &apos;master&apos; branch across all FOLIO frontend and backend projects.   I&apos;ve rolled back enforcement of &apos;passing status checks option before merge&apos;.   Too risky right now with the implementation of Sonarqube in the CI process and other changes taking place.  We can re-enable that when that piece becomes more stable.   Only frontend projects, okapi, and cql2pgjson require PR reviews currently.   We should probably think harder about enabling this on backend modules since most backend modules currently have only one or two maintainers or contributors.   This could cause bottlenecks in workflow. &lt;/p&gt;</comment>
                                                            <comment id="190275" author="557058:63e17413-51f9-4a7c-910b-544728833e0f" created="Mon, 2 Oct 2017 13:03:24 +0000"  >&lt;p&gt;I thought we had decided that code reviews would be optional, at least for the core team. Am I wrong about that?&lt;/p&gt;</comment>
                                                            <comment id="190279" author="5bffed52a1b46046f530c8f7" created="Mon, 2 Oct 2017 13:05:17 +0000"  >&lt;p&gt;Apparently. I know, at least, that I can&apos;t merge any of my own PRs.&lt;/p&gt;</comment>
                                                            <comment id="190281" author="557058:63e17413-51f9-4a7c-910b-544728833e0f" created="Mon, 2 Oct 2017 13:09:40 +0000"  >&lt;p&gt;That&apos;s what I was anticipating being able to do. It&apos;s thrown my workflow a bit out of kilter.&lt;/p&gt;</comment>
                                                            <comment id="190282" author="5bffed52a1b46046f530c8f7" created="Mon, 2 Oct 2017 13:12:23 +0000"  >&lt;p&gt;Yeah. That&apos;s why we now have comments like Cate&apos;s most recent on UIU-130:&lt;/p&gt;

&lt;blockquote&gt;&lt;p&gt;@Jason - today FOLIO testing is up and running; therefor it would be awesome if you could find time to review Mike Taylor&apos;s change, so I can follow up, do test and we can close this jira. Thanks &lt;/p&gt;&lt;/blockquote&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10003">
                    <name>Relates</name>
                                                                <inwardlinks description="relates to">
                                        <issuelink>
            <issuekey id="80344">FOLIO-843</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                            <attachment id="63996" name="Screen Shot 2017-09-21 at 2.29.25 PM.png" size="301799" author="5f9abc1eb45b2e007453f423" created="Thu, 21 Sep 2017 18:36:12 +0000"/>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10000" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummarycf">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10019" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|hzxzov:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10020" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10024" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>[CHART] Date of First Response</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Thu, 21 Sep 2017 18:33:04 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10025" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>[CHART] Time in Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>