<!-- 
RSS generated by JIRA (1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d) at Thu Feb 08 23:22:51 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary add field=key&field=summary to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>FOLIO Jira</title>
    <link>https://folio-org.atlassian.net</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>1001.0.0-SNAPSHOT</version>
        <build-number>100246</build-number>
        <build-date>07-02-2024</build-date>
    </build-info>

<item>
            <title>[FOLIO-2734] mod-circulation fails tenant init in reference builds</title>
                <link>https://folio-org.atlassian.net/browse/FOLIO-2734</link>
                <project id="10290" key="FOLIO">FOLIO</project>
                    <description>&lt;p&gt;builds of folio-testing are failing when trying to enable mod-circulation. See attached mod circulation log.&lt;/p&gt;

&lt;p&gt;Error itself may coming from RMB?: &lt;a href=&quot;https://github.com/folio-org/raml-module-builder/blob/master/domain-models-interface-extensions/src/main/java/org/folio/rest/tools/PomReader.java#L37&quot; class=&quot;external-link&quot; rel=&quot;nofollow noreferrer&quot;&gt;https://github.com/folio-org/raml-module-builder/blob/master/domain-models-interface-extensions/src/main/java/org/folio/rest/tools/PomReader.java#L37&lt;/a&gt;&lt;/p&gt;
</description>
                <environment></environment>
        <key id="81810">FOLIO-2734</key>
            <summary>mod-circulation fails tenant init in reference builds</summary>
                <type id="10001" iconUrl="https://folio-org.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10303?size=medium">Bug</type>
                                            <priority id="10005" iconUrl="https://dev.folio.org/assets/jira-priority/tbd.svg">TBD</priority>
                        <status id="6" iconUrl="https://folio-org.atlassian.net/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10003">Done</resolution>
                                                        <assignee accountid="-1">Unassigned</assignee>
                                                                <reporter accountid="5cd423bebc70090d6ce241b1">Ian Hardy</reporter>
                                    <labels>
                    </labels>
                <created>Tue, 18 Aug 2020 12:56:24 +0000</created>
                <updated>Mon, 24 Aug 2020 11:00:39 +0000</updated>
                            <resolved>Mon, 24 Aug 2020 10:41:17 +0000</resolved>
                                                                        <due></due>
                            <votes>0</votes>
                                    <watches>4</watches>
                                                                <comments>
                                                            <comment id="196539" author="63e2a2771b13d42998e4e706" created="Tue, 18 Aug 2020 13:05:01 +0000"  >&lt;p&gt;&lt;a href=&quot;https://folio-org.atlassian.net/secure/ViewProfile.jspa?accountId=5ee89462f7aa140abd82d11d&quot; class=&quot;user-hover&quot; rel=&quot;5ee89462f7aa140abd82d11d&quot; data-account-id=&quot;5ee89462f7aa140abd82d11d&quot; accountid=&quot;5ee89462f7aa140abd82d11d&quot; rel=&quot;noreferrer&quot;&gt;Julian Ladisch&lt;/a&gt; &lt;a href=&quot;https://folio-org.atlassian.net/secure/ViewProfile.jspa?accountId=5f8314dfbdef80006f6f572d&quot; class=&quot;user-hover&quot; rel=&quot;5f8314dfbdef80006f6f572d&quot; data-account-id=&quot;5f8314dfbdef80006f6f572d&quot; accountid=&quot;5f8314dfbdef80006f6f572d&quot; rel=&quot;noreferrer&quot;&gt;Adam Dickmeiss&lt;/a&gt; &lt;a href=&quot;https://folio-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A06f9b6fb-9a52-481a-ad72-6e13fc570a8a&quot; class=&quot;user-hover&quot; rel=&quot;557058:06f9b6fb-9a52-481a-ad72-6e13fc570a8a&quot; data-account-id=&quot;557058:06f9b6fb-9a52-481a-ad72-6e13fc570a8a&quot; accountid=&quot;557058:06f9b6fb-9a52-481a-ad72-6e13fc570a8a&quot; rel=&quot;noreferrer&quot;&gt;Kateryna Senchenko&lt;/a&gt;&lt;/p&gt;

&lt;p&gt;Any ideas what might be causing this? Are / were there changes needed in pub-sub client or RAML Module Builder for this to make it compatible with JDK 11?&lt;/p&gt;</comment>
                                                            <comment id="196542" author="5ee89462f7aa140abd82d11d" created="Tue, 18 Aug 2020 13:31:52 +0000"  >&lt;p&gt;All dependencies must be Java 11 compatible.&lt;br/&gt;
The first RMB version that is Java 11 compatible is 31.0.0.&lt;br/&gt;
mod-circulation has older RMB dependencies that need to be upgraded:&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
mvn dependency:tree -Dincludes=org.folio

[INFO] org.folio:mod-circulation:jar:19.1.0-SNAPSHOT
[INFO] +- org.folio:mod-pubsub-client:jar:1.2.3:compile
[INFO] |  +- org.folio:domain-models-runtime:jar:30.0.2:compile
[INFO] |  |  \- org.folio:cql2pgjson:jar:30.0.2:compile
[INFO] |  |     \- org.folio:dbschema:jar:30.0.2:compile
[INFO] |  +- org.folio:domain-models-api-interfaces:jar:30.0.2:compile
[INFO] |  |  +- org.folio:domain-models-api-aspects:jar:30.0.2:compile
[INFO] |  |  \- org.folio:domain-models-&lt;span class=&quot;code-keyword&quot;&gt;interface&lt;/span&gt;-extensions:jar:30.0.2:compile
[INFO] |  \- org.folio:folio-di-support:jar:1.0.0:compile
[INFO] +- org.folio:util:jar:30.2.2:compile
[INFO] \- org.folio:testing:jar:30.2.2:test
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;</comment>
                                                            <comment id="196545" author="63e2a2771b13d42998e4e706" created="Tue, 18 Aug 2020 13:35:05 +0000"  >&lt;p&gt;&lt;a href=&quot;https://folio-org.atlassian.net/secure/ViewProfile.jspa?accountId=5ee89462f7aa140abd82d11d&quot; class=&quot;user-hover&quot; rel=&quot;5ee89462f7aa140abd82d11d&quot; data-account-id=&quot;5ee89462f7aa140abd82d11d&quot; accountid=&quot;5ee89462f7aa140abd82d11d&quot; rel=&quot;noreferrer&quot;&gt;Julian Ladisch&lt;/a&gt;&lt;/p&gt;

&lt;p&gt;Thanks. I hadn&apos;t realised (or had forgotten) that mod-circulation circuitously includes RAML Module Builder :-/ &lt;/p&gt;

&lt;p&gt;Why wouldn&apos;t the Jenkins build running on JDK 11 have picked this up?&lt;/p&gt;</comment>
                                                            <comment id="196547" author="5ee89462f7aa140abd82d11d" created="Tue, 18 Aug 2020 13:55:35 +0000"  >&lt;p&gt;Is there an integration test that runs Launcher.main? &lt;a href=&quot;https://github.com/folio-org/mod-circulation/blob/76651ffa520f196957befc5b9c88bbeab917ef7c/pom.xml#L289&quot; class=&quot;external-link&quot; rel=&quot;nofollow noreferrer&quot;&gt;https://github.com/folio-org/mod-circulation/blob/76651ffa520f196957befc5b9c88bbeab917ef7c/pom.xml#L289&lt;/a&gt;&lt;/p&gt;</comment>
                                                            <comment id="196550" author="63e2a2771b13d42998e4e706" created="Tue, 18 Aug 2020 14:29:08 +0000"  >&lt;p&gt;&lt;a href=&quot;https://folio-org.atlassian.net/secure/ViewProfile.jspa?accountId=5ee89462f7aa140abd82d11d&quot; class=&quot;user-hover&quot; rel=&quot;5ee89462f7aa140abd82d11d&quot; data-account-id=&quot;5ee89462f7aa140abd82d11d&quot; accountid=&quot;5ee89462f7aa140abd82d11d&quot; rel=&quot;noreferrer&quot;&gt;Julian Ladisch&lt;/a&gt;&lt;/p&gt;

&lt;blockquote&gt;&lt;p&gt;Is there an integration test that runs Launcher.main?&lt;/p&gt;&lt;/blockquote&gt;

&lt;p&gt;No, however all of the API / integration tests use &lt;tt&gt;launcher.start&lt;/tt&gt; which I would imagine for these purposes is equivalent, given that the error occurs during the Tenant API which is invoked during those tests.&lt;/p&gt;</comment>
                                                            <comment id="196552" author="557058:89dc6567-baed-429c-bebb-dfcc7e5dcc50" created="Tue, 18 Aug 2020 15:58:07 +0000"  >&lt;p&gt;&lt;a href=&quot;https://folio-org.atlassian.net/secure/ViewProfile.jspa?accountId=63e2a2771b13d42998e4e706&quot; class=&quot;user-hover&quot; rel=&quot;63e2a2771b13d42998e4e706&quot; data-account-id=&quot;63e2a2771b13d42998e4e706&quot; accountid=&quot;63e2a2771b13d42998e4e706&quot; rel=&quot;noreferrer&quot;&gt;Marc Johnson&lt;/a&gt;,&lt;/p&gt;

&lt;p&gt;The utility method that causes the issue executes different parts of logic depending whether it is executed within jar file or tests - &lt;a href=&quot;https://github.com/folio-org/raml-module-builder/blob/master/domain-models-interface-extensions/src/main/java/org/folio/rest/tools/PomReader.java#L43-L62&quot; class=&quot;external-link&quot; rel=&quot;nofollow noreferrer&quot;&gt;PomReader.java&lt;/a&gt;.&lt;/p&gt;

&lt;p&gt;I think we should revert circ now until the pub-sub client is migrated to the latest RMB. Alternatively, just use own client. &lt;/p&gt;</comment>
                                                            <comment id="196560" author="63e2a2771b13d42998e4e706" created="Tue, 18 Aug 2020 16:08:02 +0000"  >&lt;p&gt;&lt;a href=&quot;https://folio-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A89dc6567-baed-429c-bebb-dfcc7e5dcc50&quot; class=&quot;user-hover&quot; rel=&quot;557058:89dc6567-baed-429c-bebb-dfcc7e5dcc50&quot; data-account-id=&quot;557058:89dc6567-baed-429c-bebb-dfcc7e5dcc50&quot; accountid=&quot;557058:89dc6567-baed-429c-bebb-dfcc7e5dcc50&quot; rel=&quot;noreferrer&quot;&gt;Bohdan Suprun&lt;/a&gt;&lt;/p&gt;

&lt;p&gt;Thanks for investigating this.&lt;/p&gt;

&lt;blockquote&gt;&lt;p&gt;The utility method that causes the issue executes different parts of logic depending whether it is executed within jar file or tests&lt;/p&gt;&lt;/blockquote&gt;

&lt;p&gt;That&apos;s unfortunate. Meaning that tests would not have caught this :-/&lt;/p&gt;

&lt;blockquote&gt;&lt;p&gt;I think we should revert circ now until the pub-sub client is migrated to the latest RMB. Alternatively, just use own client.&lt;/p&gt;&lt;/blockquote&gt;

&lt;p&gt;I&apos;ll revert the JDK 11 upgrade of mod-circulation :-/ &lt;/p&gt;

&lt;p&gt;&lt;a href=&quot;https://folio-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A06f9b6fb-9a52-481a-ad72-6e13fc570a8a&quot; class=&quot;user-hover&quot; rel=&quot;557058:06f9b6fb-9a52-481a-ad72-6e13fc570a8a&quot; data-account-id=&quot;557058:06f9b6fb-9a52-481a-ad72-6e13fc570a8a&quot; accountid=&quot;557058:06f9b6fb-9a52-481a-ad72-6e13fc570a8a&quot; rel=&quot;noreferrer&quot;&gt;Kateryna Senchenko&lt;/a&gt; Is there an issue for making the pub-sub client compatible with JDK 11, that the mod-circulation upgrade can be blocked on?&lt;/p&gt;</comment>
                                                            <comment id="196563" author="5ee89462f7aa140abd82d11d" created="Tue, 18 Aug 2020 17:43:46 +0000"  >&lt;p&gt;mod-circulation has unit tests only: *Test.java executed by maven-surefire-plugin.&lt;br/&gt;
It doesn&apos;t have integration test: *IT.java executed by maven-failsafe-plugin.&lt;/p&gt;</comment>
                                                            <comment id="196565" author="63e2a2771b13d42998e4e706" created="Tue, 18 Aug 2020 19:49:37 +0000"  >&lt;p&gt;&lt;a href=&quot;https://folio-org.atlassian.net/secure/ViewProfile.jspa?accountId=5ee89462f7aa140abd82d11d&quot; class=&quot;user-hover&quot; rel=&quot;5ee89462f7aa140abd82d11d&quot; data-account-id=&quot;5ee89462f7aa140abd82d11d&quot; accountid=&quot;5ee89462f7aa140abd82d11d&quot; rel=&quot;noreferrer&quot;&gt;Julian Ladisch&lt;/a&gt;&lt;/p&gt;

&lt;p&gt;I don&apos;t really understand the difference between surefire and failsafe. Do they define a special meaning for unit and integration tests? And tests executed by the failsafe plugin execute the packaged jar? &lt;/p&gt;</comment>
                                                            <comment id="196567" author="5ee89462f7aa140abd82d11d" created="Wed, 19 Aug 2020 07:16:34 +0000"  >&lt;p&gt;Yes.&lt;br/&gt;
Example for raml-module-builder/util submodule, output taken from &lt;tt&gt;mvn --debug clean verify&lt;/tt&gt;:&lt;/p&gt;

&lt;p&gt;surefire:&lt;br/&gt;
boot(compact) classpath:  ...   test-classes  classes  ...&lt;/p&gt;

&lt;p&gt;failsafe:&lt;br/&gt;
boot(compact) classpath:  ...  test-classes  util-31.1.0-SNAPSHOT.jar ...&lt;/p&gt;

&lt;p&gt;maven has these phases (taken from &lt;a href=&quot;https://maven.apache.org/guides/getting-started/maven-in-five-minutes.html#maven-phases&quot; class=&quot;external-link&quot; rel=&quot;nofollow noreferrer&quot;&gt;https://maven.apache.org/guides/getting-started/maven-in-five-minutes.html#maven-phases&lt;/a&gt; ):&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;validate: validate the project is correct and all necessary information is available&lt;/li&gt;
	&lt;li&gt;compile: compile the source code of the project&lt;/li&gt;
	&lt;li&gt;test: test the compiled source code using a suitable unit testing framework. These tests should not require the code be packaged or deployed&lt;/li&gt;
	&lt;li&gt;package: take the compiled code and package it in its distributable format, such as a JAR.&lt;/li&gt;
	&lt;li&gt;integration-test: process and deploy the package if necessary into an environment where integration tests can be run&lt;/li&gt;
	&lt;li&gt;verify: run any checks to verify the package is valid and meets quality criteria&lt;/li&gt;
	&lt;li&gt;install: install the package into the local repository, for use as a dependency in other projects locally&lt;/li&gt;
	&lt;li&gt;deploy: done in an integration or release environment, copies the final package to the remote repository for sharing with other developers and projects.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;surefire is the test phase and tests the .class files, failsafe is the integration-test and verify phase and tests the .jar file.&lt;/p&gt;</comment>
                                                            <comment id="196570" author="63e2a2771b13d42998e4e706" created="Wed, 19 Aug 2020 09:08:20 +0000"  >&lt;p&gt;Thanks &lt;a href=&quot;https://folio-org.atlassian.net/secure/ViewProfile.jspa?accountId=5ee89462f7aa140abd82d11d&quot; class=&quot;user-hover&quot; rel=&quot;5ee89462f7aa140abd82d11d&quot; data-account-id=&quot;5ee89462f7aa140abd82d11d&quot; accountid=&quot;5ee89462f7aa140abd82d11d&quot; rel=&quot;noreferrer&quot;&gt;Julian Ladisch&lt;/a&gt; I&apos;m still rather inexperienced with Maven.&lt;/p&gt;

&lt;p&gt;I may investigate moving the API style tests over to use the failSafe plugin and the integration-test phase.&lt;/p&gt;</comment>
                                                            <comment id="196573" author="63e2a2771b13d42998e4e706" created="Mon, 24 Aug 2020 10:41:17 +0000"  >&lt;p&gt;Resolved by reverting the upgrade to Java 11&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10003">
                    <name>Relates</name>
                                            <outwardlinks description="relates to">
                                        <issuelink>
            <issuekey id="48642">CIRC-883</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                    </issuelinks>
                <attachments>
                            <attachment id="64310" name="mod-circulation.log" size="8698" author="5cd423bebc70090d6ce241b1" created="Tue, 18 Aug 2020 12:53:43 +0000"/>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10000" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummarycf">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10057" key="com.atlassian.jira.plugin.system.customfieldtypes:select">
                        <customfieldname>Development Team</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10155"><![CDATA[FOLIO DevOps]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10019" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|i01k4b:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10020" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10024" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>[CHART] Date of First Response</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Tue, 18 Aug 2020 13:05:01 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10025" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>[CHART] Time in Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>