<!-- 
RSS generated by JIRA (1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d) at Thu Feb 08 23:22:20 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary add field=key&field=summary to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>FOLIO Jira</title>
    <link>https://folio-org.atlassian.net</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>1001.0.0-SNAPSHOT</version>
        <build-number>100246</build-number>
        <build-date>07-02-2024</build-date>
    </build-info>

<item>
            <title>[FOLIO-2664] Build mod-ldp </title>
                <link>https://folio-org.atlassian.net/browse/FOLIO-2664</link>
                <project id="10290" key="FOLIO">FOLIO</project>
                    <description>&lt;p&gt;Publish to folio repo, and docker hub:&lt;/p&gt;

&lt;p&gt;&lt;a href=&quot;https://github.com/library-data-platform/mod-ldp&quot; class=&quot;external-link&quot; rel=&quot;nofollow noreferrer&quot;&gt;https://github.com/library-data-platform/mod-ldp&lt;/a&gt;&lt;/p&gt;</description>
                <environment></environment>
        <key id="81704">FOLIO-2664</key>
            <summary>Build mod-ldp </summary>
                <type id="10005" iconUrl="https://folio-org.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10309?size=medium">Story</type>
                                            <priority id="10005" iconUrl="https://dev.folio.org/assets/jira-priority/tbd.svg">TBD</priority>
                        <status id="6" iconUrl="https://folio-org.atlassian.net/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10003">Done</resolution>
                                                        <assignee accountid="5cd423bebc70090d6ce241b1">Ian Hardy</assignee>
                                                                <reporter accountid="5cd423bebc70090d6ce241b1">Ian Hardy</reporter>
                                    <labels>
                    </labels>
                <created>Mon, 29 Jun 2020 13:51:59 +0000</created>
                <updated>Mon, 3 Aug 2020 18:39:46 +0000</updated>
                            <resolved>Fri, 24 Jul 2020 12:51:54 +0000</resolved>
                                                                        <due></due>
                            <votes>0</votes>
                                    <watches>4</watches>
                                                                <comments>
                                                            <comment id="199261" author="5cd423bebc70090d6ce241b1" created="Mon, 29 Jun 2020 14:43:42 +0000"  >&lt;p&gt;Hi &lt;a href=&quot;https://folio-org.atlassian.net/secure/ViewProfile.jspa?accountId=712020%3Aab056d11-351f-4bae-bfca-8ba958686420&quot; class=&quot;user-hover&quot; rel=&quot;712020:ab056d11-351f-4bae-bfca-8ba958686420&quot; data-account-id=&quot;712020:ab056d11-351f-4bae-bfca-8ba958686420&quot; accountid=&quot;712020:ab056d11-351f-4bae-bfca-8ba958686420&quot; rel=&quot;noreferrer&quot;&gt;Roman Ruiz-Esparza&lt;/a&gt; and &lt;a href=&quot;https://folio-org.atlassian.net/secure/ViewProfile.jspa?accountId=70121%3A8d96963c-ce4c-478d-9023-2de35bc14b67&quot; class=&quot;user-hover&quot; rel=&quot;70121:8d96963c-ce4c-478d-9023-2de35bc14b67&quot; data-account-id=&quot;70121:8d96963c-ce4c-478d-9023-2de35bc14b67&quot; accountid=&quot;70121:8d96963c-ce4c-478d-9023-2de35bc14b67&quot; rel=&quot;noreferrer&quot;&gt;Nassib Nassar&lt;/a&gt; Any reason not to have this in the folio-org github organization or should it stay in library-data-project?&lt;/p&gt;</comment>
                                                            <comment id="199263" author="70121:8d96963c-ce4c-478d-9023-2de35bc14b67" created="Mon, 29 Jun 2020 15:09:01 +0000"  >&lt;p&gt;It is not FOLIO-specific and should stay in library-data-project.&lt;/p&gt;</comment>
                                                            <comment id="199266" author="5cd423bebc70090d6ce241b1" created="Fri, 17 Jul 2020 16:04:24 +0000"  >&lt;p&gt;I&apos;ve added the library-data-platform org on Jenkins so we can build projects from that organization. It&apos;s temporarily building anything with a config at Jenkinsfile.tst (will remove tst suffix when we&apos;re happy with the setup). &lt;/p&gt;

&lt;p&gt;Here&apos;s the first build (failing): &lt;a href=&quot;https://jenkins-aws.indexdata.com/job/library-data-platform/job/mod-ldp/job/test-jenkinsfile/1/console&quot; class=&quot;external-link&quot; rel=&quot;nofollow noreferrer&quot;&gt;https://jenkins-aws.indexdata.com/job/library-data-platform/job/mod-ldp/job/test-jenkinsfile/1/console&lt;/a&gt;&lt;/p&gt;

&lt;p&gt;A few questions. &lt;/p&gt;

&lt;p&gt;1.) On the readme, the instructions specify we should use mvnw to build. What&apos;s getting added by using the wrapper. Generally it would be nice if we could use &quot;mvn install&quot; since thats what the Jenkins pipelines we have configured will do. Its not a problem to do something else if necessary though.&lt;/p&gt;

&lt;p&gt;2.) I see that there&apos;s also an instruction to set an environment variable SPRING_DATASOURCE_PASSWORD. The readme says set this before building--is this necessary? Can this be set at runtime? What is the datasource that&apos;s getting set here, a FOLIO DB or an LDP DB?&lt;/p&gt;</comment>
                                                            <comment id="199269" author="712020:ab056d11-351f-4bae-bfca-8ba958686420" created="Fri, 17 Jul 2020 18:50:37 +0000"  >&lt;p&gt;1) Regular mvn will work, no need to worry about mvnw&lt;br/&gt;
2) The datasource is a separately hosted LDP DB (Postgres). I can message you the password over Slack.&lt;/p&gt;</comment>
                                                            <comment id="199271" author="5cd423bebc70090d6ce241b1" created="Tue, 21 Jul 2020 14:08:58 +0000"  >&lt;p&gt;Hi again. I noticed a couple of things in test builds that we may want to address:&lt;/p&gt;

&lt;ol&gt;
	&lt;li&gt;the namespace here is com.folio, the convention is org.folio. May want to update that&lt;/li&gt;
	&lt;li&gt;Would be good to use templates to produce the descriptors. You can check out the pom.xml files of other modules to see how this is done: &lt;a href=&quot;https://github.com/folio-org/mod-circulation/blob/master/pom.xml#L299&quot; class=&quot;external-link&quot; rel=&quot;nofollow noreferrer&quot;&gt;https://github.com/folio-org/mod-circulation/blob/master/pom.xml#L299&lt;/a&gt;&lt;/li&gt;
	&lt;li&gt;Most other maven builds use the shade plugin to produce a &quot;fat&quot; jar. I gather spring does something like this for us. One other thing the shade plugin does is produce one artifact with a consistent name which is picked up by the Docker build. I tried just using a maven plugin to create a jar with a consistent name.&lt;/li&gt;
	&lt;li&gt;Needs Dockerfile (I can add this)&lt;/li&gt;
&lt;/ol&gt;


&lt;p&gt;I took a shot at addressing these on the test-jenkinsfile branch. I hesitate to mess with the pom and build details myself too much since I&apos;m not a developer. If you get a chance, check out those changes. We can either use them or if you prefer you can address the issues above another way.&lt;/p&gt;

&lt;p&gt;Thanks,&lt;/p&gt;

&lt;p&gt;Ian&lt;/p&gt;</comment>
                                                            <comment id="199274" author="5cd423bebc70090d6ce241b1" created="Fri, 24 Jul 2020 12:51:44 +0000"  >&lt;p&gt;&lt;a href=&quot;https://folio-org.atlassian.net/secure/ViewProfile.jspa?accountId=712020%3Aab056d11-351f-4bae-bfca-8ba958686420&quot; class=&quot;user-hover&quot; rel=&quot;712020:ab056d11-351f-4bae-bfca-8ba958686420&quot; data-account-id=&quot;712020:ab056d11-351f-4bae-bfca-8ba958686420&quot; accountid=&quot;712020:ab056d11-351f-4bae-bfca-8ba958686420&quot; rel=&quot;noreferrer&quot;&gt;Roman Ruiz-Esparza&lt;/a&gt; and &lt;a href=&quot;https://folio-org.atlassian.net/secure/ViewProfile.jspa?accountId=70121%3A8d96963c-ce4c-478d-9023-2de35bc14b67&quot; class=&quot;user-hover&quot; rel=&quot;70121:8d96963c-ce4c-478d-9023-2de35bc14b67&quot; data-account-id=&quot;70121:8d96963c-ce4c-478d-9023-2de35bc14b67&quot; accountid=&quot;70121:8d96963c-ce4c-478d-9023-2de35bc14b67&quot; rel=&quot;noreferrer&quot;&gt;Nassib Nassar&lt;/a&gt;, Thanks for your patience. Jenkins will now attempt to build any repo in the library-data-project repository with a file called &quot;Jenkinsfile&quot;. You can rename to Jenkinsfile.xxxxx if you don&apos;t want a particular repo to build. I&apos;ve resovled the webhook issue so it should notice changes to all branches now. I&apos;ll close one now.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10003">
                    <name>Relates</name>
                                            <outwardlinks description="relates to">
                                        <issuelink>
            <issuekey id="81821">FOLIO-2711</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10000" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummarycf">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10057" key="com.atlassian.jira.plugin.system.customfieldtypes:select">
                        <customfieldname>Development Team</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10155"><![CDATA[FOLIO DevOps]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10019" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|i01d6f:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10020" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="1986">DevOps: sprint 92</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10024" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>[CHART] Date of First Response</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Mon, 29 Jun 2020 15:09:01 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10025" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>[CHART] Time in Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>