<!-- 
RSS generated by JIRA (1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d) at Thu Feb 08 23:16:14 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary add field=key&field=summary to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>FOLIO Jira</title>
    <link>https://folio-org.atlassian.net</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>1001.0.0-SNAPSHOT</version>
        <build-number>100246</build-number>
        <build-date>07-02-2024</build-date>
    </build-info>

<item>
            <title>[FOLIO-1831] Enforce 1 mandatory PR approval before allowing merge for acquisitions repos</title>
                <link>https://folio-org.atlassian.net/browse/FOLIO-1831</link>
                <project id="10290" key="FOLIO">FOLIO</project>
                    <description>&lt;p&gt;Please adjust github settings for the following repositories so that a minimum of 1 PR approval is required before allowing a PR merge.&lt;/p&gt;

&lt;p&gt;If possible, please disallow self-approval of PRs&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;mod-orders&lt;/li&gt;
	&lt;li&gt;mod-orders-storage&lt;/li&gt;
	&lt;li&gt;mod-vendors&lt;/li&gt;
	&lt;li&gt;mod-finance&lt;/li&gt;
	&lt;li&gt;mod-gobi&lt;/li&gt;
	&lt;li&gt;mod-invoice&lt;/li&gt;
	&lt;li&gt;mod-invoice-storage&lt;/li&gt;
	&lt;li&gt;edge-orders&lt;/li&gt;
	&lt;li&gt;ui-orders&lt;/li&gt;
	&lt;li&gt;ui-vendors&lt;/li&gt;
	&lt;li&gt;ui-finance&lt;/li&gt;
	&lt;li&gt;ui-receiving&lt;/li&gt;
	&lt;li&gt;ui-invoice&lt;/li&gt;
&lt;/ul&gt;
</description>
                <environment></environment>
        <key id="81012">FOLIO-1831</key>
            <summary>Enforce 1 mandatory PR approval before allowing merge for acquisitions repos</summary>
                <type id="10005" iconUrl="https://folio-org.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10309?size=medium">Story</type>
                                            <priority id="10002" iconUrl="https://dev.folio.org/assets/jira-priority/jira-p3.svg">P3</priority>
                        <status id="6" iconUrl="https://folio-org.atlassian.net/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10003">Done</resolution>
                                                        <assignee accountid="61cd0ca0bce5e00069e98be7">David Crossley</assignee>
                                                                <reporter accountid="5cf6c546b87c300f36eb7b9a">Craig McNally</reporter>
                                    <labels>
                            <label>ci</label>
                            <label>platform-backlog</label>
                    </labels>
                <created>Wed, 27 Feb 2019 16:39:39 +0000</created>
                <updated>Wed, 3 Jun 2020 16:39:33 +0000</updated>
                            <resolved>Thu, 28 Feb 2019 23:05:16 +0000</resolved>
                                                                    <component>Continuous Integration</component>
                        <due></due>
                            <votes>0</votes>
                                    <watches>2</watches>
                                                                <comments>
                                                            <comment id="192223" author="61cd0ca0bce5e00069e98be7" created="Thu, 28 Feb 2019 03:09:59 +0000"  >&lt;p&gt;Done all of those repositories.&lt;/p&gt;

&lt;p&gt;However, i presume that you intended &quot;mod-finance-storage&quot; (and i have done that one). The &quot;mod-finance&quot; is still only partially setup.&lt;/p&gt;

&lt;p&gt;Yes, people cannot merge their own PRs (until there is an approval). That is implicit.&lt;/p&gt;</comment>
                                                            <comment id="192224" author="61cd0ca0bce5e00069e98be7" created="Thu, 28 Feb 2019 03:10:53 +0000"  >&lt;p&gt;There is an option that i did not enable (it is disabled by default):&lt;/p&gt;

&lt;blockquote&gt;
&lt;p&gt;&lt;b&gt;Dismiss stale pull request approvals when new commits are pushed&lt;/b&gt;&lt;br/&gt;
New reviewable commits pushed to a matching branch will dismiss pull request review approvals.&lt;/p&gt;&lt;/blockquote&gt;</comment>
                                                            <comment id="192225" author="5cf6c546b87c300f36eb7b9a" created="Thu, 28 Feb 2019 15:57:18 +0000"  >&lt;p&gt;Great, thanks &lt;a href=&quot;https://folio-org.atlassian.net/secure/ViewProfile.jspa?accountId=61cd0ca0bce5e00069e98be7&quot; class=&quot;user-hover&quot; rel=&quot;61cd0ca0bce5e00069e98be7&quot; data-account-id=&quot;61cd0ca0bce5e00069e98be7&quot; accountid=&quot;61cd0ca0bce5e00069e98be7&quot; rel=&quot;noreferrer&quot;&gt;David Crossley&lt;/a&gt;!  I appreciate you taking the initiative and using common sense wrt mod-finance(-storage).&lt;/p&gt;

&lt;p&gt;For now let&apos;s leave the stale PR approvals setting as-is.&lt;/p&gt;</comment>
                                                            <comment id="192226" author="61cd0ca0bce5e00069e98be7" created="Fri, 9 Aug 2019 07:25:10 +0000"  >&lt;p&gt;Now that mod-finance repository has been re-established, enabled its &quot;1 mandatory PR approval&quot; same as the others.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10003">
                    <name>Relates</name>
                                                                <inwardlinks description="relates to">
                                        <issuelink>
            <issuekey id="81052">FOLIO-1801</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10000" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummarycf">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10057" key="com.atlassian.jira.plugin.system.customfieldtypes:select">
                        <customfieldname>Development Team</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10144"><![CDATA[Core: Platform]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10019" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|hzzgyv:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10020" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="1148">Core: Platform - Sprint 58</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10044" key="com.atlassian.jira.plugin.system.customfieldtypes:float">
                        <customfieldname>Story Points</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10024" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>[CHART] Date of First Response</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Thu, 28 Feb 2019 03:09:59 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10025" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>[CHART] Time in Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>