<!-- 
RSS generated by JIRA (1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d) at Thu Feb 08 23:16:08 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary add field=key&field=summary to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>FOLIO Jira</title>
    <link>https://folio-org.atlassian.net</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>1001.0.0-SNAPSHOT</version>
        <build-number>100246</build-number>
        <build-date>07-02-2024</build-date>
    </build-info>

<item>
            <title>[FOLIO-1818] Sonar analysis &quot;coverage on new code&quot; for PRs of NPM-based repos not happening recently</title>
                <link>https://folio-org.atlassian.net/browse/FOLIO-1818</link>
                <project id="10290" key="FOLIO">FOLIO</project>
                    <description>&lt;p&gt;Sonar &quot;coverage on new code&quot; is not happening for pull requests, for NPM-based repositories.&lt;br/&gt;
See comment in slack#development on 20199221&lt;/p&gt;

&lt;p&gt;It is happening okay for Maven-based repsitories.&lt;/p&gt;</description>
                <environment></environment>
        <key id="81101">FOLIO-1818</key>
            <summary>Sonar analysis &quot;coverage on new code&quot; for PRs of NPM-based repos not happening recently</summary>
                <type id="10001" iconUrl="https://folio-org.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10303?size=medium">Bug</type>
                                            <priority id="10002" iconUrl="https://dev.folio.org/assets/jira-priority/jira-p3.svg">P3</priority>
                        <status id="6" iconUrl="https://folio-org.atlassian.net/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10003">Done</resolution>
                                                        <assignee accountid="61cd0ca0bce5e00069e98be7">David Crossley</assignee>
                                                                <reporter accountid="61cd0ca0bce5e00069e98be7">David Crossley</reporter>
                                    <labels>
                            <label>ci</label>
                            <label>platform-backlog</label>
                    </labels>
                <created>Thu, 21 Feb 2019 06:09:25 +0000</created>
                <updated>Wed, 3 Jun 2020 16:39:31 +0000</updated>
                            <resolved>Thu, 28 Feb 2019 05:07:06 +0000</resolved>
                                                                        <due></due>
                            <votes>0</votes>
                                    <watches>3</watches>
                                                                <comments>
                                                            <comment id="196007" author="61cd0ca0bce5e00069e98be7" created="Thu, 21 Feb 2019 06:09:57 +0000"  >&lt;p&gt;For example, &lt;a href=&quot;https://github.com/folio-org/ui-orders/pull/266/checks&quot; class=&quot;external-link&quot; rel=&quot;nofollow noreferrer&quot;&gt;https://github.com/folio-org/ui-orders/pull/266/checks&lt;/a&gt;&lt;br/&gt;
on the Checks tab shows &quot;0.0% Coverage&quot;&lt;br/&gt;
&lt;a href=&quot;https://sonarcloud.io/component_measures?id=org.folio%3Aui-orders&amp;amp;pullRequest=266&quot; class=&quot;external-link&quot; rel=&quot;nofollow noreferrer&quot;&gt;https://sonarcloud.io/component_measures?id=org.folio%3Aui-orders&amp;amp;pullRequest=266&lt;/a&gt;&lt;/p&gt;

&lt;p&gt;Whereas Maven-based ones are okay.&lt;br/&gt;
For example, &lt;a href=&quot;https://github.com/folio-org/mod-circulation/pull/191/checks&quot; class=&quot;external-link&quot; rel=&quot;nofollow noreferrer&quot;&gt;https://github.com/folio-org/mod-circulation/pull/191/checks&lt;/a&gt;&lt;br/&gt;
on the Checks tab shows &quot;92.9% Coverage&quot;&lt;br/&gt;
&lt;a href=&quot;https://sonarcloud.io/component_measures?id=org.folio%3Amod-circulation&amp;amp;pullRequest=191&quot; class=&quot;external-link&quot; rel=&quot;nofollow noreferrer&quot;&gt;https://sonarcloud.io/component_measures?id=org.folio%3Amod-circulation&amp;amp;pullRequest=191&lt;/a&gt;&lt;/p&gt;</comment>
                                                            <comment id="196009" author="61cd0ca0bce5e00069e98be7" created="Thu, 21 Feb 2019 06:10:37 +0000"  >&lt;p&gt;Not sure yet if related to 
    &lt;span class=&quot;jira-issue-macro resolved&quot; data-jira-key=&quot;FOLIO-1763&quot; &gt;
                &lt;a href=&quot;https://folio-org.atlassian.net/browse/FOLIO-1763&quot; class=&quot;jira-issue-macro-key issue-link&quot;  title=&quot;Sonarcloud analysis not updating GitHub PR and Checks&quot; &gt;
            &lt;img class=&quot;icon&quot; src=&quot;https://folio-org.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10303?size=medium&quot; /&gt;
            FOLIO-1763
        &lt;/a&gt;
                                                    &lt;span class=&quot;aui-lozenge aui-lozenge-subtle aui-lozenge-success jira-macro-single-issue-export-pdf&quot;&gt;Closed&lt;/span&gt;
            &lt;/span&gt;
, which seems to be related to changes to Sonar around mid-January 2019.&lt;/p&gt;

&lt;p&gt;Note that we cannot now look back to see when it last worked, as our SonarCloud reports are deleted after about one month.&lt;/p&gt;</comment>
                                                            <comment id="196010" author="61cd0ca0bce5e00069e98be7" created="Fri, 22 Feb 2019 07:08:32 +0000"  >&lt;p&gt;It is not related.&lt;/p&gt;

&lt;p&gt;Investigation ...&lt;/p&gt;

&lt;p&gt;SonarQube scan for NPM-based projects was added 20180925 and lcov reports being run on all builds.&lt;/p&gt;

&lt;p&gt;Soon after the jenkins-pipeline-libs was expanded to (among other changes) have separate configuration for master, branch, and PRs.&lt;br/&gt;
&lt;a href=&quot;https://github.com/folio-org/jenkins-pipeline-libs/pull/53&quot; class=&quot;external-link&quot; rel=&quot;nofollow noreferrer&quot;&gt;https://github.com/folio-org/jenkins-pipeline-libs/pull/53&lt;/a&gt; (
    &lt;span class=&quot;jira-issue-macro resolved&quot; data-jira-key=&quot;FOLIO-1407&quot; &gt;
                &lt;a href=&quot;https://folio-org.atlassian.net/browse/FOLIO-1407&quot; class=&quot;jira-issue-macro-key issue-link&quot;  title=&quot;Publish karma/nightmare coverage reports in Jenkins/integration with Sonarqube &quot; &gt;
            &lt;img class=&quot;icon&quot; src=&quot;https://folio-org.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10318?size=medium&quot; /&gt;
            FOLIO-1407
        &lt;/a&gt;
                                                    &lt;span class=&quot;aui-lozenge aui-lozenge-subtle aui-lozenge-success jira-macro-single-issue-export-pdf&quot;&gt;Closed&lt;/span&gt;
            &lt;/span&gt;
)&lt;/p&gt;

&lt;p&gt;The PR arm of vars/sonarqubeScanNPM.groovy does not have the option:&lt;/p&gt;
&lt;div class=&quot;preformatted panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;preformattedContent panelContent&quot;&gt;
&lt;pre&gt;&quot;-Dsonar.javascript.lcov.reportPaths=${lcovPath}/lcov.info&quot;&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;
&lt;p&gt;so no reports, only on branches and master.&lt;/p&gt;

&lt;p&gt;&lt;a href=&quot;https://folio-org.atlassian.net/secure/ViewProfile.jspa?accountId=5f9abc1eb45b2e007453f423&quot; class=&quot;user-hover&quot; rel=&quot;5f9abc1eb45b2e007453f423&quot; data-account-id=&quot;5f9abc1eb45b2e007453f423&quot; accountid=&quot;5f9abc1eb45b2e007453f423&quot; rel=&quot;noreferrer&quot;&gt;John Malconian&lt;/a&gt; should that change be made to enable Sonar code coverage reports on PRs?&lt;/p&gt;</comment>
                                                            <comment id="196012" author="5f9abc1eb45b2e007453f423" created="Mon, 25 Feb 2019 11:11:57 +0000"  >&lt;p&gt;&lt;a href=&quot;https://folio-org.atlassian.net/secure/ViewProfile.jspa?accountId=61cd0ca0bce5e00069e98be7&quot; class=&quot;user-hover&quot; rel=&quot;61cd0ca0bce5e00069e98be7&quot; data-account-id=&quot;61cd0ca0bce5e00069e98be7&quot; accountid=&quot;61cd0ca0bce5e00069e98be7&quot; rel=&quot;noreferrer&quot;&gt;David Crossley&lt;/a&gt; Yes, go ahead and try it on PRs. &lt;/p&gt;</comment>
                                                            <comment id="196013" author="61cd0ca0bce5e00069e98be7" created="Tue, 26 Feb 2019 02:20:52 +0000"  >&lt;p&gt;There is a PR here to test this:&lt;br/&gt;
&lt;a href=&quot;https://github.com/folio-org/ui-orders/pull/275&quot; class=&quot;external-link&quot; rel=&quot;nofollow noreferrer&quot;&gt;https://github.com/folio-org/ui-orders/pull/275&lt;/a&gt;&lt;/p&gt;

&lt;p&gt;&lt;a href=&quot;https://folio-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A09292aa8-9d37-482b-b244-17349bbbf497&quot; class=&quot;user-hover&quot; rel=&quot;557058:09292aa8-9d37-482b-b244-17349bbbf497&quot; data-account-id=&quot;557058:09292aa8-9d37-482b-b244-17349bbbf497&quot; accountid=&quot;557058:09292aa8-9d37-482b-b244-17349bbbf497&quot; rel=&quot;noreferrer&quot;&gt;Aliaksei Chumakou&lt;/a&gt; As asked there, would you please add a sensible test portion of new code.&lt;/p&gt;</comment>
                                                            <comment id="196015" author="557058:09292aa8-9d37-482b-b244-17349bbbf497" created="Tue, 26 Feb 2019 13:04:58 +0000"  >&lt;p&gt;&lt;a href=&quot;https://folio-org.atlassian.net/secure/ViewProfile.jspa?accountId=61cd0ca0bce5e00069e98be7&quot; class=&quot;user-hover&quot; rel=&quot;61cd0ca0bce5e00069e98be7&quot; data-account-id=&quot;61cd0ca0bce5e00069e98be7&quot; accountid=&quot;61cd0ca0bce5e00069e98be7&quot; rel=&quot;noreferrer&quot;&gt;David Crossley&lt;/a&gt; Actually this might be connected with parsing code issue in SonarJS, here is the fix 11 days ago, to use babel parser instead of espree &lt;a href=&quot;https://github.com/SonarSource/SonarJS/pull/1183/files&quot; class=&quot;external-link&quot; rel=&quot;nofollow noreferrer&quot;&gt;https://github.com/SonarSource/SonarJS/pull/1183/files&lt;/a&gt;&lt;/p&gt;</comment>
                                                            <comment id="196016" author="61cd0ca0bce5e00069e98be7" created="Wed, 27 Feb 2019 06:43:37 +0000"  >&lt;p&gt;Thanks Aliaksei for adding the test code.&lt;/p&gt;

&lt;p&gt;Regarding that SonarJS update mentioned above. I reckon that that is a separate issue. I presume that you are referring to the messages that we see in our Jenkins output for the Sonar stage, regarding &quot;espree&quot;.&lt;/p&gt;

&lt;p&gt;Now i am not sure of this (&lt;a href=&quot;https://folio-org.atlassian.net/secure/ViewProfile.jspa?accountId=5f9abc1eb45b2e007453f423&quot; class=&quot;user-hover&quot; rel=&quot;5f9abc1eb45b2e007453f423&quot; data-account-id=&quot;5f9abc1eb45b2e007453f423&quot; accountid=&quot;5f9abc1eb45b2e007453f423&quot; rel=&quot;noreferrer&quot;&gt;John Malconian&lt;/a&gt; please correct) but i gather that we use &lt;a href=&quot;https://github.com/SonarSource/sonar-scanner-jenkins&quot; class=&quot;external-link&quot; rel=&quot;nofollow noreferrer&quot;&gt;https://github.com/SonarSource/sonar-scanner-jenkins&lt;/a&gt; (which may include that).&lt;/p&gt;</comment>
                                                            <comment id="196018" author="61cd0ca0bce5e00069e98be7" created="Wed, 27 Feb 2019 06:45:40 +0000"  >&lt;p&gt;Back to this 
    &lt;span class=&quot;jira-issue-macro resolved&quot; data-jira-key=&quot;FOLIO-1818&quot; &gt;
                &lt;a href=&quot;https://folio-org.atlassian.net/browse/FOLIO-1818&quot; class=&quot;jira-issue-macro-key issue-link&quot;  title=&quot;Sonar analysis &amp;quot;coverage on new code&amp;quot; for PRs of NPM-based repos not happening recently&quot; &gt;
            &lt;img class=&quot;icon&quot; src=&quot;https://folio-org.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10303?size=medium&quot; /&gt;
            FOLIO-1818
        &lt;/a&gt;
                                                    &lt;span class=&quot;aui-lozenge aui-lozenge-subtle aui-lozenge-success jira-macro-single-issue-export-pdf&quot;&gt;Closed&lt;/span&gt;
            &lt;/span&gt;
. I needed to update my code in jenkins-pipeline-libs for a silly mistake.&lt;/p&gt;

&lt;p&gt;There is a new PR that tests this: &lt;a href=&quot;https://github.com/folio-org/ui-orders/pull/276&quot; class=&quot;external-link&quot; rel=&quot;nofollow noreferrer&quot;&gt;https://github.com/folio-org/ui-orders/pull/276&lt;/a&gt;&lt;br/&gt;
and hooray, it works.&lt;/p&gt;

&lt;p&gt;The &quot;new code coverage&quot; summary is reported to the PR Checks tab, and the SonarCloud report is as expected for the PR build as well as the branch build.&lt;/p&gt;

&lt;p&gt;So this 
    &lt;span class=&quot;jira-issue-macro resolved&quot; data-jira-key=&quot;FOLIO-1818&quot; &gt;
                &lt;a href=&quot;https://folio-org.atlassian.net/browse/FOLIO-1818&quot; class=&quot;jira-issue-macro-key issue-link&quot;  title=&quot;Sonar analysis &amp;quot;coverage on new code&amp;quot; for PRs of NPM-based repos not happening recently&quot; &gt;
            &lt;img class=&quot;icon&quot; src=&quot;https://folio-org.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10303?size=medium&quot; /&gt;
            FOLIO-1818
        &lt;/a&gt;
                                                    &lt;span class=&quot;aui-lozenge aui-lozenge-subtle aui-lozenge-success jira-macro-single-issue-export-pdf&quot;&gt;Closed&lt;/span&gt;
            &lt;/span&gt;
 is now &quot;In code review&quot; and this PR is ready to merge: &lt;br/&gt;
&lt;a href=&quot;https://github.com/folio-org/jenkins-pipeline-libs/pull/59&quot; class=&quot;external-link&quot; rel=&quot;nofollow noreferrer&quot;&gt;https://github.com/folio-org/jenkins-pipeline-libs/pull/59&lt;/a&gt;&lt;/p&gt;</comment>
                                                            <comment id="196019" author="61cd0ca0bce5e00069e98be7" created="Thu, 28 Feb 2019 05:07:06 +0000"  >&lt;p&gt;Closed.&lt;/p&gt;

&lt;p&gt;After merging jenkins-pipeline-libs/pull/59 and restoring the Jenkinsfile in the test PR ui-orders/pull/276 now the Sonar new code coverage report is updated on the Checks tab.&lt;/p&gt;</comment>
                                                            <comment id="196021" author="557058:09292aa8-9d37-482b-b244-17349bbbf497" created="Thu, 28 Feb 2019 10:13:31 +0000"  >&lt;p&gt;&lt;a href=&quot;https://folio-org.atlassian.net/secure/ViewProfile.jspa?accountId=61cd0ca0bce5e00069e98be7&quot; class=&quot;user-hover&quot; rel=&quot;61cd0ca0bce5e00069e98be7&quot; data-account-id=&quot;61cd0ca0bce5e00069e98be7&quot; accountid=&quot;61cd0ca0bce5e00069e98be7&quot; rel=&quot;noreferrer&quot;&gt;David Crossley&lt;/a&gt; Thanks a lot from all ui-modules teams!&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10000" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummarycf">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10057" key="com.atlassian.jira.plugin.system.customfieldtypes:select">
                        <customfieldname>Development Team</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10144"><![CDATA[Core: Platform]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10019" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|hzzg6v:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10020" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="1148">Core: Platform - Sprint 58</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10044" key="com.atlassian.jira.plugin.system.customfieldtypes:float">
                        <customfieldname>Story Points</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10024" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>[CHART] Date of First Response</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Mon, 25 Feb 2019 11:11:57 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10025" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>[CHART] Time in Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>