<!-- 
RSS generated by JIRA (1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d) at Thu Feb 08 23:15:01 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary add field=key&field=summary to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>FOLIO Jira</title>
    <link>https://folio-org.atlassian.net</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>1001.0.0-SNAPSHOT</version>
        <build-number>100246</build-number>
        <build-date>07-02-2024</build-date>
    </build-info>

<item>
            <title>[FOLIO-1668] Decide upon a code review policy and/or guidance</title>
                <link>https://folio-org.atlassian.net/browse/FOLIO-1668</link>
                <project id="10290" key="FOLIO">FOLIO</project>
                    <description>&lt;p&gt;Given that contributions to FOLIO are coming from more teams and people&lt;br/&gt;
Then it could be useful to establish a shared consensus on what aspects to review during a code review&lt;/p&gt;

&lt;p&gt;I imagine in the future this may refer to the definition of done that the Technical Council have been working on.&lt;/p&gt;</description>
                <environment></environment>
        <key id="81006">FOLIO-1668</key>
            <summary>Decide upon a code review policy and/or guidance</summary>
                <type id="10003" iconUrl="https://folio-org.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10318?size=medium">Task</type>
                                            <priority id="10002" iconUrl="https://dev.folio.org/assets/jira-priority/jira-p3.svg">P3</priority>
                        <status id="6" iconUrl="https://folio-org.atlassian.net/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10000">Won&apos;t Do</resolution>
                                                        <assignee accountid="557058:b8e64633-1f7c-402d-9caf-9959a5ba5d0d">Jakub Skoczen</assignee>
                                                                <reporter accountid="63e2a2771b13d42998e4e706">Marc Johnson</reporter>
                                    <labels>
                            <label>potential-decision</label>
                    </labels>
                <created>Fri, 21 Dec 2018 14:16:34 +0000</created>
                <updated>Wed, 25 Jan 2023 14:39:53 +0000</updated>
                            <resolved>Wed, 25 Jan 2023 14:39:53 +0000</resolved>
                                                                        <due></due>
                            <votes>0</votes>
                                    <watches>1</watches>
                                                                <comments>
                                                            <comment id="193469" author="63e2a2771b13d42998e4e706" created="Fri, 21 Dec 2018 14:19:55 +0000"  >&lt;p&gt;The check list I currently use is as follows (it predates the definition of done and so does not reflect that, and coverage varies significantly by module so I treat on a per change basis).&lt;/p&gt;


&lt;ul&gt;
	&lt;li&gt;Do the changes meet the intended purpose described in the feature or story?&lt;/li&gt;
	&lt;li&gt;Is it up to date with master, either via a merge into the branch or a rebase (can it be straight auto-merged)?
	&lt;ul&gt;
		&lt;li&gt;Do the tests pass?&lt;/li&gt;
	&lt;/ul&gt;
	&lt;/li&gt;
	&lt;li&gt;Do the tests reflect the changes?
	&lt;ul&gt;
		&lt;li&gt;Do the tests reflect scenarios described in the story or feature?&lt;/li&gt;
		&lt;li&gt;Doe the tests reflect common failure or validation scenarios?&lt;/li&gt;
	&lt;/ul&gt;
	&lt;/li&gt;
	&lt;li&gt;Are there up to date examples in the JSON.schema?&lt;/li&gt;
	&lt;li&gt;Do the RAML and JSON.schema pass checks (e.g. RAMLCop)?&lt;/li&gt;
	&lt;li&gt;Is there sample data (particularly for (fixed) controlled vocabularies)?&lt;/li&gt;
	&lt;li&gt;Has the implementation version been updated (Did the behaviour change)?
	&lt;ul&gt;
		&lt;li&gt;In the maven pom.xml (or similar)&lt;/li&gt;
	&lt;/ul&gt;
	&lt;/li&gt;
	&lt;li&gt;Has the interface version been updated (Did the client protocol change)?
	&lt;ul&gt;
		&lt;li&gt;In the module descriptor&lt;/li&gt;
		&lt;li&gt;In the interface definition&lt;/li&gt;
	&lt;/ul&gt;
	&lt;/li&gt;
	&lt;li&gt;Does the module descriptor expose the right interfaces and dependencies?&lt;/li&gt;
	&lt;li&gt;Are the dependent interface versions provided by another module?&lt;/li&gt;
	&lt;li&gt;Are the correct module permissions expressed on each endpoint?&lt;/li&gt;
	&lt;li&gt;Are the correct permissions expressed on each endpoint?&lt;/li&gt;
	&lt;li&gt;Are all of the permissions defined?&lt;/li&gt;
	&lt;li&gt;Are all of the permissions in the &#8220;all&#8221; set?&lt;/li&gt;
	&lt;li&gt;SonarQube metrics&lt;/li&gt;
	&lt;li&gt;Does the JIRA issue have the correct
	&lt;ul&gt;
		&lt;li&gt;project&lt;/li&gt;
		&lt;li&gt;fix version&lt;/li&gt;
	&lt;/ul&gt;
	&lt;/li&gt;
	&lt;li&gt;Do the commit messages have issue reference?&lt;/li&gt;
	&lt;li&gt;Are there any snapshot dependencies (for backend modules)?&lt;/li&gt;
&lt;/ul&gt;
</comment>
                    </comments>
                    <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10000" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummarycf">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10019" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|hzz9sn:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10020" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10025" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>[CHART] Time in Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>