<!-- 
RSS generated by JIRA (1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d) at Thu Feb 08 23:14:39 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary add field=key&field=summary to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>FOLIO Jira</title>
    <link>https://folio-org.atlassian.net</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>1001.0.0-SNAPSHOT</version>
        <build-number>100246</build-number>
        <build-date>07-02-2024</build-date>
    </build-info>

<item>
            <title>[FOLIO-1618] Update existing Nightmare tests to support coverage</title>
                <link>https://folio-org.atlassian.net/browse/FOLIO-1618</link>
                <project id="10290" key="FOLIO">FOLIO</project>
                    <description>&lt;p&gt;**&lt;b&gt;Note: We should selectively update a couple modules and verify results before rolling this out to all.&lt;/b&gt;**&lt;/p&gt;


&lt;p&gt;Update nightmare tests in ui-modules and platforms to use the pattern outlined in ui-users.  This change will allow for enabling of code coverage enabled by 
    &lt;span class=&quot;jira-issue-macro resolved&quot; data-jira-key=&quot;UITEST-39&quot; &gt;
                &lt;a href=&quot;https://folio-org.atlassian.net/browse/UITEST-39&quot; class=&quot;jira-issue-macro-key issue-link&quot;  title=&quot;Add coverage functionality to stripes-testing method&quot; &gt;
            &lt;img class=&quot;icon&quot; src=&quot;https://folio-org.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10309?size=medium&quot; /&gt;
            UITEST-39
        &lt;/a&gt;
                                                    &lt;span class=&quot;aui-lozenge aui-lozenge-subtle aui-lozenge-success jira-macro-single-issue-export-pdf&quot;&gt;Closed&lt;/span&gt;
            &lt;/span&gt;
 and demonstrated in 
    &lt;span class=&quot;jira-issue-macro&quot; data-jira-key=&quot;UIU-570&quot; &gt;
                &lt;a href=&quot;https://folio-org.atlassian.net/browse/UIU-570&quot; class=&quot;jira-issue-macro-key issue-link&quot;  title=&quot;Update make compatible with coverage changes to ui-testing and stripes cli&quot; &gt;
            &lt;img class=&quot;icon&quot; src=&quot;https://folio-org.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10309?size=medium&quot; /&gt;
            UIU-570
        &lt;/a&gt;
                                                    &lt;span class=&quot;aui-lozenge aui-lozenge-subtle aui-lozenge-complete jira-macro-single-issue-export-pdf&quot;&gt;Open&lt;/span&gt;
            &lt;/span&gt;
.&lt;/p&gt;

&lt;p&gt;The main change is to accept a Nightmare object instantiated outside of the test, rather than creating a new one within each test.&lt;/p&gt;

&lt;p&gt;For example, from this:&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
module.exports.test = function myTests(uiTestCtx) {
  describe(&lt;span class=&quot;code-quote&quot;&gt;&apos;Example&apos;&lt;/span&gt;, function () {
    &lt;span class=&quot;code-keyword&quot;&gt;const&lt;/span&gt; nightmare = &lt;span class=&quot;code-keyword&quot;&gt;new&lt;/span&gt; Nightmare(config.nightmare);
    nightmare.foo()
    &lt;span class=&quot;code-comment&quot;&gt;//...
&lt;/span&gt;  }
}
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;To this:&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
module.exports.test = function myTests(uiTestCtx, nightmare) {
  describe(&lt;span class=&quot;code-quote&quot;&gt;&apos;Example&apos;&lt;/span&gt;, function () {
    nightmare.foo()
    &lt;span class=&quot;code-comment&quot;&gt;//...
&lt;/span&gt;  }
}
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;Also remove any direct calls to &lt;b&gt;&lt;tt&gt;.end()&lt;/tt&gt;&lt;/b&gt; on the Nightmare instance within tests. End will be called on the shared instance after all tests are run.  This includes use of the &lt;tt&gt;logout()&lt;/tt&gt; helper method which internally calls end.  A new helper method, &lt;tt&gt;logoutWithoutEnd()&lt;/tt&gt; has been created to accommodate the transition.&lt;/p&gt;

&lt;p&gt;Example, from this:&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
&lt;span class=&quot;code-keyword&quot;&gt;const&lt;/span&gt; { helpers: { login, logout } } = uiTestCtx;
&lt;span class=&quot;code-comment&quot;&gt;//...
&lt;/span&gt;after( function (done) {
  logout(nightmare, config, done);
});
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;To this:&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
&lt;span class=&quot;code-keyword&quot;&gt;const&lt;/span&gt; { helpers: { login, logoutWithoutEnd } } = uiTestCtx;
&lt;span class=&quot;code-comment&quot;&gt;//...
&lt;/span&gt;after( function (done) {
  logoutWithoutEnd(nightmare, config, done);
});
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;Finally, although not required, this may be a good opportunity to review and replace our use of arrow functions for the Mocha test scaffolding (describe, it, before, after, etc).  Due to the lexically bound &lt;tt&gt;this&lt;/tt&gt; of the arrow function, access to Mohca&apos;s context is blocked and therefore &lt;a href=&quot;https://mochajs.org/#arrow-functions&quot; class=&quot;external-link&quot; rel=&quot;nofollow noreferrer&quot;&gt;not recommended&lt;/a&gt;.&lt;/p&gt;

&lt;p&gt;For example, rather than this:&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
it(&lt;span class=&quot;code-quote&quot;&gt;&apos;should &lt;span class=&quot;code-keyword&quot;&gt;do&lt;/span&gt; something&apos;&lt;/span&gt;, (done) =&amp;gt; {
  &lt;span class=&quot;code-comment&quot;&gt;// ...
&lt;/span&gt;}
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;Do this:&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
it(&lt;span class=&quot;code-quote&quot;&gt;&apos;should &lt;span class=&quot;code-keyword&quot;&gt;do&lt;/span&gt; something&apos;&lt;/span&gt;, function (done) {
  &lt;span class=&quot;code-comment&quot;&gt;// ...
&lt;/span&gt;}
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;</description>
                <environment></environment>
        <key id="80922">FOLIO-1618</key>
            <summary>Update existing Nightmare tests to support coverage</summary>
                <type id="10006" iconUrl="https://folio-org.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10307?size=medium">Umbrella</type>
                                            <priority id="10002" iconUrl="https://dev.folio.org/assets/jira-priority/jira-p3.svg">P3</priority>
                        <status id="6" iconUrl="https://folio-org.atlassian.net/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10000">Won&apos;t Do</resolution>
                                                        <assignee accountid="-1">Unassigned</assignee>
                                                                <reporter accountid="557058:624212b9-5938-4e3b-84c6-8c8a8db84996">Matthew Jones</reporter>
                                    <labels>
                    </labels>
                <created>Tue, 20 Nov 2018 15:48:12 +0000</created>
                <updated>Thu, 22 Oct 2020 19:53:18 +0000</updated>
                            <resolved>Thu, 22 Oct 2020 19:53:18 +0000</resolved>
                                                                        <due></due>
                            <votes>0</votes>
                                    <watches>4</watches>
                                                                <comments>
                                                            <comment id="193026" author="557058:624212b9-5938-4e3b-84c6-8c8a8db84996" created="Tue, 20 Nov 2018 16:49:10 +0000"  >&lt;p&gt;&lt;a href=&quot;https://folio-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ab8e64633-1f7c-402d-9caf-9959a5ba5d0d&quot; class=&quot;user-hover&quot; rel=&quot;557058:b8e64633-1f7c-402d-9caf-9959a5ba5d0d&quot; data-account-id=&quot;557058:b8e64633-1f7c-402d-9caf-9959a5ba5d0d&quot; accountid=&quot;557058:b8e64633-1f7c-402d-9caf-9959a5ba5d0d&quot; rel=&quot;noreferrer&quot;&gt;Jakub Skoczen&lt;/a&gt;, I have created and linked JIRA tasks for the modules and platforms which appear to have existing Nightmare tests written.  I recommend we trial the upgrade on a module or two before rolling out the change to all. This would give us a chance to update the instructions in this ticket with any issues encountered.  &lt;a href=&quot;https://folio-org.atlassian.net/secure/ViewProfile.jspa?accountId=615afd1cd9820f0070a09ef0&quot; class=&quot;user-hover&quot; rel=&quot;615afd1cd9820f0070a09ef0&quot; data-account-id=&quot;615afd1cd9820f0070a09ef0&quot; accountid=&quot;615afd1cd9820f0070a09ef0&quot; rel=&quot;noreferrer&quot;&gt;Zak Burke&lt;/a&gt; do you have a recommendation for a candidate module?  Perhaps one that has shown to be relatively stable recently.&lt;/p&gt;

&lt;p&gt;Also, there are more modules with Nightmare tests that I did not create tickets for.  However, they only have a placeholder tests (from creating a new ui-module via the CLI).  These others include platform-erm, ui-finance, ui-vendors, ui-receiving, ui-licenses, and ui-erm-usage.&lt;/p&gt;
</comment>
                                                            <comment id="193029" author="615afd1cd9820f0070a09ef0" created="Wed, 28 Nov 2018 19:05:38 +0000"  >&lt;p&gt;checkout, circulation, or organization are all relatively small and would be good candidates. &lt;/p&gt;</comment>
                                                            <comment id="193031" author="557058:b8e64633-1f7c-402d-9caf-9959a5ba5d0d" created="Mon, 10 Dec 2018 15:46:29 +0000"  >&lt;p&gt;&lt;a href=&quot;https://folio-org.atlassian.net/secure/ViewProfile.jspa?accountId=5f9abc1eb45b2e007453f423&quot; class=&quot;user-hover&quot; rel=&quot;5f9abc1eb45b2e007453f423&quot; data-account-id=&quot;5f9abc1eb45b2e007453f423&quot; accountid=&quot;5f9abc1eb45b2e007453f423&quot; rel=&quot;noreferrer&quot;&gt;John Malconian&lt;/a&gt; what needs to be done to integrate those coverage reports into the Jenkins runs?&lt;/p&gt;</comment>
                                                            <comment id="193032" author="615afd1cd9820f0070a09ef0" created="Sat, 15 Dec 2018 12:06:04 +0000"  >&lt;p&gt;In light of 
    &lt;span class=&quot;jira-issue-macro resolved&quot; data-jira-key=&quot;UIU-777&quot; &gt;
                &lt;a href=&quot;https://folio-org.atlassian.net/browse/UIU-777&quot; class=&quot;jira-issue-macro-key issue-link&quot;  title=&quot;integration tests fail when run as a suite&quot; &gt;
            &lt;img class=&quot;icon&quot; src=&quot;https://folio-org.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10303?size=medium&quot; /&gt;
            UIU-777
        &lt;/a&gt;
                                                    &lt;span class=&quot;aui-lozenge aui-lozenge-subtle aui-lozenge-success jira-macro-single-issue-export-pdf&quot;&gt;Closed&lt;/span&gt;
            &lt;/span&gt;
 and 
    &lt;span class=&quot;jira-issue-macro resolved&quot; data-jira-key=&quot;FOLIO-1660&quot; &gt;
                &lt;a href=&quot;https://folio-org.atlassian.net/browse/FOLIO-1660&quot; class=&quot;jira-issue-macro-key issue-link&quot;  title=&quot;platform-core tests fail as a suite&quot; &gt;
            &lt;img class=&quot;icon&quot; src=&quot;https://folio-org.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10303?size=medium&quot; /&gt;
            FOLIO-1660
        &lt;/a&gt;
                                                    &lt;span class=&quot;aui-lozenge aui-lozenge-subtle aui-lozenge-success jira-macro-single-issue-export-pdf&quot;&gt;Closed&lt;/span&gt;
            &lt;/span&gt;
, I think this isn&apos;t ready to pursue at present. &lt;/p&gt;</comment>
                                                            <comment id="193034" author="62a96ae7192edb006f9f1bf9" created="Thu, 22 Oct 2020 19:53:18 +0000"  >&lt;p&gt;Moving to a new testing framework&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10003">
                    <name>Relates</name>
                                            <outwardlinks description="relates to">
                                        <issuelink>
            <issuekey id="80921">FOLIO-1619</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="80923">FOLIO-1620</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="71413">STCLI-118</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="65196">UICHKOUT-474</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="58590">UICIRC-111</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="47309">UIIN-392</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="25789">UIREQ-169</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="74845">UISE-92</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="71103">UITEN-25</issuekey>
        </issuelink>
                            </outwardlinks>
                                                                <inwardlinks description="relates to">
                                        <issuelink>
            <issuekey id="81000">FOLIO-1660</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="44899">UIU-777</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="80892">FOLIO-1602</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="36941">UITEST-39</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10000" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummarycf">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10057" key="com.atlassian.jira.plugin.system.customfieldtypes:select">
                        <customfieldname>Development Team</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10144"><![CDATA[Core: Platform]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10019" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|hzz6e7:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10020" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10024" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>[CHART] Date of First Response</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Wed, 28 Nov 2018 19:05:38 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10025" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>[CHART] Time in Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>