<!-- 
RSS generated by JIRA (1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d) at Thu Feb 08 23:12:35 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary add field=key&field=summary to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>FOLIO Jira</title>
    <link>https://folio-org.atlassian.net</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>1001.0.0-SNAPSHOT</version>
        <build-number>100246</build-number>
        <build-date>07-02-2024</build-date>
    </build-info>

<item>
            <title>[FOLIO-1333] Loan policy name with space in it cannot be added to a loan rule</title>
                <link>https://folio-org.atlassian.net/browse/FOLIO-1333</link>
                <project id="10290" key="FOLIO">FOLIO</project>
                    <description>&lt;p&gt;&lt;b&gt;Overview&lt;/b&gt;: Users can create loan policies that have a space in the name of the loan policy, but then when trying to put into a loan rule, the space causes a problem.&lt;/p&gt;

&lt;p&gt;&lt;b&gt;Steps to Reproduce&lt;/b&gt;:&lt;/p&gt;
&lt;ol&gt;
	&lt;li&gt;Log into FOLIO-snapshot-stable as diku_admin&lt;/li&gt;
	&lt;li&gt;Go to settings/circulation/loan policies&lt;/li&gt;
	&lt;li&gt;Create a new loan policy that has a space in its name (e.g. new policy, or regular loan)&lt;/li&gt;
	&lt;li&gt;Once you&apos;ve saved the new loan policy, then go to Loan rules, and change the book policy to the new loan policy by typing it (not by clicking it).&lt;/li&gt;
&lt;/ol&gt;


&lt;p&gt;&lt;b&gt;Expected Results&lt;/b&gt;: When you get to the space, it should accept that space as part of the loan policy name. Alternatively, when you build the loan policy, if you try to type a space, it should disallow the space, either throwing an error message, or replacing with a hyphen, or something.&lt;/p&gt;

&lt;p&gt;&lt;b&gt;Actual Results&lt;/b&gt;: I could build a loan policy with a space in its name. I could not assign that loan policy with a space into a loan rule.&lt;/p&gt;

&lt;p&gt;&lt;b&gt;Additional Information&lt;/b&gt;: See attached video.&lt;/p&gt;
</description>
                <environment></environment>
        <key id="80685">FOLIO-1333</key>
            <summary>Loan policy name with space in it cannot be added to a loan rule</summary>
                <type id="10001" iconUrl="https://folio-org.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10303?size=medium">Bug</type>
                                            <priority id="10002" iconUrl="https://dev.folio.org/assets/jira-priority/jira-p3.svg">P3</priority>
                        <status id="6" iconUrl="https://folio-org.atlassian.net/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10000">Won&apos;t Do</resolution>
                                                        <assignee accountid="-1">Unassigned</assignee>
                                                                <reporter accountid="5af5e627525ba96b58654f12">Ann-Marie Breaux</reporter>
                                    <labels>
                    </labels>
                <created>Mon, 9 Jul 2018 19:58:44 +0000</created>
                <updated>Mon, 12 Nov 2018 14:24:48 +0000</updated>
                            <resolved>Tue, 21 Aug 2018 07:03:11 +0000</resolved>
                                                                        <due></due>
                            <votes>0</votes>
                                    <watches>2</watches>
                                                                <comments>
                                                            <comment id="194171" author="5af5ed55244bc90a106063c7" created="Tue, 17 Jul 2018 08:51:55 +0000"  >&lt;p&gt;&lt;a href=&quot;https://folio-org.atlassian.net/secure/ViewProfile.jspa?accountId=5ee89462f7aa140abd82d11d&quot; class=&quot;user-hover&quot; rel=&quot;5ee89462f7aa140abd82d11d&quot; data-account-id=&quot;5ee89462f7aa140abd82d11d&quot; accountid=&quot;5ee89462f7aa140abd82d11d&quot; rel=&quot;noreferrer&quot;&gt;Julian Ladisch&lt;/a&gt;, is there some reason we can&apos;t have loan policies with spaces?  &lt;/p&gt;</comment>
                                                            <comment id="194173" author="5ee89462f7aa140abd82d11d" created="Tue, 17 Jul 2018 09:09:08 +0000"  >&lt;p&gt;Space is the name separator.&lt;br/&gt;
Example from &lt;a href=&quot;https://discuss.folio.org/t/loan-rules-ux-iteration-4/834&quot; class=&quot;external-link&quot; rel=&quot;nofollow noreferrer&quot;&gt;https://discuss.folio.org/t/loan-rules-ux-iteration-4/834&lt;/a&gt; at 2:30:&lt;br/&gt;
&lt;tt&gt;g undergrad grad + m book : policy-x&lt;/tt&gt;&lt;/p&gt;

&lt;p&gt;&lt;tt&gt;undergrad grad&lt;/tt&gt; are two space separated group names.&lt;/p&gt;

&lt;p&gt;&lt;tt&gt;g a b c&lt;/tt&gt; could be a single group &quot;a b c&quot;, the two groups &quot;a&quot; and &quot;b c&quot;, the two groups &quot;a b&quot; and &quot;c&quot;, or three groups &quot;a&quot;, &quot;b&quot; and &quot;c&quot;.&lt;/p&gt;

&lt;p&gt;If we want to allow spaces we must require quotes around space-containing names to show the start and end of the name. For example:&lt;/p&gt;

&lt;p&gt;&lt;tt&gt;g &quot;a b c&quot;&lt;/tt&gt; is a single group &quot;a b c&quot;.&lt;br/&gt;
&lt;tt&gt;g &quot;a b&quot; c&lt;/tt&gt; are two groups, &quot;a b&quot; and &quot;c&quot;.&lt;/p&gt;</comment>
                                                            <comment id="194175" author="5af5ed55244bc90a106063c7" created="Tue, 17 Jul 2018 11:40:02 +0000"  >&lt;p&gt;I see...  Does that mean we have the same tradeoff with Loan types, Material types, Locations and Patron groups?  Either disallow spaces or require quotes in the loan rules?  I don&apos;t think disallowing spaces is going to appeal to people.  Could we use a different separator in Loan rules?  Maybe a comma?&lt;/p&gt;</comment>
                                                            <comment id="194177" author="5ee89462f7aa140abd82d11d" created="Tue, 17 Jul 2018 12:54:26 +0000"  >&lt;p&gt;Yes, loan types, material types, locations and patrons groups all have the same requirement regarding forbidden characters.&lt;/p&gt;

&lt;p&gt;There are four characters that are forbidden in names (unless quoted):&lt;/p&gt;
&lt;ul&gt;
	&lt;li&gt;Colon :&lt;/li&gt;
	&lt;li&gt;Plus +&lt;/li&gt;
	&lt;li&gt;Exclamation mark !&lt;/li&gt;
	&lt;li&gt;Space (or any other separator like comma used between names in a name list)&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;In addition &quot;all&quot; is a special keyword that cannot be used as a name unless quoted.&lt;/p&gt;

&lt;p&gt;Using comma instead of space inside name lists make the rule more difficult to read:&lt;br/&gt;
Using space: &lt;tt&gt;g undergrad grad + m book dvd : policy-x&lt;/tt&gt;&lt;br/&gt;
Using comma: &lt;tt&gt;g undergrad, grad + m book, dvd : policy-x&lt;/tt&gt; looks like &lt;tt&gt;grad + m book&lt;/tt&gt; is one expression&lt;/p&gt;</comment>
                                                            <comment id="194178" author="5af5ed55244bc90a106063c7" created="Tue, 17 Jul 2018 13:09:16 +0000"  >&lt;p&gt;Hmmm.  I see your point about readability with commas, &lt;a href=&quot;https://folio-org.atlassian.net/secure/ViewProfile.jspa?accountId=5ee89462f7aa140abd82d11d&quot; class=&quot;user-hover&quot; rel=&quot;5ee89462f7aa140abd82d11d&quot; data-account-id=&quot;5ee89462f7aa140abd82d11d&quot; accountid=&quot;5ee89462f7aa140abd82d11d&quot; rel=&quot;noreferrer&quot;&gt;Julian Ladisch&lt;/a&gt;.  &lt;/p&gt;

&lt;p&gt;So, let me be sure I understand, our other options:&lt;/p&gt;
&lt;ol&gt;
	&lt;li&gt;Only create policies, patron groups etc without spaces such as One_hour_loan and Video_recording so the loan rules can look like:&lt;br/&gt;
g Undergraduate_student Graduate_student + m Video_recording DVD : One_hour_loan&lt;/li&gt;
	&lt;li&gt;Create  policies, patron groups etc with spaces, but then surround them with quotation marks when creating loan rules such as:&lt;br/&gt;
g &quot;Undergraduate student&quot; &quot;Graduate student&quot; + m &quot;Video recording&quot; DVD : &quot;One hour loan&quot;&lt;/li&gt;
&lt;/ol&gt;


&lt;p&gt;Honestly, I am not sure either of those are more readable than using a comma separator.  Let&apos;s try the comma separator with the same values by way of comparison:&lt;br/&gt;
g Undergraduate student, Graduate student + m Video recording, DVD : One hour loan&lt;/p&gt;

&lt;p&gt;Yeah, I like the comma separator better in this case.  &lt;a href=&quot;https://folio-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1478fca5-561e-4056-ba78-c61611cb23e9&quot; class=&quot;user-hover&quot; rel=&quot;557058:1478fca5-561e-4056-ba78-c61611cb23e9&quot; data-account-id=&quot;557058:1478fca5-561e-4056-ba78-c61611cb23e9&quot; accountid=&quot;557058:1478fca5-561e-4056-ba78-c61611cb23e9&quot; rel=&quot;noreferrer&quot;&gt;Filip Jakobsen&lt;/a&gt; do you have thoughts on this?&lt;/p&gt;</comment>
                                                            <comment id="194179" author="557058:1478fca5-561e-4056-ba78-c61611cb23e9" created="Tue, 17 Jul 2018 15:14:10 +0000"  >&lt;p&gt;&lt;a href=&quot;https://folio-org.atlassian.net/secure/ViewProfile.jspa?accountId=5af5ed55244bc90a106063c7&quot; class=&quot;user-hover&quot; rel=&quot;5af5ed55244bc90a106063c7&quot; data-account-id=&quot;5af5ed55244bc90a106063c7&quot; accountid=&quot;5af5ed55244bc90a106063c7&quot; rel=&quot;noreferrer&quot;&gt;Cate Boerema&lt;/a&gt;, I think both approach 1 and 2 could work. 1 is less prone to error and 2 is easier to read. I would recommend 1 off hand, and (we should do this no matter what) have a human readable version of the loan policy name, as well as a slug version (unambiguous, short, without spaces - e.g. the technical name &#8220;grad&#8221; or &#8220;graduate&#8221; or &#8220;graduate-student&#8221;, for the loan policy with this human readable name &#8220;Graduate Student&#8221;). I suggest the technical name be generated automatically when entering a human readable name, replacing space for dash, e.g. and that the technical name should still be manually editable.&lt;/p&gt;

&lt;p&gt;I think the comma separator suggestion is only meaningful when we try to remedy the problems caused by not using approach 1 or 2, and that it doesn&#8217;t get to the heart of the issue: using a comma instead would bring some ambiguity, and it would mean people should be prevented from using conmas instead of spaces in the technical names. I can imagine someone wanting to name things like this for human readability: &#8220;Student, undergraduate&#8221; - &#8220;Student, graduate&#8221; - &#8220;Student, xyz&#8221;.&lt;/p&gt;

&lt;p&gt;In any of these cases, I think it is optimal if people can name the loan type whatever they want in the human readable name field, but would be forced to not use spaces or any punctuation at all in the technical name field. To make it unambiguous.&lt;/p&gt;</comment>
                                                            <comment id="194180" author="5af5ed55244bc90a106063c7" created="Tue, 17 Jul 2018 15:32:08 +0000"  >&lt;p&gt;I guess we disagree here, &lt;a href=&quot;https://folio-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1478fca5-561e-4056-ba78-c61611cb23e9&quot; class=&quot;user-hover&quot; rel=&quot;557058:1478fca5-561e-4056-ba78-c61611cb23e9&quot; data-account-id=&quot;557058:1478fca5-561e-4056-ba78-c61611cb23e9&quot; accountid=&quot;557058:1478fca5-561e-4056-ba78-c61611cb23e9&quot; rel=&quot;noreferrer&quot;&gt;Filip Jakobsen&lt;/a&gt;.  I find option 1 difficult to read and I would be annoyed to have to type properties into the loan rules app in this way.  I also think adding functionality to auto-generate editable &quot;slug versions&quot; of all of these properties would be significantly more work than just disallowing the use of commas in property names.  &lt;/p&gt;
</comment>
                                                            <comment id="194181" author="5af5e627525ba96b58654f12" created="Tue, 17 Jul 2018 15:38:24 +0000"  >&lt;p&gt;Hi all, Not sure if this is helpful, but I realized when I typed a loan policy name like &lt;b&gt;test policy,&lt;/b&gt; behind the scenes, FOLIO was changing it into &lt;b&gt;test-policy&lt;/b&gt;, with a hyphen instead of a space. Might that be a reasonable thing to do? If someone types a space, disallow it and replace it with a hyphen in both the UI display (as they are typing) and in the stored name of the loan policy? We already seem to be doing it with the stored name of the policy. We would just need to make the data entry portion of the UI match what&apos;s happening behind the scenes.&lt;/p&gt;</comment>
                                                            <comment id="194182" author="5ee89462f7aa140abd82d11d" created="Tue, 17 Jul 2018 16:04:23 +0000"  >&lt;p&gt;Note that we may implement both options 1 and 2 so that staff can decide which option to use. And the options even can be combined, for example:&lt;/p&gt;

&lt;p&gt;g Undergraduate_student Graduate_student + m &quot;Video recording&quot; DVD : &quot;One hour loan&quot;&lt;/p&gt;</comment>
                                                            <comment id="194183" author="5af5ed55244bc90a106063c7" created="Tue, 17 Jul 2018 16:28:43 +0000"  >&lt;blockquote&gt;&lt;p&gt;Hi all, Not sure if this is helpful, but I realized when I typed a loan policy name like test policy, behind the scenes, FOLIO was changing it into test-policy, with a hyphen instead of a space. Might that be a reasonable thing to do? If someone types a space, disallow it and replace it with a hyphen in both the UI display (as they are typing) and in the stored name of the loan policy? We already seem to be doing it with the stored name of the policy. We would just need to make the data entry portion of the UI match what&apos;s happening behind the scenes.&lt;/p&gt;&lt;/blockquote&gt;

&lt;p&gt;I didn&apos;t realize it was doing this and I like it as a simple solution!  I see this is happening for material types, as well (e.g. Electronic resources becomes electronic-resources just in Loan rules).&lt;/p&gt;

&lt;p&gt;Is this a recent change?  I can&apos;t really jive this behavior with the bug description.  Anyway, I like it.  &lt;/p&gt;

&lt;p&gt;&lt;a href=&quot;https://folio-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1478fca5-561e-4056-ba78-c61611cb23e9&quot; class=&quot;user-hover&quot; rel=&quot;557058:1478fca5-561e-4056-ba78-c61611cb23e9&quot; data-account-id=&quot;557058:1478fca5-561e-4056-ba78-c61611cb23e9&quot; accountid=&quot;557058:1478fca5-561e-4056-ba78-c61611cb23e9&quot; rel=&quot;noreferrer&quot;&gt;Filip Jakobsen&lt;/a&gt;, can you live with this for now?&lt;/p&gt;</comment>
                                                            <comment id="194184" author="5af5ed55244bc90a106063c7" created="Tue, 21 Aug 2018 07:02:57 +0000"  >&lt;p&gt;Per comment above, current behavior seems acceptable.  Closing this issue.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10003">
                    <name>Relates</name>
                                            <outwardlinks description="relates to">
                                        <issuelink>
            <issuekey id="47394">CIRC-127</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                    </issuelinks>
                <attachments>
                            <attachment id="64074" name="Loan Policy-Rule non-alignment.mp4" size="3401688" author="5af5e627525ba96b58654f12" created="Mon, 9 Jul 2018 19:59:10 +0000"/>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10000" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummarycf">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10019" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|hzypcf:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10020" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10024" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>[CHART] Date of First Response</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Tue, 17 Jul 2018 08:51:55 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10025" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>[CHART] Time in Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>