|
#release_bug_triage Slack conversation:
Zak Burke: @hollyolepm, I have some concerns about how the “Shared” fee/fine owner concept has been modeled.
Specifically, tying business logic to a user-editable field (owner.name) seems dangerous; somebody could change the name to “Common Owner” or even “shared” (the current logic is case-sensitive) and unwittingly break things. Likewise, this will fail in any non-English environment when the tenant translates this owner-name to its own locale.
Could “shared” be a boolean attribute of an owner? This would allow any number of owners to be shared, and would be locale independent.
Holly Mistlebauer: @zburke, we actually planned for the Fee/Fine Owner table to be pre-populated with a Shared fee/fine owner that was uneditable. We haven't finished that part. I thought doing this would make the shareable feature obvious (given our lack of user documentation). Of course having an attribute would do the same thing, plus institutions could call it what they want and they wouldn't have an unused fee/fine owner in the table in case they didn't want to have shared fees/fines. I do think there should only be one shared set of fees/fines. At least for now. Thanks for the suggestion!
Zak Burke: Right, so, implement the is-shared attribute such that it can only be applied to a single owner.
|