[UITEN-166] Hide or fix the permissions related to Tenant Settings Created: 09/Feb/21  Updated: 12/Mar/21  Resolved: 12/Mar/21

Status: Closed
Project: ui-tenant-settings
Components: None
Affects versions: None
Fix versions: None

Type: Bug Priority: P2
Reporter: Ann-Marie Breaux (Inactive) Assignee: Michal Kuklis
Resolution: Done Votes: 0
Labels: permissions
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Attachments: PNG File SetttingsTenant-Display list of pages.PNG     PNG File UI-Tenant Settings Module enabled.PNG    
Issue links:
Blocks
blocks UITEN-157 UITEN (ui-tenant-settings) v6.0.0 rel... Closed
Cloners
clones UISE-139 Hide or fix the permissions related t... Closed
Gantt End to Start
has to be done before UITEN-157 UITEN (ui-tenant-settings) v6.0.0 rel... Closed
Relates
relates to UITEN-167 Introduce a new view permission for s... Closed
Sprint: Prokopovych - Sprint 109
Development Team: Prokopovych
Release: R1 2021
Tester Assignee: Ann-Marie Breaux (Inactive)

 Description   

Purpose: To hide or update the UI permissions related to Tenant Settings

As a user assigning permissions to other users
I want understandable permissions for the tenant settings
so that I can figure out if I want to assign to a user or not

Scenarios:

  1. Scenario:1
    • Given the permissions UI in the Users app
    • When viewing the permission with UI name Settings (tenant): Display list of settings pages
    • Then change the UI name to Settings (Tenant): View
    • And ensure that when this permission is assigned to a User, the user can view, but not create/update/delete all settings within the Settings/Tenant ( area (this portion moved to UITEN-167 Closed )
    • NOTE: Currently, when this is the only permission assigned to a user, the Settings/Tenant area displays, but no settings are actually visible. See attached screenshot this will not change until UITEN-178 Closed is implemented
  2. Scenario:2
    • Given the permissions UI in the Users app
    • When viewing the permission with UI name UI: Tenant-settings module is enabled
    • Then suppress this permission from UI display (since the permission in scenario 1 should do the same thing as this permission)
    • NOTE: Currently, when this is the only permission assigned to a user, no apps app display. See attached screenshot


 Comments   
Comment by Holly Mistlebauer [ 08/Mar/21 ]

Question from Zak on Slack...

"This likely involves translation updates. Normally we only touch the en.js file, but here I think I would update en_US.js and all the other en*.js_ files. Are there any non-English deployments that will use this release? If so, we need to coordinate with @peter-murray to get this change out to Lokalise and then back into GitHub as well."   

Answer from Peter Murray on Slack...

"Anything that is done in the English language to en.js is automatically copied to en_US.js, so I don't think they need to do anything.  (If they need to ask for an emergency push from Lokalise to GitHub, they can do that. It happens occasionally.)"

Comment by Holly Mistlebauer [ 08/Mar/21 ]

Zak Burke:  I have added the comment above in response to your question about coordinating with Peter, etc.  Please contact Peter if you have further questions.  Thanks...

Comment by Zak Burke [ 08/Mar/21 ]

...And ensure that when this permission is assigned to a User, the user can view, but not create/update/delete all settings within the Settings/Tenant area

Holly Mistlebauer, This is a bit involved as visibility of each setting (Address, Key bindings, etc.) is determined by specific permissions. Thus, the ability to "view ... all settings" actually entails several pieces of work:

  1. the creation of view-only permission sets for each setting
  2. update the index-page to look for the new view-only permission
  3. refactoring each settings page to provide a read-only view. in many cases this does not exist while writing it may be straightforward, it's not zero effort.

Only the last is significant, but it may be quite significant because some of these pages were not built with separate "read" and "update" views in mind (e.g. key bindings, language and localization, preferred plugins, SSO...)

Comment by Michal Kuklis [ 10/Mar/21 ]

The work on this should be now done without one requirement from scenario 1:

  • And ensure that when this permission is assigned to a User, the user can view, but not create/update/delete all settings within the Settings/Tenant area

This has been moved to a new JIRA: https://folio-org.atlassian.net/browse/UITEN-167

Comment by Ann-Marie Breaux (Inactive) [ 10/Mar/21 ]

Thanks Michal Kuklis Should UITEN-167 Closed also be assigned to Prokopovych?

Comment by Yelyzaveta Khokhlova [ 11/Mar/21 ]

Ann-Marie Breaux, should UITEN-167 Closed be included in R1 release as well?

Comment by Ann-Marie Breaux (Inactive) [ 11/Mar/21 ]

Hi Yelyzaveta Khokhlova If it's possible, that would be great. It sounds like UITEN-167 Closed will be more work than UITEN-166 Closed , so I'm not sure whether there's capacity

Comment by Ann-Marie Breaux (Inactive) [ 12/Mar/21 ]

Hi Michal Kuklis and Magda Zacharska tested on folio-snapshot. All is good. The settings screen is stil bare, but that won't change until UITEN-167 Closed is completed. Thank you!

Comment by Ann-Marie Breaux (Inactive) [ 12/Mar/21 ]

Magda Zacharska or Yelyzaveta Khokhlova we still need to confirm which team will do UITEN-167 Closed . I don't think it has to get done soon, but it would be good to assign to a team so that we don't lose track of it.

Generated at Thu Feb 08 23:24:54 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.