[UISE-78] Codex search results navigation problem 3: Reset All Not Working Created: 20/Mar/18  Updated: 07/Jun/18  Resolved: 07/Jun/18

Status: Closed
Project: ui-search
Components: None
Affects versions: None
Fix versions: None

Type: Bug Priority: P3
Reporter: Ann-Marie Breaux (Inactive) Assignee: Jeremy Huff
Resolution: Done Votes: 0
Labels: sprint34, sprint35, sprint36, sprint37, sprint38, sprint39
Remaining Estimate: Not Specified
Time Spent: 30 minutes
Original estimate: Not Specified

Attachments: File Codex Navigation Bug 3 - Reset All.mp4     JPEG File Codex Search after pressing Reset all.JPG     JPEG File Codex Search before inputting anything.JPG    
Issue links:
Blocks
is blocked by UITEST-26 expand the CS integration test to cov... Closed
Relates
relates to FOLIO-1149 Codex search results navigation probl... Closed
relates to FOLIO-1125 Codex search results navigation probl... Closed
Sprint:

 Description   

Overview: Reset all not working

Steps to Reproduce: See attached video Codex Navigation Bug 3 - Reset All.mp4. When I press reset all, my previous search results don't clear, and my next search doesn't seem to work properly.

Log into FOLIO Snapshot Stable as diku_admin
Go to Codex
Search for title Georgia and try to display all the results. Then press reset all.

Expected Results: The Georgia search results should clear back to a blank results screen, and I should be able to perform a new search.

Actual Results: The Georgia search results don't clear. And when I try a new search, I get odd results. I can't ever figure out how to get back to a completely blank reset starting point, short of closing FOLIO and coming back in.

Interested Parties:Cate Boerema



 Comments   
Comment by Jeremy Huff [ 12/Apr/18 ]

There seem to be two issues addressed here:

1) The clearing of results after the "Reset all" is clicked.
Given the current state of Folio Stable, Folio Testing and my localhost instance, I was unable to reproduce this.

and 2) The searching of additional content after the "Reset all" is clicked.
I believe the unexpected results occurred because when "Reset all" is clicked, the search field is changed from "Title" to "Search All Fields." If, after "Reset all" is clicked, the search field is changed back to "Title" then the search results are consistent with what one would expect.

Comment by Jeremy Huff [ 12/Apr/18 ]

I might mention, additionally, that it may be that "Search All Fields" does not return KB results because it is searching on some fields that are not present on eHoldings. I am not sure if this is known/desired behavior. Additionally, it may not be desirable for "Reset All" to change the field on the search box to "Search All Fields," since the codex view seems to default to "Title".

Comment by Mike Taylor [ 14/May/18 ]

(Note to self: take a quick look at this in case it turns out to be something I've seen before.)

Comment by Mike Taylor [ 15/May/18 ]

I might mention, additionally, that it may be that "Search All Fields" does not return KB results because it is searching on some fields that are not present on eHoldings.

Not quite. Instead, "Search All Fields" is simply not available when not in Local Inventory-only mode. See the code at https://github.com/folio-org/ui-search/blob/55691aaaf07d554b266db41b0458a40c8c965df7/src/Search.js#L88-L99 that sets "local only" on the "Search All Fields" index.

Comment by Ann-Marie Breaux (Inactive) [ 15/May/18 ]

It seems like there's still a problem though, Mike Taylor and Jeremy Huff. When I press Reset All, it should keep the type of search defaulted to Title, rather than changing it to Search All Fields. That won't make sense at all to a user, and will cause any subsequent search not to return any results. Reset All should change the Codex Search screen back to exactly what it looked like before I started typing or clicking anything. See attached screenshots for before and after I click the Reset all button.

Comment by Mike Taylor [ 19/May/18 ]

Agreed this is not elegant. (It's made worse by the way that the "Reset all" button vanishes when you press it, then pings back into existence the moment you do anything.)

I'm not likely to get to this in the next few days, being embroiled in a different part of the project. Is Jeremy around, or is this one of his non-FOLIO sprints? What's the urgency? Should we seek to reassign it elsewhere, or should it just wait until I'm free?

Generated at Thu Feb 08 23:11:12 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.