[UISE-110] Inventory/search bug in Q1 2019 release Created: 09/Apr/19  Updated: 10/May/19  Resolved: 10/May/19

Status: Closed
Project: ui-search
Components: None
Affects versions: None
Fix versions: 1.7.0

Type: Bug Priority: P4
Reporter: John Malconian Assignee: Zak Burke
Resolution: Done Votes: 0
Labels: bug-search, front-end, functional-backlog, q1-2019, triaged
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Attachments: PNG File Screen Shot 2019-04-09 at 7.28.12 PM.png     PNG File Screen Shot 2019-04-09 at 7.29.34 PM.png     PNG File Skärmavbild 2019-04-10 kl. 16.50.09.png     PNG File Skärmavbild 2019-04-10 kl. 16.53.55.png     PNG File Unsupport_sort_inddex_contributor.png    
Sprint:
Development Team: Prokopovych

 Description   

colored textThere seem to be a couple of issues with the Q1 release. The following issue can be duplicated on the latest Q1 release build at https://folio-bellis.aws.indexdata.com

Steps to reproduce:

1. Open Codex Search app. Search for 'ABA Journal'. Click on any of the results. The following error occurs:

ERROR: in module @folio/inventory, operation GET on selected resource 'selectedInstance' failed, saying not found.

2. Go back to Codex Search app. The following error occurs:

Please refresh the page. The following occurred resulting in the current page becoming unstable. Error: cannot read property 'length' of null.

Screenshots attached.



 Comments   
Comment by Zak Burke [ 10/Apr/19 ]

Based on the IDs in the URLs, it looks like we're finding ui-eHolidings entries and trying to look them up in ui-inventory.

Comment by Zak Burke [ 10/Apr/19 ]

It's hard to determine the exact cause of the second error since the source is minified, but it appears to (maybe) be a problem with the way filters are generated, maaaaybe a problem with something that is initialized in CDM but not correctly handled in CDU? (I sort of hate react's lifecycle methods.)

This same issue appears on folio-testing where the source is not minified. The issue is in src/Search/model/parseFiltersString.js.

Comment by Jakub Skoczen [ 10/Apr/19 ]

Charlotte Whitt Cate Boerema Oleksiy_Lemeshko Guys. should this be prioritized for Core:func.

Comment by Charlotte Whitt [ 10/Apr/19 ]

Hi John Malconian - you write ADA Journal in your description (search on that in Bellis in Codex Search gives 28,471 records found in KB, and 0 in Local). But maybe you mean ABA journal?

ABA journal in Inventory is one of the individual loaded sample records. This record holds detailed holdings data entered by TAMU.

Just tested search on: Al Gore and global warming - same problem

CC: Jakub Skoczen Niels Erik Nielsen Oleksiy_Lemeshko Cate Boerema

Comment by Charlotte Whitt [ 10/Apr/19 ]

I just followed the steps and searched on ABA journal.

This should only give one hit in Inventory

But what we see, when following the link in Inventory then the result list holds 137 results

So that might be why the page crash in Codex Search (and needs to be refreshed) when going back to Codex Search.

Comment by Zak Burke [ 10/Apr/19 ]

The ABA record may be "special" in some regards, which could be unfortunate, but there are at least three bugs here:

  1. ui-search is generating links to ui-inventory for entries found in ui-eHoldings (try a search for something like "science" and note that you get results from both eholdings and local inventory, but clicking a result for either source always takes you to inventory).
  2. ui-search explodes when returning to search results by clicking a result (navigating away from ui-search) and back again. This happens even if you click a legit link, e.g. a valid link to ui-inventory.
  3. ui-inventory does not handle 404s gracefully, showing an alert with technical details instead of, say, "We couldn't find that thing you were looking for."
Comment by Charlotte Whitt [ 10/Apr/19 ]

Zak Burke - would the result list display be a 4th bug?

Niels Erik Nielsen - what do you think?

Comment by Zak Burke [ 10/Apr/19 ]

I don't know whether the results list display should count as a 4th bug. The only data ui-search provides to ui-inventory is the UUID of the instance record. Look at the URL: there's no information about filters, a query, resource type, etc. This was implemented under UISE-93 Closed , and discussed extensively in PR #110 before ultimately being implemented in PR #152**. When linking to a full-pane details record, as we do for ui-eholdings, this feels right. When linking to a partial-pane details record that is part of a multi-column display, it feels awkward.

** Er, wait, PR #152 shows four commits but ultimately no changes, and a bit more spelunking shows redirectParams contains a typo: it links to inventory for all results regardless of their source. I feel like Niels Erik Nielsen and discussed this typo at one point, and PR #152 alludes to fixing a typo, but is clearly wonky as the end result of the PR is 0 files changed. Weird. Anyway, I put a PR up for that: PR #159. We could easily generate a v1.6.1 patch release if we want.

Unrelated, I put up PR #160 to patch the "step 2" error in the original description here (click-an-outbound link, then the back button, boom). That one, likewise, would be easy incorporate into a v1.6.1 patch release if we want.

Comment by Jakub Skoczen [ 12/Apr/19 ]

Zak Burke John Malconian I believe 1.6.1 is released? Can we include it in Bellis?

Comment by Zak Burke [ 12/Apr/19 ]

Yes, it was released yesterday but didn't make it into last night's build. I'll follow up with John Malconian.

Comment by John Malconian [ 12/Apr/19 ]

I'll take care of this today. Zak Burke

Comment by John Malconian [ 12/Apr/19 ]

https://folio-bellis.aws.indexdata.com has been rebuilt with the fix @zburke released (@folio/search v1.6.1) for UISE-110 Closed . It appears to me to work.

Comment by John Malconian [ 12/Apr/19 ]

Actually, it seemed to work initially but now I get new errors. See

Comment by Zak Burke [ 30/Apr/19 ]

Hmmm, that error message clearly represents a problem, but it's a problem with sort clauses, unrelated to the bugs originally described in this ticket. I've filed the sort bug under STSMACOM-194 Closed .

I think this ticket can be closed now. Agreed?

Comment by Zak Burke [ 10/May/19 ]

The bugs specific to ui-search were fixed in v1.6.1/v1.7.0.

Generated at Thu Feb 08 23:17:08 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.